Merged
Conversation
ae322e5 to
04a502e
Compare
04a502e to
e858e06
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #152 by refactoring table navigation keymaps to use <Plug> mappings, enabling users to customize or disable the default insert mode navigation keybindings while still having access to the underlying functionality.
Key Changes:
- Added four new
<Plug>mappings for insert mode table navigation (nav-left,nav-right,nav-up,nav-down) with built-in fallback to normal cursor movement - Refactored
setup_buffer_keymapsto map default keys (<A-h/j/k/l>) to the new<Plug>mappings instead of directly to navigation functions - Added comprehensive test coverage for
<Plug>mapping registration and conditional default keymap setup
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lua/markdown-plus/table/keymaps.lua | Added <Plug> mappings for insert mode navigation with fallback behavior; refactored default keymap setup to use these <Plug> mappings |
| spec/markdown-plus/table_spec.lua | Added test suite for keymap registration and conditional setup based on configuration options |
| doc/markdown-plus.txt | Documented the four new insert mode navigation <Plug> mappings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of the changes.
Type of Change
Related Issues
Fixes #152
Testing
Checklist