Skip to content

fix(mapping): table nav mapping#153

Merged
YousefHadder merged 2 commits intomainfrom
fix/table-nav-mapping
Dec 9, 2025
Merged

fix(mapping): table nav mapping#153
YousefHadder merged 2 commits intomainfrom
fix/table-nav-mapping

Conversation

@YousefHadder
Copy link
Owner

Description

Brief description of the changes.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Code refactoring
  • Performance improvement

Related Issues

Fixes #152

Testing

  • Tested manually
  • Added/updated tests (if applicable)

Checklist

  • Code follows project style
  • Self-reviewed my code
  • Commented complex logic
  • Updated documentation (if needed)
  • No new warnings generated

Copilot AI review requested due to automatic review settings December 9, 2025 09:11
@YousefHadder YousefHadder changed the title Fix/table nav mapping fix(mapping): table nav mapping Dec 9, 2025
@YousefHadder YousefHadder force-pushed the fix/table-nav-mapping branch from ae322e5 to 04a502e Compare December 9, 2025 09:12
@YousefHadder YousefHadder force-pushed the fix/table-nav-mapping branch from 04a502e to e858e06 Compare December 9, 2025 09:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #152 by refactoring table navigation keymaps to use <Plug> mappings, enabling users to customize or disable the default insert mode navigation keybindings while still having access to the underlying functionality.

Key Changes:

  • Added four new <Plug> mappings for insert mode table navigation (nav-left, nav-right, nav-up, nav-down) with built-in fallback to normal cursor movement
  • Refactored setup_buffer_keymaps to map default keys (<A-h/j/k/l>) to the new <Plug> mappings instead of directly to navigation functions
  • Added comprehensive test coverage for <Plug> mapping registration and conditional default keymap setup

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
lua/markdown-plus/table/keymaps.lua Added <Plug> mappings for insert mode navigation with fallback behavior; refactored default keymap setup to use these <Plug> mappings
spec/markdown-plus/table_spec.lua Added test suite for keymap registration and conditional setup based on configuration options
doc/markdown-plus.txt Documented the four new insert mode navigation <Plug> mappings

@YousefHadder YousefHadder merged commit 2f55299 into main Dec 9, 2025
15 checks passed
@YousefHadder YousefHadder deleted the fix/table-nav-mapping branch December 9, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] configurable keybinds for moving within a table

1 participant