Skip to content

Commit af5c3d9

Browse files
committed
Changed: Enhance profiling benchmarks for performance analysis
Enhances profiling benchmarks with improved memory allocation tracking, optimized query benchmarks, complete dimensional coverage (2D-5D), and environment variable control for faster iteration. It provides more comprehensive performance analysis for optimization work. This also introduces error handling for grid generation in benchmarks.
1 parent 3d86e5b commit af5c3d9

13 files changed

Lines changed: 939 additions & 286 deletions

File tree

.github/workflows/profiling-benchmarks.yml

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
mode:
88
description: 'Profiling mode'
99
required: false
10-
default: 'production'
10+
default: 'development'
1111
type: choice
1212
options:
1313
- 'development'
@@ -69,8 +69,7 @@ jobs:
6969
- name: Set profiling mode
7070
run: |
7171
INPUT_MODE="${{ github.event.inputs.mode }}"
72-
if [[ "$INPUT_MODE" == "development" ]] || \
73-
{ [[ "${{ github.event_name }}" == "workflow_dispatch" ]] && [[ -z "$INPUT_MODE" ]]; }; then
72+
if [[ "$INPUT_MODE" == "development" ]]; then
7473
echo "PROFILING_DEV_MODE=1" >> $GITHUB_ENV
7574
echo "Running in development mode (reduced scale)"
7675
else
@@ -92,10 +91,10 @@ jobs:
9291
BENCH_FILTER="-- ${{ github.event.inputs.benchmark_filter }}"
9392
fi
9493
95-
# Run profiling with memory allocation tracking
94+
# Run profiling (timing-focused)
9695
echo "Starting comprehensive profiling benchmarks..."
9796
if [[ -z "$BENCH_FILTER" ]] || [[ "$BENCH_FILTER" != *"memory"* ]]; then
98-
cargo bench --bench profiling_suite --features count-allocations $BENCH_FILTER \
97+
cargo bench --bench profiling_suite $BENCH_FILTER \
9998
2>&1 | tee profiling-results/profiling_output.log
10099
else
101100
# If filter contains memory, run only the filtered benchmarks
@@ -129,8 +128,11 @@ jobs:
129128
- **Profiling Mode**: ${{ env.PROFILING_DEV_MODE == '1' &&
130129
'Development (reduced scale for faster iteration)' ||
131130
'Production (full 10³-10⁶ point scale)' }}
132-
- **Memory Tracking**: Enabled (count-allocations feature)
133-
- **Benchmark Filter**: ${{ github.event.inputs.benchmark_filter || 'All benchmarks' }}
131+
- **Memory Tracking**: ${{ contains(github.event.inputs.benchmark_filter, 'memory') &&
132+
'Enabled for memory benchmarks (count-allocations feature)' ||
133+
'Enabled only for memory-specific runs' }}
134+
- **Benchmark Filter**: ${{ github.event.inputs.benchmark_filter != '' &&
135+
github.event.inputs.benchmark_filter || 'All benchmarks' }}
134136
135137
## Benchmark Categories Run
136138

0 commit comments

Comments
 (0)