refactor(coloring): tidy coloring tests and move validators#103
Merged
Conversation
Replace the thin helpers with direct calls to `SparsityPattern.from_coo(...)` and `SparsityPattern.from_dense(np.array(...))`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Relocate `_is_valid_row_coloring`, `_is_valid_col_coloring`, and `_is_valid_star_coloring` from `tests/test_coloring.py` to `src/asdex/coloring.py` so they live next to the algorithms they verify. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
- Coverage 98.56% 98.42% -0.15%
==========================================
Files 41 41
Lines 2304 2342 +38
==========================================
+ Hits 2271 2305 +34
- Misses 33 37 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_is_valid_row_coloring,_is_valid_col_coloring, and_is_valid_star_coloringfromtests/test_coloring.pytosrc/asdex/coloring.pyso the validators live next to the algorithms they verify._make_patternand_from_densehelpers intests/test_coloring.py.