Do not calculate expression twice in Node.js where size is not important (#580)

ai · web-flow · commit 7720742677a0 · 2026-04-12T13:32:46.000+02:00
diff --git a/index.js b/index.js
@@ -58,9 +58,10 @@ export function customRandom(alphabet, defaultSize, getRandom) {
       // A compact alternative for `for (let i = 0; i < step; i++)`.
       let i = step
       while (i--) {
+        let next = alphabet[bytes[i] & mask]
         // Adding `continue` refuses a random byte that exceeds the alphabet size.
-        if (!alphabet[bytes[i] & mask]) continue
-        id += alphabet[bytes[i] & mask]
+        if (!next) continue
+        id += next
         if (id.length >= size) return id
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -58,9 +58,10 @@ export function customRandom(alphabet, defaultSize, getRandom) {`
`58`	`58`	// A compact alternative for `for (let i = 0; i < step; i++)`.
`59`	`59`	`let i = step`
`60`	`60`	`while (i--) {`
	`61`	`+ let next = alphabet[bytes[i] & mask]`
`61`	`62`	// Adding `continue` refuses a random byte that exceeds the alphabet size.
`62`		`- if (!alphabet[bytes[i] & mask]) continue`
`63`		`- id += alphabet[bytes[i] & mask]`
	`63`	`+ if (!next) continue`
	`64`	`+ id += next`
`64`	`65`	`if (id.length >= size) return id`
`65`	`66`	`}`
`66`	`67`	`}`