Version 5.3.6

Author: martynasma

package.json

@@ -1,7 +1,7 @@
 {
   "private": true,
   "name": "@amcharts/amcharts5",
-  "version": "5.3.5",
+  "version": "5.3.6",
   "author": "amCharts <contact@amcharts.com> (https://www.amcharts.com/)",
   "description": "amCharts 5",
   "homepage": "https://www.amcharts.com/",

packages/geodata/CHANGELOG.md

@@ -13,6 +13,9 @@ adhere to [Semantic Versioning](http://semver.org/spec/v2.0.0.html) rules.
 ### Changed
 - Map of the Pakistan was updated to adhere to local requirements.
 
+### Fixed
+- Fixed IDs of lands in the map of Denmark.
+
 
 ## [5.1.0] - 2022-12-07
 

packages/shared/CHANGELOG.md

@@ -5,6 +5,19 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 Please note, that this project, while following numbering syntax, it DOES NOT
 adhere to [Semantic Versioning](http://semver.org/spec/v2.0.0.html) rules.
 
+## [5.3.6] - 2023-02-27
+
+### Added
+- New `cors` setting for `Picture` (defaults to `"anonymous"`).
+- `beginPath` method added to `CanvasGraphics`.
+
+### Fixed
+- Theme states no longer override user states.
+- In some specific cases with stacked axes series position could be shifted up.
+- In some specific cases a hairline of a column of a `ColumnSeries` could remain visible on the plot area even if the whole column was out of visible axis bounds.
+- A `ghostLabel` was causing some interfering issues with interactive labels of an axis.
+
+
 ## [5.3.5] - 2023-02-24
 
 ### Changed

src/.internal/charts/xy/axes/Axis.ts

@@ -191,9 +191,9 @@ export interface IAxisPrivate extends IComponentPrivate {
 
 	/**
 	 * @todo review
-     * Width in pixels between grid lines (read-only). It might not be exact, as DateAxis can have grids at irregular intervals. Could be used to detect when size changes and to adjust labels for them not to overlap.
-     */
-	cellWidth?:number;
+	 * Width in pixels between grid lines (read-only). It might not be exact, as DateAxis can have grids at irregular intervals. Could be used to detect when size changes and to adjust labels for them not to overlap.
+	 */
+	cellWidth?: number;
 }
 
 export interface IAxisDataItem extends IComponentDataItem {
@@ -393,10 +393,11 @@ export abstract class Axis<R extends AxisRenderer> extends Component {
 		this.children.push(renderer);
 		this.ghostLabel = renderer.makeLabel(new DataItem(this, undefined, {}), []);
 		this.ghostLabel.adapters.disable("text");
-		this.ghostLabel.set("opacity", 0);
+		this.ghostLabel.setAll({ opacity: 0, tooltipText: undefined, tooltipHTML: undefined, interactive: false });
+		this.ghostLabel.events.disable();
 	}
 
-	protected _updateFinals(_start:number, _end:number){
+	protected _updateFinals(_start: number, _end: number) {
 
 	}
 

src/.internal/charts/xy/series/BaseColumnSeries.ts

@@ -470,7 +470,7 @@ export abstract class BaseColumnSeries extends XYSeries {
 
 			this._updateSeriesGraphics(dataItem, graphics!, l, r, t, b, fitW, fitH);
 
-			if ((l < xStart && r < xStart) || (l > xEnd && r > xEnd) || (t < yStart && b < yStart) || (t > yEnd && b > yEnd) || $type.isNaN(l) || $type.isNaN(t)) {
+			if ((l < xStart && r < xStart) || (l > xEnd && r > xEnd) || (t < yStart && b <= yStart) || (t >= yEnd && b > yEnd) || $type.isNaN(l) || $type.isNaN(t)) {
 				this._toggleColumn(dataItem, false);
 			}
 			else {

src/.internal/charts/xy/series/XYSeries.ts

@@ -961,10 +961,18 @@ export abstract class XYSeries extends Series {
 			}
 		}))
 
-		if (!this.get("baseAxis")) {
-			const xAxis = this.get("xAxis");
-			const yAxis = this.get("yAxis");
+		const xAxis = this.get("xAxis");
+		const yAxis = this.get("yAxis");
+
+		this._disposers.push(xAxis.events.on("positionchanged", () => {
+			this._fixPosition();
+		}))
+
+		this._disposers.push(yAxis.events.on("positionchanged", () => {
+			this._fixPosition();
+		}))
 
+		if (!this.get("baseAxis")) {
 			if (yAxis.isType<CategoryAxis<any>>("CategoryAxis") || yAxis.isType<DateAxis<any>>("DateAxis")) {
 				this.set("baseAxis", yAxis);
 			}
@@ -1180,6 +1188,17 @@ export abstract class XYSeries extends Series {
 		}
 	}
 
+	protected _fixPosition() {
+		const xAxis = this.get("xAxis");
+		const yAxis = this.get("yAxis");
+
+		this.set("x", xAxis.x() - $utils.relativeToValue(xAxis.get("centerX", 0), xAxis.width()) - xAxis.parent!.get("paddingLeft", 0));
+		this.set("y", yAxis.y() - $utils.relativeToValue(yAxis.get("centerY", 0), yAxis.height()) - yAxis.parent!.get("paddingTop", 0));
+
+		this.bulletsContainer.set("y", this.y());
+		this.bulletsContainer.set("x", this.x());
+	}
+
 
 	public _prepareChildren() {
 		super._prepareChildren();
@@ -1239,10 +1258,7 @@ export abstract class XYSeries extends Series {
 		}
 
 
-		this.set("x", xAxis.x() - $utils.relativeToValue(xAxis.get("centerX", 0), xAxis.width()) - xAxis.parent!.get("paddingLeft", 0));
-		this.set("y", yAxis.y() - $utils.relativeToValue(yAxis.get("centerY", 0), yAxis.height()) - yAxis.parent!.get("paddingTop", 0));
-		this.bulletsContainer.set("y", this.y());
-		this.bulletsContainer.set("x", this.x());
+		this._fixPosition();
 
 		const stacked = this.get("stacked");
 
@@ -1311,7 +1327,7 @@ export abstract class XYSeries extends Series {
 			this._markStakedDirtyStack();
 
 			//this.updateLegendMarker(undefined); // causes legend marker to change color instantly when on
-			if(!this.get("tooltipDataItem")){
+			if (!this.get("tooltipDataItem")) {
 				this.updateLegendValue(undefined);
 			}
 		}
@@ -1759,7 +1775,7 @@ export abstract class XYSeries extends Series {
 				let bullets = dataItem.bullets;
 				if (bullets) {
 					$array.each(bullets, (bullet) => {
-						if(bullet){
+						if (bullet) {
 							let sprite = bullet.get("sprite");
 							if (sprite) {
 								sprite.setPrivate("visible", false);
@@ -1993,11 +2009,11 @@ export abstract class XYSeries extends Series {
 
 	public hideTooltip(): Promise<void> | undefined {
 		const tooltip = this.get("tooltip");
-		if(tooltip){
+		if (tooltip) {
 			tooltip.set("tooltipTarget", this);
 		}
 		return super.hideTooltip();
-	}	
+	}
 
 	protected _getTooltipTarget(dataItem: DataItem<this["_dataItemSettings"]>): Sprite {
 		if (this.get("seriesTooltipTarget") == "bullet") {

src/.internal/core/Registry.ts

@@ -6,7 +6,7 @@ export class Registry {
 	/**
 	 * Currently running version of amCharts.
 	 */
-	readonly version: string = "5.3.5";
+	readonly version: string = "5.3.6";
 
 	/**
 	 * List of applied licenses.

src/.internal/core/render/Picture.ts

@@ -14,6 +14,14 @@ export interface IPictureSettings extends ISpriteSettings {
 	 */
 	src?: string;
 
+	/**
+	 * CORS settings for loading the image. Defaults to "anonymous".
+	 *
+	 * @since 5.3.6
+	 * @see {@link https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/crossOrigin} for more info
+	 */
+	cors?: string | null;
+
 	/**
 	 * Color of the element's shadow.
 	 *
@@ -116,7 +124,7 @@ export class Picture extends Sprite {
 			this._display.shadowOpacity = this.get("shadowOpacity");
 		}
 
-		if (this.isDirty("src")) {
+		if (this.isDirty("src") || this.isDirty("cors")) {
 			this._display.clear();
 			this._load();
 		}
@@ -126,7 +134,7 @@ export class Picture extends Sprite {
 		const src = this.get("src");
 		if (src) {
 			const image = new Image();
-			//image.crossOrigin = "Anonymous";
+			image.crossOrigin = this.get("cors", "anonymous");
 			image.src = src!;
 			image.decode().then(() => {
 				this._display.image = image;

src/.internal/core/render/backend/CanvasRenderer.ts

@@ -706,6 +706,15 @@ abstract class Op {
 	public addBounds(_bounds: IBounds): void { }
 }
 
+/**
+ * @ignore
+ */
+class BeginPath extends Op {
+	public colorize(context: CanvasRenderingContext2D, _forceColor: string | undefined): void {
+		context.beginPath();
+	}
+}
+
 /**
  * @ignore
  */
@@ -1098,6 +1107,10 @@ export class CanvasGraphics extends CanvasDisplayObject implements IGraphics {
 		this._pushOp(new EndStroke());
 	}
 
+	beginPath(): void {
+		this._pushOp(new BeginPath());
+	}
+
 	lineStyle(width: number = 0, color?: Color | CanvasGradient | CanvasPattern, alpha: number = 1, lineJoin?: "miter" | "round" | "bevel"): void {
 		this._strokeAlpha = alpha;
 		if (color) {

src/.internal/core/render/backend/Renderer.ts

@@ -171,6 +171,7 @@ export interface IGraphics extends IDisplayObject {
 
 	beginFill(color?: Color | IGradient | IPattern, alpha?: number): void;
 	endFill(): void;
+	beginPath(): void;
 
 	lineStyle(width?: number, color?: Color | IGradient | IPattern, alpha?: number, lineJoin?: "miter" | "round" | "bevel"): void;
 	setLineDash(dash?: number[]): void;