Merge 79e42f9 into 897d04e

Author: jgmelber

.gitignore

@@ -20,3 +20,4 @@ id_ed25519.pub
 *.model
 .cline_storage
 *.egg-info
+CLAUDE.md

aie_kernels/aie2/dual_gemv_silu_mul.cc

@@ -0,0 +1,79 @@
+// SPDX-FileCopyrightText: Copyright (C) 2025 Advanced Micro Devices, Inc. All rights reserved.
+// SPDX-License-Identifier: Apache-2.0
+
+// Fused dual-GEMV + SiLU + elementwise multiply kernel for AIE2.
+// Same structure as AIE2+ variant but uses LUT-based getTanhBf16.
+
+#define NOCPP
+
+#include "../aie_kernel_utils.h"
+#include "lut_based_ops.h"
+
+#include <aie_api/aie.hpp>
+#include <stdint.h>
+#include <type_traits>
+
+static bfloat16 left_buf[2048] __attribute__((aligned(64)));
+static bfloat16 right_buf[2048] __attribute__((aligned(64)));
+
+template <uint32_t r>
+void matvec_vectorized(uint32_t m,
+                       uint32_t k,
+                       const bfloat16 *__restrict a,
+                       const bfloat16 *__restrict b,
+                       bfloat16 *__restrict c)
+{
+    ::aie::set_rounding(aie::rounding_mode::conv_even);
+    bfloat16 *c_end = c + m;
+    const bfloat16 *b_end = b + k;
+    for (; c < c_end; c++) {
+        aie::accum acc = aie::zeros<accfloat, r>();
+        AIE_LOOP_MIN_ITERATION_COUNT(2)
+        for (const bfloat16 *__restrict b_cur = b; b_cur < b_end; b_cur += r, a += r) {
+            aie::vector<bfloat16, r> a_vec = aie::load_v<r>(a);
+            aie::vector<bfloat16, r> b_vec = aie::load_v<r>(b_cur);
+            acc = aie::mac(acc, a_vec, b_vec);
+        }
+        *c = static_cast<bfloat16>(aie::reduce_add(acc.template to_vector<float>()));
+    }
+}
+
+extern "C" {
+
+void dual_gemv_matvec_bf16(uint32_t m,
+                           uint32_t k,
+                           uint32_t row_offset,
+                           const bfloat16 *__restrict a_in,
+                           const bfloat16 *__restrict b_in,
+                           uint32_t phase)
+{
+    bfloat16 *dst = (phase == 0) ? left_buf : right_buf;
+    dst += row_offset;
+    matvec_vectorized<64>(m, k, a_in, b_in, dst);
+}
+
+void dual_gemv_silu_mul_bf16(bfloat16 *__restrict c_out, int32_t m_output)
+{
+    event0();
+
+    aie::vector<bfloat16, 16> register_0_5 = aie::broadcast<bfloat16, 16>(0.5f);
+    aie::vector<bfloat16, 16> register_1 = aie::broadcast<bfloat16, 16>(1.0f);
+    AIE_PREPARE_FOR_PIPELINING
+    for (int i = 0; i < m_output; i += 16) {
+        aie::vector<bfloat16, 16> left_val = aie::load_v<16>(left_buf + i);
+        aie::vector<bfloat16, 16> right_val = aie::load_v<16>(right_buf + i);
+
+        aie::vector<bfloat16, 16> half_x = aie::mul(left_val, register_0_5);
+        aie::vector<bfloat16, 16> tanh_half_x = getTanhBf16(half_x);
+        auto tanh_half_x_approx = aie::add(tanh_half_x, register_1);
+        aie::vector<bfloat16, 16> sigmoid_approx = aie::mul(tanh_half_x_approx, register_0_5);
+        auto silu_output = aie::mul(left_val, sigmoid_approx);
+
+        auto fused_output = aie::mul(silu_output.to_vector<bfloat16>(), right_val);
+        aie::store_v(c_out + i, fused_output.to_vector<bfloat16>());
+    }
+
+    event1();
+}
+
+} // extern "C"

aie_kernels/aie2/flowkv.cc

@@ -0,0 +1,251 @@
+// SPDX-FileCopyrightText: Copyright (C) 2025 Advanced Micro Devices, Inc. All rights reserved.
+// SPDX-License-Identifier: Apache-2.0
+
+// FlowKV decode attention kernel for AIE2+.
+//
+// Implements streaming decode attention with online softmax using a 2-tile
+// pipeline per KV head group:
+//
+//   Score tile (CT0): Computes Q * K^T / sqrt(d) with online softmax tracking.
+//     Maintains running max and denominator across chunks.
+//     Outputs a packed buffer [F_c | C_c | l] to the value tile via on-chip
+//     FIFO each chunk iteration.
+//
+//   Value tile (CT1): Accumulates weighted values with correction.
+//     Reads the packed buffer from the score tile FIFO each chunk.
+//     Saves the denominator from the last chunk in a static buffer so that
+//     normalize can read it after all FIFO buffers are released.
+//     Final normalization: O = Y / l.
+//
+// Both tiles share this single .o file. Each Worker calls a different subset
+// of functions. Static buffers are per-tile (each tile gets its own copy).
+//
+// Packed inter-tile buffer layout (bf16):
+//   [0 .. chunk_size*group_size - 1]                      : F_c scores
+//   [chunk_size*group_size .. chunk_size*group_size + gs-1] : C_c correction
+//   [chunk_size*group_size + gs .. chunk_size*group_size + 2*gs - 1] : l denom
+
+#define NOCPP
+
+#include "../aie_kernel_utils.h"
+
+#include <aie_api/aie.hpp>
+#include <stdint.h>
+#include <type_traits>
+
+// ---------------------------------------------------------------------------
+// Score tile: static softmax state (only used by score tile Worker)
+// ---------------------------------------------------------------------------
+static float score_running_max[4] __attribute__((aligned(64)));
+static float score_running_sum[4] __attribute__((aligned(64)));
+
+// ---------------------------------------------------------------------------
+// Value tile: accumulated output in f32 for precision
+// ---------------------------------------------------------------------------
+static float value_accum[4 * 64] __attribute__((aligned(64)));
+
+// Saved denominator from the last chunk (written by accum, read by normalize)
+static float saved_denom[4] __attribute__((aligned(64)));
+
+extern "C" {
+
+// ============================= Score Tile ====================================
+
+// Initialize softmax state at the start of a new attention computation.
+void flowkv_score_init_bf16(int32_t num_q_heads)
+{
+    for (int h = 0; h < num_q_heads; h++) {
+        score_running_max[h] = -1e30f;
+        score_running_sum[h] = 0.0f;
+    }
+}
+
+// Compute attention scores for one K chunk and update online softmax state.
+// Writes results into a single packed inter-tile buffer.
+//
+// q_in:      (num_q_heads, head_dim)  -- query vectors for this KV group
+// k_chunk:   (chunk_size, head_dim)   -- K cache chunk
+// packed_out: packed buffer for inter-tile FIFO:
+//   [0 .. cs*gs-1]: F_c scores in (chunk_size, num_q_heads) layout
+//   [cs*gs .. cs*gs+gs-1]: C_c correction factors
+//   [cs*gs+gs .. cs*gs+2*gs-1]: l denominators
+void flowkv_score_chunk_bf16(const bfloat16 *__restrict q_in, const bfloat16 *__restrict k_chunk,
+                              bfloat16 *__restrict packed_out, int32_t num_q_heads, int32_t head_dim,
+                              int32_t chunk_size)
+{
+    event0();
+    ::aie::set_rounding(aie::rounding_mode::conv_even);
+
+    const float inv_sqrt_d = 0.125f; // 1/sqrt(64) = 1/8
+
+    const int32_t scores_size = chunk_size * num_q_heads;
+    bfloat16 *scores_out = packed_out;
+    bfloat16 *correction_out = packed_out + scores_size;
+    bfloat16 *denom_out = packed_out + scores_size + num_q_heads;
+
+    for (int h = 0; h < num_q_heads; h++) {
+        const bfloat16 *q_head = q_in + h * head_dim;
+        float m_old = score_running_max[h];
+        float l_old = score_running_sum[h];
+
+        // Phase 1: Compute dot products and find chunk-local max
+        // Store scores as bf16 to avoid float array auto-vectorization issues
+        bfloat16 scores_bf16[32]; // chunk_size max = 32
+        bfloat16 m_chunk_bf16 = static_cast<bfloat16>(-1e30f);
+
+        for (int pos = 0; pos < chunk_size; pos++) {
+            const bfloat16 *k_pos = k_chunk + pos * head_dim;
+
+            // Vectorized dot product: head_dim=64 using single accum
+            aie::accum<accfloat, 32> acc = aie::zeros<accfloat, 32>();
+
+            auto q_vec0 = aie::load_v<32>(q_head);
+            auto k_vec0 = aie::load_v<32>(k_pos);
+            acc = aie::mac(acc, q_vec0, k_vec0);
+
+            auto q_vec1 = aie::load_v<32>(q_head + 32);
+            auto k_vec1 = aie::load_v<32>(k_pos + 32);
+            acc = aie::mac(acc, q_vec1, k_vec1);
+
+            bfloat16 score = static_cast<bfloat16>(
+                aie::reduce_add(acc.to_vector<float>()) * inv_sqrt_d);
+
+            scores_bf16[pos] = score;
+            if (static_cast<float>(score) > static_cast<float>(m_chunk_bf16)) {
+                m_chunk_bf16 = score;
+            }
+        }
+
+        // Phase 2: Online softmax update using bf16 vector ops
+        float m_chunk_f = static_cast<float>(m_chunk_bf16);
+        float m_new = (m_chunk_f > m_old) ? m_chunk_f : m_old;
+        bfloat16 m_new_bf16 = static_cast<bfloat16>(m_new);
+
+        // C_c = exp2((m_old - m_new) * log2e) via vector exp2
+        bfloat16 corr_scaled = static_cast<bfloat16>((m_old - m_new) * 1.4453125f);
+        aie::vector<bfloat16, 16> corr_in_vec = aie::broadcast<bfloat16, 16>(corr_scaled);
+        aie::accum<accfloat, 16> corr_acc(corr_in_vec);
+        aie::vector<bfloat16, 16> corr_exp = aie::exp2<bfloat16>(corr_acc.to_vector<float>());
+        float c_correction = static_cast<float>(corr_exp[0]);
+
+        bfloat16 l_new_bf16 = static_cast<bfloat16>(c_correction * l_old);
+
+        // Compute exp2 for each score position — one at a time, no float arrays
+        for (int pos = 0; pos < chunk_size; pos++) {
+            bfloat16 diff = static_cast<bfloat16>(
+                (static_cast<float>(scores_bf16[pos]) - m_new) * 1.4453125f);
+            aie::vector<bfloat16, 16> diff_vec = aie::broadcast<bfloat16, 16>(diff);
+            aie::accum<accfloat, 16> diff_acc(diff_vec);
+            aie::vector<bfloat16, 16> exp_result = aie::exp2<bfloat16>(diff_acc.to_vector<float>());
+            bfloat16 f_bf16 = exp_result[0];
+            l_new_bf16 = static_cast<bfloat16>(static_cast<float>(l_new_bf16) + static_cast<float>(f_bf16));
+            scores_out[pos * num_q_heads + h] = f_bf16;
+        }
+
+        // Update running state
+        score_running_max[h] = m_new;
+        score_running_sum[h] = static_cast<float>(l_new_bf16);
+
+        // Write correction and denominator to packed buffer
+        correction_out[h] = static_cast<bfloat16>(c_correction);
+        denom_out[h] = l_new_bf16;
+    }
+
+    event1();
+}
+
+// ============================= Value Tile ====================================
+
+// Initialize the value accumulator.
+void flowkv_value_init_bf16(int32_t num_q_heads, int32_t head_dim)
+{
+    int total = num_q_heads * head_dim;
+    for (int i = 0; i < total; i++) {
+        value_accum[i] = 0.0f;
+    }
+    for (int h = 0; h < num_q_heads; h++) {
+        saved_denom[h] = 0.0f;
+    }
+}
+
+// Accumulate weighted values for one chunk.
+// Reads scores and correction from the packed inter-tile buffer.
+// Saves the denominator into a static buffer for later normalization.
+//
+// packed_in: packed buffer from score tile FIFO
+//   [0..cs*gs-1]: F_c scores
+//   [cs*gs..cs*gs+gs-1]: C_c correction
+//   [cs*gs+gs..cs*gs+2*gs-1]: l denom
+// v_chunk: (chunk_size, head_dim) -- V cache chunk from DDR
+void flowkv_value_accum_bf16(const bfloat16 *__restrict packed_in, const bfloat16 *__restrict v_chunk,
+                              int32_t num_q_heads, int32_t head_dim, int32_t chunk_size)
+{
+    event0();
+    ::aie::set_rounding(aie::rounding_mode::conv_even);
+
+    const int32_t scores_size = chunk_size * num_q_heads;
+    const bfloat16 *scores_in = packed_in;
+    const bfloat16 *correction_in = packed_in + scores_size;
+    const bfloat16 *denom_in = packed_in + scores_size + num_q_heads;
+
+    for (int h = 0; h < num_q_heads; h++) {
+        float correction = static_cast<float>(correction_in[h]);
+        float *y_head = value_accum + h * head_dim;
+
+        // Save denominator for final normalization
+        saved_denom[h] = static_cast<float>(denom_in[h]);
+
+        // Apply correction to accumulated output: Y = C_c * Y_old
+        aie::vector<float, 16> corr_vec = aie::broadcast<float, 16>(correction);
+        for (int d = 0; d < head_dim; d += 16) {
+            aie::vector<float, 16> y_vec = aie::load_v<16>(y_head + d);
+            y_vec = aie::mul(y_vec, corr_vec);
+            aie::store_v(y_head + d, y_vec);
+        }
+
+        // Accumulate: Y += sum_pos( F_c[pos, h] * V[pos, :] )
+        for (int pos = 0; pos < chunk_size; pos++) {
+            float f = static_cast<float>(scores_in[pos * num_q_heads + h]);
+            const bfloat16 *v_pos = v_chunk + pos * head_dim;
+            aie::vector<float, 16> f_vec = aie::broadcast<float, 16>(f);
+
+            for (int d = 0; d < head_dim; d += 16) {
+                aie::vector<float, 16> y_vec = aie::load_v<16>(y_head + d);
+                aie::vector<bfloat16, 16> v_vec = aie::load_v<16>(v_pos + d);
+                aie::accum<accfloat, 16> v_acc(v_vec);
+                aie::vector<float, 16> v_f32 = v_acc.to_vector<float>();
+                aie::vector<float, 16> fv = aie::mul(f_vec, v_f32);
+                y_vec = aie::add(y_vec, fv);
+                aie::store_v(y_head + d, y_vec);
+            }
+        }
+    }
+
+    event1();
+}
+
+// Normalize and produce final output: O = Y / l.
+// Reads the denominator from saved_denom (set by the last accum call).
+//
+// output: (num_q_heads, head_dim) -- final attention output in bf16
+void flowkv_value_normalize_bf16(bfloat16 *__restrict output, int32_t num_q_heads, int32_t head_dim)
+{
+    ::aie::set_rounding(aie::rounding_mode::conv_even);
+
+    for (int h = 0; h < num_q_heads; h++) {
+        float inv_l = aie::inv(saved_denom[h]);
+        aie::vector<float, 16> inv_l_vec = aie::broadcast<float, 16>(inv_l);
+        float *y_head = value_accum + h * head_dim;
+        bfloat16 *o_head = output + h * head_dim;
+
+        for (int d = 0; d < head_dim; d += 16) {
+            aie::vector<float, 16> y_vec = aie::load_v<16>(y_head + d);
+            aie::vector<float, 16> scaled = aie::mul(y_vec, inv_l_vec);
+            aie::accum<accfloat, 16> y_acc(scaled);
+            aie::vector<bfloat16, 16> out_vec = y_acc.to_vector<bfloat16>();
+            aie::store_v(o_head + d, out_vec);
+        }
+    }
+}
+
+} // extern "C"