Fix favicon location#215
Closed
jirikolarik wants to merge 1 commit into
Closed
Conversation
Owner
|
Does this also work if you specify the pats |
Contributor
Author
|
It doesn't. I think that we should have absolute url for favicon if publicPath is not specified. I can add these two updates in another PR or update this one |
Owner
|
Why should it be absolute? this would destroy the backwards compatibility |
Contributor
Author
|
Because current implementation is wrong. Favicon, same as assets (js, css) should be still on the same location and not relative |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider publicPath in
favicon.icolocationResolves #208