fix(app): handle crypto.randomUUID failure in non-secure browser contexts #12988
+21
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
|
@selimerunkut let's create a shared utility for new IDs to clean this up a bit |
Contributor
|
I went ahead and took care of this, gave you credit in the commit |
Contributor
Author
|
Thanks, saw the notification just now.
…On Thu, 12 Feb 2026, 20:27 Adam, ***@***.***> wrote:
*adamdotdevin* left a comment (anomalyco/opencode#12988)
<#12988 (comment)>
I went ahead and took care of this, gave you credit in the commit
—
Reply to this email directly, view it on GitHub
<#12988 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHNRTE5FQJUWHLP5B5TZGY34LR5TJAVCNFSM6AAAAACUUFF6SKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQOJQHE2TENBXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12989
crypto.randomUUID()throws aDOMExceptionwhen called in a non-secure browser context (plain HTTP, not HTTPS). This crashes the web UI when attaching images and in a couple other spots.The existing code used optional chaining (
crypto.randomUUID?.()) but that doesn't help — the method exists on thecryptoobject, it just throws when the context isn't secure.Fix:
Replace optional chaining with try/catch in the 3 browser-context usages:
packages/app/src/components/prompt-input/attachments.tspackages/app/src/context/comments.tsxpackages/app/src/utils/perf.tsFalls back to
Math.random().toString(16).slice(2)on failure (same fallback as before, just actually reachable now).Server-side usages (packages/opencode, packages/enterprise) are unaffected since Node/Bun always has a secure context.
Testing:
Ran the web UI locally over HTTP, confirmed image attachment works without the randomUUID crash.