Skip to content

Commit 17ebc2e

Browse files
committed
Modify test_log_output_configurations to improve log message capturing:
- Replace caplog with targeted mocking of PodManager logger
1 parent fe4d3ed commit 17ebc2e

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

kubernetes-tests/tests/kubernetes_tests/test_kubernetes_pod_operator.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1453,7 +1453,7 @@ def test_init_container_logs_filtered(self, mock_get_connection):
14531453
],
14541454
)
14551455
def test_log_output_configurations(
1456-
self, mock_get_connection, caplog, log_prefix_enabled, log_formatter, expected_log_message_check
1456+
self, mock_get_connection, log_prefix_enabled, log_formatter, expected_log_message_check
14571457
):
14581458
"""
14591459
Tests various log output configurations (log_prefix, log_formatter)
@@ -1474,9 +1474,11 @@ def test_log_output_configurations(
14741474
log_formatter=log_formatter,
14751475
)
14761476
context = create_context(k)
1477-
with caplog.at_level(logging.INFO, logger="airflow.task.operators"):
1477+
logger = logging.getLogger("airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager")
1478+
with mock.patch.object(logger, "info") as mock_info:
14781479
k.execute(context)
1479-
assert any(expected_log_message_check(marker, record.message) for record in caplog.records)
1480+
captured_messages = [call_args[0] for call_args in mock_info.call_args_list if call_args]
1481+
assert any(expected_log_message_check(marker, msg) for msg in captured_messages)
14801482

14811483

14821484
# TODO: Task SDK: https://github.com/apache/airflow/issues/45438

0 commit comments

Comments
 (0)