fixup! Render view_url_template in view_url

Author: ephraimbuddy

airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dags.py

@@ -403,8 +403,10 @@ class TestDagDetails(TestDagEndpoint):
         ],
     )
     @pytest.mark.usefixtures("configure_git_connection_for_dag_bundle")
+    @mock.patch("airflow.api_fastapi.core_api.datamodels.dag_versions.hasattr")
     def test_dag_details(
         self,
+        mock_hasattr,
         test_client,
         query_params,
         dag_id,
@@ -413,6 +415,7 @@ def test_dag_details(
         start_date,
         owner_links,
     ):
+        mock_hasattr.return_value = False
         response = test_client.get(f"/dags/{dag_id}/details", params=query_params)
         assert response.status_code == expected_status_code
         if expected_status_code != 200:
@@ -489,6 +492,100 @@ def test_dag_details(
         }
         assert res_json == expected
 
+    @pytest.mark.parametrize(
+        "query_params, dag_id, expected_status_code, dag_display_name, start_date, owner_links",
+        [
+            ({}, "fake_dag_id", 404, "fake_dag", "2023-12-31T00:00:00Z", {}),
+            ({}, DAG2_ID, 200, DAG2_ID, "2021-06-15T00:00:00Z", {}),
+        ],
+    )
+    @pytest.mark.usefixtures("configure_git_connection_for_dag_bundle")
+    def test_dag_details_with_view_url_template(
+        self,
+        test_client,
+        query_params,
+        dag_id,
+        expected_status_code,
+        dag_display_name,
+        start_date,
+        owner_links,
+    ):
+        response = test_client.get(f"/dags/{dag_id}/details", params=query_params)
+        assert response.status_code == expected_status_code
+        if expected_status_code != 200:
+            return
+
+        # Match expected and actual responses below.
+        res_json = response.json()
+        last_parsed = res_json["last_parsed"]
+        last_parsed_time = res_json["last_parsed_time"]
+        file_token = res_json["file_token"]
+        expected = {
+            "bundle_name": "dag_maker",
+            "bundle_version": None,
+            "asset_expression": None,
+            "catchup": False,
+            "concurrency": 16,
+            "dag_id": dag_id,
+            "dag_display_name": dag_display_name,
+            "dag_run_timeout": None,
+            "default_args": {
+                "depends_on_past": False,
+                "retries": 1,
+                "retry_delay": "PT5M",
+            },
+            "description": None,
+            "doc_md": "details",
+            "deadline": None,
+            "end_date": None,
+            "fileloc": __file__,
+            "file_token": file_token,
+            "has_import_errors": False,
+            "has_task_concurrency_limits": True,
+            "is_stale": False,
+            "is_paused": False,
+            "is_paused_upon_creation": None,
+            "latest_dag_version": {
+                "bundle_name": "dag_maker",
+                "bundle_url": "http://test_host.github.com/tree/None/dags",
+                "bundle_version": None,
+                "created_at": mock.ANY,
+                "dag_id": "test_dag2",
+                "id": mock.ANY,
+                "version_number": 1,
+                "dag_display_name": dag_display_name,
+            },
+            "last_expired": None,
+            "last_parsed": last_parsed,
+            "last_parsed_time": last_parsed_time,
+            "max_active_runs": 16,
+            "max_active_tasks": 16,
+            "max_consecutive_failed_dag_runs": 0,
+            "next_dagrun_data_interval_end": None,
+            "next_dagrun_data_interval_start": None,
+            "next_dagrun_logical_date": None,
+            "next_dagrun_run_after": None,
+            "owners": ["airflow"],
+            "owner_links": {},
+            "params": {
+                "foo": {
+                    "__class": "airflow.sdk.definitions.param.Param",
+                    "description": None,
+                    "schema": {},
+                    "value": 1,
+                }
+            },
+            "relative_fileloc": "test_dags.py",
+            "render_template_as_native_obj": False,
+            "timetable_summary": None,
+            "start_date": start_date,
+            "tags": [],
+            "template_search_path": None,
+            "timetable_description": "Never, external triggers only",
+            "timezone": UTC_JSON_REPR,
+        }
+        assert res_json == expected
+
     def test_dag_details_should_response_401(self, unauthenticated_test_client):
         response = unauthenticated_test_client.get(f"/dags/{DAG1_ID}/details")
         assert response.status_code == 401

airflow-core/tests/unit/cli/commands/test_asset_command.py

@@ -23,6 +23,7 @@
 import json
 import os
 import typing
+from unittest import mock
 
 import pytest
 
@@ -119,7 +120,9 @@ def test_cli_assets_alias_details(parser: ArgumentParser) -> None:
     assert alias_detail_list[0] | undeterministic == undeterministic | {"name": "example-alias", "group": ""}
 
 
-def test_cli_assets_materialize(parser: ArgumentParser) -> None:
+@mock.patch("airflow.api_fastapi.core_api.datamodels.dag_versions.hasattr")
+def test_cli_assets_materialize(mock_hasattr, parser: ArgumentParser) -> None:
+    mock_hasattr.return_value = False
     args = parser.parse_args(["assets", "materialize", "--name=asset1_producer", "--output=json"])
     with contextlib.redirect_stdout(io.StringIO()) as temp_stdout:
         asset_command.asset_materialize(args)
@@ -157,3 +160,41 @@ def test_cli_assets_materialize(parser: ArgumentParser) -> None:
         "triggering_user_name": "root",
         "run_after": "2025-02-12T19:27:59.066046Z",
     }
+
+
+def test_cli_assets_materialize_with_view_url_template(parser: ArgumentParser) -> None:
+    args = parser.parse_args(["assets", "materialize", "--name=asset1_producer", "--output=json"])
+    with contextlib.redirect_stdout(io.StringIO()) as temp_stdout:
+        asset_command.asset_materialize(args)
+
+    output = temp_stdout.getvalue()
+    run_list = json.loads(output)
+    assert len(run_list) == 1
+
+    # No good way to statically compare these.
+    undeterministic: dict = {
+        "dag_run_id": None,
+        "dag_versions": [],
+        "data_interval_end": None,
+        "data_interval_start": None,
+        "logical_date": None,
+        "queued_at": None,
+        "run_after": "2025-02-12T19:27:59.066046Z",
+    }
+
+    assert run_list[0] | undeterministic == undeterministic | {
+        "conf": {},
+        "bundle_version": None,
+        "dag_display_name": "asset1_producer",
+        "dag_id": "asset1_producer",
+        "end_date": None,
+        "duration": None,
+        "last_scheduling_decision": None,
+        "note": None,
+        "run_type": "manual",
+        "start_date": None,
+        "state": "queued",
+        "triggered_by": "cli",
+        "triggering_user_name": "root",
+        "run_after": "2025-02-12T19:27:59.066046Z",
+    }