Commit ab9c062
# Which issue does this PR close?
fixes #8221
# Rationale for this change
It blocks users from building if the overall build state in Cargo.lock
has `Chrono` in versions >= 0.4.40.
Recently `Chrono` added `quarter()` function that clashes with
`Datelike`'s, and requires disambiguation, or build will fail. That also
makes users unable to use it in larger projects.
# What changes are included in this PR?
`arrow-rs/arrow-arith/src/temporal.rs:91`
`get_date_time_part_extract_fn()`
I forced `DatePart::Quarter` to return `Datelike::quarter()`.
With versions < 0.4.40 of `Chrono` it worked since it did not export
this function.
# Are these changes tested?
Full testing suite is not failing.
I added a few tests confirming that quarter() does it job, but those are
not regression tests. Those will only test if the quarter() actually
works.
Build-related tests are difficult to achieve and require extra setup,
moreover are very fragile.
Benchmarks were run, no deviation was found.
# Are there any user-facing changes?
No, users should not be affected.
---------
Co-authored-by: Marco Neumann <marco@crepererum.net>
1 parent c129c7c commit ab9c062
1 file changed
Lines changed: 73 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
97 | 96 | | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
98 | 100 | | |
99 | 101 | | |
100 | 102 | | |
| |||
791 | 793 | | |
792 | 794 | | |
793 | 795 | | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
| 849 | + | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
794 | 866 | | |
795 | 867 | | |
796 | 868 | | |
| |||
0 commit comments