Skip to content

Commit f2f9654

Browse files
committed
Fix comments and method name
1 parent a3de410 commit f2f9654

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

pyiceberg/manifest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -623,8 +623,8 @@ def _inherit_from_manifest(entry: ManifestEntry, manifest: ManifestFile) -> Mani
623623
if entry.snapshot_id is None:
624624
entry.snapshot_id = manifest.added_snapshot_id
625625

626-
# in v1 tables, the data sequence number is not persisted and can be safely defaulted to 0
627-
# in v2 tables, the data sequence number should be inherited iff the entry status is ADDED
626+
# in v1 tables, the sequence number is not persisted and can be safely defaulted to 0
627+
# in v2 tables, the sequence number should be inherited iff the entry status is ADDED
628628
if entry.sequence_number is None and (manifest.sequence_number == 0 or entry.status == ManifestEntryStatus.ADDED):
629629
entry.sequence_number = manifest.sequence_number
630630

pyiceberg/table/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1718,7 +1718,7 @@ def _open_manifest(
17181718
]
17191719

17201720

1721-
def _min_data_file_sequence_number(manifests: List[ManifestFile]) -> int:
1721+
def _min_sequence_number(manifests: List[ManifestFile]) -> int:
17221722
try:
17231723
return min(
17241724
manifest.min_sequence_number or INITIAL_SEQUENCE_NUMBER
@@ -1824,7 +1824,7 @@ def plan_files(self) -> Iterable[FileScanTask]:
18241824
self.table_metadata.schema(), self.row_filter, self.case_sensitive, self.options.get("include_empty_files") == "true"
18251825
).eval
18261826

1827-
min_sequence_number = _min_data_file_sequence_number(manifests)
1827+
min_sequence_number = _min_sequence_number(manifests)
18281828

18291829
data_entries: List[ManifestEntry] = []
18301830
positional_delete_entries = SortedList(key=lambda entry: entry.sequence_number or INITIAL_SEQUENCE_NUMBER)

0 commit comments

Comments
 (0)