Merged
Conversation
siju-samuel
force-pushed
the
relay_yolo_ops
branch
from
89d965d to
63fa16a
Compare
tqchen
requested changes
Oct 21, 2018
python/tvm/relay/op/vision/yolo.py
Outdated
| return _make.yolo_region(data) | ||
|
|
||
|
|
||
| def yolov3_yolo(data): |
Member
There was a problem hiding this comment.
This is quite confusing as it is unclear what specifically the operation this, please write out more details about what is the operation about
python/tvm/relay/op/vision/yolo.py
Outdated
|
|
||
| def yolo_region(data): | ||
| """Yolo region operation used for detection. | ||
|
|
Member
There was a problem hiding this comment.
document the behavior of the operation as it is non-conventional
python/tvm/relay/op/vision/yolo.py
Outdated
|
|
||
| def yolo_reorg(data, stride=1): | ||
| """Yolo reorg operation. This layer reorganize the output based on the stride value. | ||
| Its function is mostly shape transform. |
Member
There was a problem hiding this comment.
document the behavior of the operation
Member
|
given #1974 maybe we want to consider close this pr |
Member
Author
|
region and yolo op can be defenitely removed. But we may need to keep yolo_reorg as realizing this from frontend is difficult. |
siju-samuel
force-pushed
the
relay_yolo_ops
branch
3 times, most recently
from
68d3e10 to
ee7803e
Compare
siju-samuel
force-pushed
the
relay_yolo_ops
branch
2 times, most recently
from
68a637f to
4ed21d3
Compare
merrymercy
added
status: need review
and removed
status: need update
Member
|
What is the status of this PR? |
siju-samuel
force-pushed
the
relay_yolo_ops
branch
from
4ed21d3 to
f82dea1
Compare
siju-samuel
force-pushed
the
relay_yolo_ops
branch
from
f82dea1 to
8a20a5f
Compare
8 tasks
tqchen
approved these changes
Feb 27, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 9, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1799
The following yolo ops are added in relay
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.