Conversation
vinx13
force-pushed
the
feature/roi_align_op
branch
from
19700d9 to
49b95b9
Compare
masahi
reviewed
Feb 18, 2019
masahi
approved these changes
Feb 18, 2019
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API arguments follow MXNet one. Caffe / Pytorch have similar API but they don't use
sample_ratioargument (we can use the default value). TF doesn't have ROI Align (it uses crop_and_resize + pooling instead)
please review @kevinthesun @Laurawly @masahi