Skip to content

[Relay][Text Format] Fix Pretty Printing Annotations#3041

Merged
tqchen merged 2 commits intoapache:masterfrom
joshpoll:annotations
Apr 25, 2019
Merged

[Relay][Text Format] Fix Pretty Printing Annotations#3041
tqchen merged 2 commits intoapache:masterfrom
joshpoll:annotations

Conversation

@joshpoll
Copy link
Contributor

Annotations should be printable on all nodes, but previously they were only printed on Calls and Constants.

cc @jroesch @MarisaKirisame @wweic

@joshpoll
Copy link
Contributor Author

Also eventually we should probably have annotations built in to the Doc data structure to make things like adding color easy to do.

Co-Authored-By: joshpoll <joshpollock1997@gmail.com>
@tqchen tqchen merged commit fed1c08 into apache:master Apr 25, 2019
@tqchen
Copy link
Member

tqchen commented Apr 25, 2019

Thanks, @joshpoll @MarisaKirisame !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants