[HybridScript] Capture constant external python variables#3157
Merged
tqchen merged 1 commit intoapache:masterfrom May 10, 2019
Merged
[HybridScript] Capture constant external python variables#3157tqchen merged 1 commit intoapache:masterfrom
tqchen merged 1 commit intoapache:masterfrom
Conversation
Member
|
@were can you help review this PR? |
kevinthesun
approved these changes
May 9, 2019
Contributor
kevinthesun
left a comment
kevinthesun
left a comment
There was a problem hiding this comment.
LGTM. Will wait for comments from @were before merging.
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture constant python variables (list/tuple/primitive) in HybridScript. We can use them to pass constant shape and attribute information.
cc @were @xqdan @kevinthesun