Skip to content

[Relay] use transform instead of ir_pass for CPS#3485

Merged
vinx13 merged 1 commit intoapache:masterfrom
MarisaKirisame:fix_cps_name
Jul 3, 2019
Merged

[Relay] use transform instead of ir_pass for CPS#3485
vinx13 merged 1 commit intoapache:masterfrom
MarisaKirisame:fix_cps_name

Conversation

@MarisaKirisame
Copy link
Contributor

@vinx13
Copy link
Member

vinx13 commented Jul 3, 2019

Can you also update the old interface:

@MarisaKirisame
Copy link
Contributor Author

@vinx13
un_cps is not a pass - it is only possible on certain kind of function transformed by cps.
I am hesitant to make to_cps a pass, because it change both the program layout (it move control into data, and is very hard to recover) and the type. There is lots of debate on CPS, and I will discuss with @jroesch tomorrow on how to incorporate it into the pass manager.

Can we focus on fixing the obviou thing for this PR?

@vinx13 vinx13 merged commit f3dcab4 into apache:master Jul 3, 2019
@MarisaKirisame MarisaKirisame deleted the fix_cps_name branch July 3, 2019 14:37
wweic pushed a commit to wweic/tvm that referenced this pull request Jul 11, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Jul 11, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants