Quit and clean when TVM is interrupted#3640
Merged
tqchen merged 1 commit intoapache:masterfrom Aug 5, 2019
Merged
Conversation
Member
|
@ghostplant can you please fix the lint error as per ci? |
ghostplant
force-pushed
the
cleanly_quit
branch
4 times, most recently
from
12c1509 to
00c6243
Compare
Contributor
Author
|
@tqchen Hi, can you have a look at the lint problem (not-callable)? |
Member
|
You might want to add a pylint comment to disable the warning, as you have explicitly checked whether the attribute exists |
ghostplant
force-pushed
the
cleanly_quit
branch
from
00c6243 to
054300a
Compare
ghostplant
force-pushed
the
cleanly_quit
branch
from
054300a to
6a560b1
Compare
Contributor
Author
|
@tqchen Passed. |
tqchen
approved these changes
Aug 5, 2019
tqchen
added
status: accepted
and removed
status: need update
Member
|
Thanks @ghostplant |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Aug 9, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is working for #3602 except when user override
sys.excepthook.