Add build_create_shared_func to tvm/contrib/cc.py#3840
Merged
merrymercy merged 1 commit intoapache:masterfrom Aug 29, 2019
Merged
Add build_create_shared_func to tvm/contrib/cc.py#3840merrymercy merged 1 commit intoapache:masterfrom
merrymercy merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@weberlo Can you have a look? |
Member
|
LGTM. @merrymercy Can you take a look? Thanks. |
weberlo
reviewed
Aug 28, 2019
| Parameters | ||
| ---------- | ||
| options : List[str] | ||
| The list of additional options string. |
Contributor
There was a problem hiding this comment.
Is this argument meant to specify a base of compiler options or a default set of compiler options. That meaning, if you pass in options=['a'], and the resulting create_shared_wrapper gets called with options=['b'], is the intent that options == ['a', 'b'] or options == ['b']? Because I think the code currently does the latter.
Contributor
Author
There was a problem hiding this comment.
My intent was to havecreate_shared function builder which allows me to specify returned function default options and compile_cmd.
merrymercy
approved these changes
Aug 29, 2019
Member
|
Thanks @apivovarov! It is merged |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builder functions allows to build
create_sharedfunction with particular defaultoptionsandcompile_cmd.Returned function can be used in
autotune.LocalBuilderExample:
The
tuning_optionabove can be used to tune models for ARMv7 hf devices which does not have g++ installed. Auto-tuning a convolutional network for ARM CPUDiscussion - https://discuss.tvm.ai/t/lib-export-library-cc-param-was-renamed-to-compile-cmd/3644/3