[Debugger] Sorting op-time breakdown for quicker analysis.#4352
Merged
zhiics merged 1 commit intoapache:masterfrom Nov 16, 2019
Merged
[Debugger] Sorting op-time breakdown for quicker analysis.#4352zhiics merged 1 commit intoapache:masterfrom
zhiics merged 1 commit intoapache:masterfrom
Conversation
soiferj
approved these changes
Nov 16, 2019
Contributor
soiferj
left a comment
soiferj
left a comment
There was a problem hiding this comment.
Awesome, thanks lot for the change. LGTM.
Member
|
BTW, if I remember correctly, the correct output is sorted by the occurrence of the ops. If so, should we make this configurable, i.e. passing a |
anijain2305
force-pushed
the
profiler
branch
from
accb4d3 to
9e1929f
Compare
Contributor
Author
|
@zhiics Makes sense. Added a flag. |
anijain2305
force-pushed
the
profiler
branch
from
9e1929f to
59d2c6c
Compare
Member
|
Thanks @anijain2305 @icemelon9 @soiferj |
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Nov 26, 2019
yongwww
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profiler output is not sorted by time currently. So, a developer has to eyeball and find out the expensive ops. This PR sorts and add total time in the log for quicker analysis.
@tqchen @soiferj @yzhliu @icemelon9