Skip to content

MINOR: Fix boolean formatting consistency in protocol definitions #21202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chia7712 merged 1 commit into from
Dec 22, 2025
Merged

MINOR: Fix boolean formatting consistency in protocol definitions #21202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/DescribeShareGroupOffsetsResponse.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"about": "The share-partition start offset." },
{ "name": "LeaderEpoch", "type": "int32", "versions": "0+",
"about": "The leader epoch of the partition." },
{ "name": "Lag", "type": "int64", "versions": "1+", "ignorable": "true", "default": -1,
{ "name": "Lag", "type": "int64", "versions": "1+", "ignorable": true, "default": -1,
"about": "The share-partition lag." },
{ "name": "ErrorCode", "type": "int16", "versions": "0+",
"about": "The partition-level error code, or 0 if there was no error." },
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/ReadShareGroupStateSummaryResponse.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"about": "The leader epoch of the share-partition." },
{ "name": "StartOffset", "type": "int64", "versions": "0+",
"about": "The share-partition start offset." },
{ "name": "DeliveryCompleteCount", "type": "int32", "versions": "1+", "ignorable": "true", "default": "-1",
{ "name": "DeliveryCompleteCount", "type": "int32", "versions": "1+", "ignorable": true, "default": "-1",
"about": "The number of offsets greater than or equal to share-partition start offset for which delivery has been completed." }
]}
]}
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/WriteShareGroupStateRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"about": "The leader epoch of the share-partition." },
{ "name": "StartOffset", "type": "int64", "versions": "0+",
"about": "The share-partition start offset, or -1 if the start offset is not being written." },
{ "name": "DeliveryCompleteCount", "type": "int32", "versions": "1+", "ignorable": "true", "default": "-1",
{ "name": "DeliveryCompleteCount", "type": "int32", "versions": "1+", "ignorable": true, "default": "-1",
"about": "The number of offsets greater than or equal to share-partition start offset for which delivery has been completed." },
{ "name": "StateBatches", "type": "[]StateBatch", "versions": "0+",
"about": "The state batches for the share-partition.", "fields": [
Expand Down