chore(binding/lua): fix code

Signed-off-by: owl <ouyangjun1999@gmail.com>

Author: oowl

.github/workflows/bindings_lua.yml

@@ -46,12 +46,11 @@ jobs:
       - name: Setup lua toolchain
         run: |
           sudo apt-get update
-          sudo apt-get install -y lua-busted
+          sudo apt-get install -y lua-busted luarocks liblua5.2-dev
       - name: Setup Rust toolchain
         uses: ./.github/actions/setup
       - name: Build & Test
         working-directory: "bindings/lua"
         run: |
-          cargo build
-          mv ../../target/debug/libopendal_lua.so opendal.so
+          sudo "PATH=$PATH" luarocks make
           busted test/opendal_test.lua

Cargo.lock

@@ -31,13 +31,18 @@ rust-version.workspace = true
 
 
 [features]
-default = ["mlua/lua54"]
-lua54 = ["mlua", "mlua/lua54"]
-lua53 = ["mlua", "mlua/lua53"]
+default = ["mlua/lua52"]
 lua52 = ["mlua", "mlua/lua52"]
-lua51 = ["mlua", "mlua/lua51"]
-luajit = ["mlua", "mlua/luajit"]
-vendored = ["mlua", "mlua/vendored"]
+
+# todo: fix mlua multi-version in `cargo build --all-features` error
+# https://github.com/apache/incubator-opendal/pull/2558#issuecomment-1613570958
+
+#lua54 = ["mlua", "mlua/lua54"]
+#lua53 = ["mlua", "mlua/lua53"]
+#lua52 = ["mlua", "mlua/lua52"]
+#lua51 = ["mlua", "mlua/lua51"]
+#luajit = ["mlua", "mlua/luajit"]
+#vendored = ["mlua", "mlua/vendored"]
 
 # for disable default features
 [dependencies.mlua]
@@ -49,7 +54,6 @@ optional = true
 
 [lib]
 crate-type = ["cdylib"]
-name = "lopendal"
 
 [dependencies]
 opendal.workspace = true

bindings/lua/Cargo.toml

@@ -5,7 +5,7 @@
 ## Example
 
 ```lua
-local opendal = require("lopendal")
+local opendal = require("opendal")
 
 local op, err = opendal.operator.new("fs",{root="/tmp"})
 if err ~= nil then

bindings/lua/README.md

@@ -19,7 +19,7 @@
 
 ]]
 
-local opendal = require("lopendal")
+local opendal = require("opendal")
 
 local op, err = opendal.operator.new("fs",{root="/tmp"})
 if err ~= nil then

bindings/lua/example/fs.lua

@@ -1,4 +1,4 @@
-package = "lopendal"
+package = "opendal"
 version = "0.1.0-1"
 
 source = {
@@ -22,6 +22,7 @@ dependencies = {
 build = {
     type = "rust-mlua",
     modules = {
-        "lopendal"
+        ["opendal"] = "opendal_lua",
     },
+    target_path = "../../target",
 }

bindings/lua/lopendal-0.1.0-1.rockspec bindings/lua/opendal-0.1.0-1.rockspecbindings/lua/lopendal-0.1.0-1.rockspec renamed to bindings/lua/opendal-0.1.0-1.rockspec

@@ -194,7 +194,7 @@ fn operator_stat<'a>(
 }
 
 #[mlua::lua_module]
-fn lopendal(lua: &Lua) -> LuaResult<LuaTable> {
+fn opendal(lua: &Lua) -> LuaResult<LuaTable> {
     let exports = lua.create_table()?;
     let operator = lua.create_table()?;
     operator.set("new", lua.create_function(operator_new)?)?;

bindings/lua/src/lib.rs

@@ -19,10 +19,11 @@
 
 ]]
 
+local opendal = require("opendal")
+
 describe("opendal unit test", function()
   describe("opendal fs schema", function()
     it("operator function in fs schema", function()
-      local opendal = require("opendal")
       local op, err = opendal.operator.new("fs",{root="/tmp"})
       assert.is_nil(err)
       assert.is_nil(op:write("test.txt","hello world"))
@@ -34,7 +35,6 @@ describe("opendal unit test", function()
       assert.equal(op:is_exist("test.txt"), false)
     end)
     it("meta function in fs schema", function()
-      local opendal = require("opendal")
       local op, err = opendal.operator.new("fs",{root="/tmp"})
       assert.is_nil(err)
       assert.is_nil(op:write("test.txt","hello world"))
@@ -53,7 +53,6 @@ describe("opendal unit test", function()
   end)
   describe("opendal memory schema", function()
     it("operator function in memory schema", function()
-      local opendal = require("opendal")
       local op, err = opendal.operator.new("memory",{root="/tmp"})
       assert.is_nil(err)
       assert.is_nil(op:write("test.txt","hello world"))
@@ -65,7 +64,6 @@ describe("opendal unit test", function()
       assert.equal(op:is_exist("test.txt"), false)
     end)
     it("meta function in memory schema", function()
-      local opendal = require("opendal")
       local op, err = opendal.operator.new("memory",{root="/tmp"})
       assert.is_nil(err)
       assert.is_nil(op:write("test.txt","hello world"))