Merged
Conversation
jvz
reviewed
Jan 26, 2021
jvz
reviewed
Jan 26, 2021
jvz
previously approved these changes
Jan 26, 2021
Member
jvz
left a comment
jvz
left a comment
There was a problem hiding this comment.
Looks decent, though I'm not too good with Rust, so I can only offer some C style advice ;)
jvz
previously approved these changes
Jan 26, 2021
Member
jvz
left a comment
jvz
left a comment
There was a problem hiding this comment.
Had I scrolled further, I would've noticed the bindings.rs file it was generated from!
jvz
approved these changes
Jan 26, 2021
Member
Author
|
Thanks for the review! Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce C client SDK. There are two types of C APIs:
*_serializedAPIs accept JSON serialized string requests and responses. These APIs is for other high level programming languages.teaclave_user_login.An echo example using C client SDK is also implemented. Client APIs will be documented later when all useful languages are properly implemented.
CI passed: http://ci.mesalock-linux.org/mssun/incubator-mesatee/1131