Skip to content

Move execution context into a seperate crate#598

Merged
mssun merged 1 commit intoapache:masterfrom
qinkunbao:context-patch
Jan 8, 2022
Merged

Move execution context into a seperate crate#598
mssun merged 1 commit intoapache:masterfrom
qinkunbao:context-patch

Conversation

@qinkunbao
Copy link
Member

Description

Teaclave execution crate exports several APIs such as reset_thread_context, reset_thread_context, and c_open_input. These APIs are used by statically linked non-rust executors like mesapy and wamr to read/write files from the execution service.

However, the above APIs are not accessible to the built-in functions because build-in functions are in a different crate teaclave_function . teaclave_function is the dependency of the crate teaclave execution.

This PR moves these APIs into a separate crate so build-in functions can invoke these APIs directly.

How has this been tested?

CI test.

Checklist

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • Ensure the tests pass (see CI results).
  • Make sure your code lints/format.

@mssun mssun self-requested a review January 8, 2022 08:40
Copy link
Member

@mssun mssun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mssun mssun merged commit 7305cf3 into apache:master Jan 8, 2022
@qinkunbao qinkunbao deleted the context-patch branch January 9, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants