fix: upgrade fast-xml-parser to 4.5.4 to resolve critical CVE-2026-25896#41595
fix: upgrade fast-xml-parser to 4.5.4 to resolve critical CVE-2026-25896#41595
Conversation
Upgrades fast-xml-parser from 4.4.1 to 4.5.4 via Yarn resolutions to fix a critical entity encoding bypass via regex injection in DOCTYPE entity names (CVSS 9.3). Also resolves high-severity DoS alert #510. Changes: - Add fast-xml-parser 4.5.4 resolution in package.json - Update recommended library CDN URL to jsdelivr 4.5.4 - Update Cypress E2E test CDN URL to 4.5.4 - Regenerate yarn.lock with patched version
WalkthroughA straightforward version upgrade of the fast-xml-parser library from 4.2.7/4.3.2 to 4.5.4, including updates to test fixtures, package.json dependencies, and the recommended libraries configuration. CDN URL changed from CDNJS to JSDelivr. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Fixes a critical security vulnerability (CVE-2026-25896, CVSS 9.3) in
fast-xml-parser— an entity encoding bypass via regex injection in DOCTYPE entity names that allows XSS and injection attacks when parsed XML output is rendered.This also resolves a high-severity DoS vulnerability (Dependabot alert https://github.com/appsmithorg/appsmith/security/dependabot/510) — DoS through entity expansion in DOCTYPE with no expansion limit.
Vulnerable range:
>= 4.1.3, < 4.5.4Fix version:
4.5.4Changes
package.json: Added"fast-xml-parser": "4.5.4"to Yarnresolutionsto override the transitive dependency (via@smithy/core→@aws-sdk/client-s3)recommendedLibraries.ts: Updated CDN URL from cdnjs4.3.2to jsdelivr4.5.4(cdnjs does not yet host 4.5.4)Library_spec.ts: Updated Cypress E2E test CDN URLs from4.2.7to4.5.4yarn.lock: Regenerated withfast-xml-parser@4.5.4resolutionNote on v3.17.5 (legacy xmlParser)
The legacy
xmlParserv3.17.5 referenced inApplicationConstants.javaand test fixtures is not affected by this CVE (vulnerable range starts at 4.1.3). It is already documented as deprecated for backward compatibility.Fixes Dependabot alert https://github.com/appsmithorg/appsmith/security/dependabot/511 (critical)
Fixes Dependabot alert https://github.com/appsmithorg/appsmith/security/dependabot/510 (high)
Fixes https://linear.app/appsmith/issue/APP-14993/fix-upgrade-fast-xml-parser-to-454-to-resolve-critical-cve-2026-25896
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Important
🟣 🟣 🟣 Your tests are running.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/22780449068
Commit: 707048a
Workflow:
PR Automation test suiteTags:
@tag.AllSpec: ``
Fri, 06 Mar 2026 20:20:26 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit