feat: add validation for platform

Author: aslamcodes

internal/validator/config_validator.go

@@ -0,0 +1,32 @@
+package validator
+
+import (
+	"errors"
+	"slices"
+
+	"github.com/aslamcodes/powerappstream-builder/internal/config"
+)
+
+var (
+	ErrPlatformMissing = errors.New("config file does not contain platform specification")
+	ErrInvalidPlatform = errors.New("Platform not supported")
+)
+
+
+func ValidateConfig(c *config.Config) error {
+	if c.Platform == "" {
+		return ErrPlatformMissing
+	}
+
+	supportedPlatforms := make([]string, len(ExecPlatformMap))
+
+	for k := range ExecPlatformMap {
+		supportedPlatforms = append(supportedPlatforms, k)
+	}
+
+	if !slices.Contains(supportedPlatforms, c.Platform) {
+		return ErrInvalidPlatform
+	}
+
+	return nil
+}

internal/validator/config_validator_test.go

@@ -0,0 +1,82 @@
+package validator_test
+
+import (
+	"errors"
+	"fmt"
+	"os"
+	"testing"
+
+	"github.com/aslamcodes/powerappstream-builder/internal/backend"
+	"github.com/aslamcodes/powerappstream-builder/internal/validator"
+)
+
+func TestValidateConfig(t *testing.T) {
+	testCases := []struct {
+		desc        string
+		fileContent string
+		expected    error
+	}{
+		{
+			desc: "valid config unix",
+			fileContent: `platform: "unix"
+installers:
+  - executable: "bash"
+    installScript: |
+      echo "Hello World"`,
+			expected: nil,
+		},
+		{
+			desc: "valid config windows",
+			fileContent: `platform: "windows"
+installers:
+  - executable: "bash"
+    installScript: |
+      echo "Hello World"`,
+			expected: nil,
+		},
+		{
+			desc: "invalid config",
+			fileContent: `platform: "non_existent"
+installers:
+  - executable: "bash"
+    installScript: |
+      echo "Hello World"`,
+			expected: validator.ErrInvalidPlatform,
+		},
+	}
+	for _, tC := range testCases {
+		t.Run(tC.desc, func(t *testing.T) {
+			file, err := os.CreateTemp("../../testdata", fmt.Sprintf("test_%s_", tC.desc))
+
+			if err != nil {
+				t.Errorf("unable to create temp file: %v", err)
+			}
+
+			file.WriteString(tC.fileContent)
+
+			lb := backend.LocalBackend{
+				Location: file.Name(),
+			}
+
+			configData, err := lb.GetConfig()
+
+			if err != nil {
+				t.Errorf("unable to fetch config data: %v", err)
+			}
+
+			err = validator.ValidateConfig(configData)
+
+			if !errors.Is(err, tC.expected) {
+				t.Errorf("expected %v, got %v", tC.expected, err)
+			}
+
+			t.Cleanup(func() {
+				os.Remove(file.Name())
+			})
+
+			t.Cleanup(func() {
+				file.Close()
+			})
+		})
+	}
+}

internal/validator/installer_validator.go

@@ -10,18 +10,12 @@ import (
 
 var (
 	ErrInvalidExecutableForPlatform = errors.New("Invalid executable for given platform")
-	ErrInvalidPlatform              = errors.New("Platform not supported")
 )
 
 func InstallerValidator(configData *config.Config) error {
-	execPlatformMap := map[string][]string{
-		"windows": {"powershell"},
-		"unix":    {"bash"},
-	}
-
 	platform := configData.Platform
 
-	platformExecs, exists := execPlatformMap[platform]
+	platformExecs, exists := ExecPlatformMap[platform]
 
 	if !exists {
 		return ErrInvalidPlatform

internal/validator/validator.go

@@ -0,0 +1,6 @@
+package validator
+
+var ExecPlatformMap = map[string][]string{
+	"windows": {"powershell"},
+	"unix":    {"bash"},
+}