fix(services): harden tracker rule updates, reannounce debounce, and instance selection

Author: s0up4200

internal/api/handlers/tracker_rules.go

@@ -7,6 +7,7 @@ import (
 	"database/sql"
 	"encoding/json"
 	"errors"
+	"fmt"
 	"net/http"
 	"strconv"
 	"strings"
@@ -150,6 +151,11 @@ func (h *TrackerRuleHandler) Update(w http.ResponseWriter, r *http.Request) {
 
 	rule, err := h.store.Update(r.Context(), payload.toModel(instanceID, ruleID))
 	if err != nil {
+		if errors.Is(err, sql.ErrNoRows) {
+			log.Error().Err(err).Int("instanceID", instanceID).Int("ruleID", ruleID).Msg("tracker rule not found for update")
+			RespondError(w, http.StatusNotFound, "Tracker rule not found")
+			return
+		}
 		log.Error().Err(err).Int("instanceID", instanceID).Int("ruleID", ruleID).Msg("failed to update tracker rule")
 		RespondError(w, http.StatusInternalServerError, "Failed to update tracker rule")
 		return
@@ -229,7 +235,7 @@ func parseInstanceID(w http.ResponseWriter, r *http.Request) (int, error) {
 	instanceID, err := strconv.Atoi(instanceIDStr)
 	if err != nil || instanceID <= 0 {
 		RespondError(w, http.StatusBadRequest, "Invalid instance ID")
-		return 0, err
+		return 0, fmt.Errorf("invalid instance ID: %s", instanceIDStr)
 	}
 	return instanceID, nil
 }

internal/services/reannounce/service.go

@@ -341,9 +341,6 @@ func (s *Service) enqueue(instanceID int, hash string, torrentName string, track
 	// Determine debounce window: aggressive uses retry interval; non-aggressive uses global cooldown.
 	debounceWindow := s.cfg.DebounceWindow
 	if isAggressive {
-		if settings == nil {
-			settings = models.DefaultInstanceReannounceSettings(instanceID)
-		}
 		if interval := time.Duration(settings.ReannounceIntervalSeconds) * time.Second; interval > 0 {
 			debounceWindow = interval
 		}

internal/services/trackerrules/service.go

@@ -254,9 +254,6 @@ func limitHashBatch(hashes []string, max int) [][]string {
 
 func selectRule(torrent qbt.Torrent, rules []*models.TrackerRule, sm *qbittorrent.SyncManager) *models.TrackerRule {
 	trackerDomains := collectTrackerDomains(torrent, sm)
-	if len(trackerDomains) == 0 {
-		return nil
-	}
 
 	for _, rule := range rules {
 		if !matchesTracker(rule.TrackerPattern, trackerDomains) {

web/src/pages/Services.tsx

@@ -27,14 +27,15 @@ export function Services() {
 
   const selectedInstanceId = useMemo(() => {
     const fromSearch = search.instanceId ? Number(search.instanceId) : undefined
-    if (fromSearch && activeInstances.some((inst) => inst.id === fromSearch)) {
+    const allInstances = instances ?? []
+    if (fromSearch && allInstances.some((inst) => inst.id === fromSearch)) {
       return fromSearch
     }
-    if (activeInstances.length > 0) {
-      return activeInstances[0]?.id
+    if (allInstances.length > 0) {
+      return allInstances[0]?.id
     }
     return undefined
-  }, [activeInstances, search.instanceId])
+  }, [instances, search.instanceId])
 
   const handleInstanceChange = (value: string) => {
     navigate({
@@ -74,7 +75,7 @@ export function Services() {
                 </div>
               </SelectTrigger>
               <SelectContent>
-                {instances.map((instance) => (
+                {(instances ?? []).map((instance) => (
                   <SelectItem key={instance.id} value={String(instance.id)}>
                     <div className="flex items-center max-w-40 gap-2">
                       <span className="truncate">{instance.name}</span>