refactor(tracker-rules): remove default rule feature

Author: s0up4200

README.md

@@ -36,7 +36,7 @@ A fast, modern web interface for qBittorrent. Supports managing multiple qBittor
 - **OIDC Single Sign-On**: Authenticate through your OpenID Connect provider
 - **External Programs**: Launch custom scripts from the torrent context menu ([guide](internal/api/handlers/EXTERNAL_PROGRAMS.md))
 - **Tracker Reannounce**: Automatically fix stalled torrents when qBittorrent doesn't retry fast enough ([info](internal/services/reannounce/REANNOUNCE.md))
-- **Tracker Rules**: Apply per-tracker speed limits, ratio caps, and seeding time limits automatically
+- **Tracker Rules**: Apply per-tracker speed limits, ratio caps, and seeding time limits automatically ([info](internal/services/trackerrules/TRACKER_RULES.md))
 
 
 

internal/api/handlers/tracker_rules.go

@@ -41,7 +41,6 @@ type TrackerRulePayload struct {
 	DownloadLimitKiB        *int64   `json:"downloadLimitKiB"`
 	RatioLimit              *float64 `json:"ratioLimit"`
 	SeedingTimeLimitMinutes *int64   `json:"seedingTimeLimitMinutes"`
-	IsDefault               bool     `json:"isDefault"`
 	Enabled                 *bool    `json:"enabled"`
 	SortOrder               *int     `json:"sortOrder"`
 }
@@ -65,7 +64,6 @@ func (p *TrackerRulePayload) toModel(instanceID int, id int) *models.TrackerRule
 		DownloadLimitKiB:        p.DownloadLimitKiB,
 		RatioLimit:              p.RatioLimit,
 		SeedingTimeLimitMinutes: p.SeedingTimeLimitMinutes,
-		IsDefault:               p.IsDefault,
 		Enabled:                 true,
 	}
 	if p.Enabled != nil {
@@ -110,8 +108,8 @@ func (h *TrackerRuleHandler) Create(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	if len(normalizeTrackerDomains(payload.TrackerDomains)) == 0 && strings.TrimSpace(payload.TrackerPattern) == "" && !payload.IsDefault {
-		RespondError(w, http.StatusBadRequest, "Select at least one tracker (or mark as default)")
+	if len(normalizeTrackerDomains(payload.TrackerDomains)) == 0 && strings.TrimSpace(payload.TrackerPattern) == "" {
+		RespondError(w, http.StatusBadRequest, "Select at least one tracker")
 		return
 	}
 
@@ -149,8 +147,8 @@ func (h *TrackerRuleHandler) Update(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	if len(normalizeTrackerDomains(payload.TrackerDomains)) == 0 && strings.TrimSpace(payload.TrackerPattern) == "" && !payload.IsDefault {
-		RespondError(w, http.StatusBadRequest, "Select at least one tracker (or mark as default)")
+	if len(normalizeTrackerDomains(payload.TrackerDomains)) == 0 && strings.TrimSpace(payload.TrackerPattern) == "" {
+		RespondError(w, http.StatusBadRequest, "Select at least one tracker")
 		return
 	}
 

internal/database/migrations/019_add_tracker_rules.sql

@@ -12,15 +12,13 @@ CREATE TABLE IF NOT EXISTS tracker_rules (
     download_limit_kib INTEGER,
     ratio_limit REAL,
     seeding_time_limit_minutes INTEGER,
-    is_default INTEGER NOT NULL DEFAULT 0,
     enabled INTEGER NOT NULL DEFAULT 1,
     sort_order INTEGER NOT NULL DEFAULT 0,
     created_at DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
     updated_at DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP
 );
 
 CREATE INDEX IF NOT EXISTS idx_tracker_rules_instance ON tracker_rules(instance_id, sort_order, id);
-CREATE INDEX IF NOT EXISTS idx_tracker_rules_default ON tracker_rules(instance_id, is_default);
 
 CREATE TRIGGER IF NOT EXISTS trg_tracker_rules_updated
 AFTER UPDATE ON tracker_rules

internal/models/tracker_rule.go

@@ -25,7 +25,6 @@ type TrackerRule struct {
 	DownloadLimitKiB        *int64    `json:"downloadLimitKiB,omitempty"`
 	RatioLimit              *float64  `json:"ratioLimit,omitempty"`
 	SeedingTimeLimitMinutes *int64    `json:"seedingTimeLimitMinutes,omitempty"`
-	IsDefault               bool      `json:"isDefault"`
 	Enabled                 bool      `json:"enabled"`
 	SortOrder               int       `json:"sortOrder"`
 	CreatedAt               time.Time `json:"createdAt"`
@@ -83,7 +82,7 @@ func normalizeTrackerPattern(pattern string, domains []string) string {
 func (s *TrackerRuleStore) ListByInstance(ctx context.Context, instanceID int) ([]*TrackerRule, error) {
 	rows, err := s.db.QueryContext(ctx, `
 		SELECT id, instance_id, name, tracker_pattern, category, tag, upload_limit_kib, download_limit_kib,
-		       ratio_limit, seeding_time_limit_minutes, is_default, enabled, sort_order, created_at, updated_at
+		       ratio_limit, seeding_time_limit_minutes, enabled, sort_order, created_at, updated_at
 		FROM tracker_rules
 		WHERE instance_id = ?
 		ORDER BY sort_order ASC, id ASC
@@ -112,7 +111,6 @@ func (s *TrackerRuleStore) ListByInstance(ctx context.Context, instanceID int) (
 			&download,
 			&ratio,
 			&seeding,
-			&rule.IsDefault,
 			&rule.Enabled,
 			&rule.SortOrder,
 			&rule.CreatedAt,
@@ -151,7 +149,7 @@ func (s *TrackerRuleStore) ListByInstance(ctx context.Context, instanceID int) (
 func (s *TrackerRuleStore) Get(ctx context.Context, id int) (*TrackerRule, error) {
 	row := s.db.QueryRowContext(ctx, `
 		SELECT id, instance_id, name, tracker_pattern, category, tag, upload_limit_kib, download_limit_kib,
-		       ratio_limit, seeding_time_limit_minutes, is_default, enabled, sort_order, created_at, updated_at
+		       ratio_limit, seeding_time_limit_minutes, enabled, sort_order, created_at, updated_at
 		FROM tracker_rules
 		WHERE id = ?
 	`, id)
@@ -173,7 +171,6 @@ func (s *TrackerRuleStore) Get(ctx context.Context, id int) (*TrackerRule, error
 		&download,
 		&ratio,
 		&seeding,
-		&rule.IsDefault,
 		&rule.Enabled,
 		&rule.SortOrder,
 		&rule.CreatedAt,
@@ -231,20 +228,14 @@ func (s *TrackerRuleStore) Create(ctx context.Context, rule *TrackerRule) (*Trac
 		sortOrder = next
 	}
 
-	if rule.IsDefault {
-		if err := s.clearDefault(ctx, rule.InstanceID); err != nil {
-			return nil, err
-		}
-	}
-
 	res, err := s.db.ExecContext(ctx, `
 		INSERT INTO tracker_rules
-			(instance_id, name, tracker_pattern, category, tag, upload_limit_kib, download_limit_kib, ratio_limit, seeding_time_limit_minutes, is_default, enabled, sort_order)
+			(instance_id, name, tracker_pattern, category, tag, upload_limit_kib, download_limit_kib, ratio_limit, seeding_time_limit_minutes, enabled, sort_order)
 		VALUES
-			(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
+			(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
 	`, rule.InstanceID, rule.Name, rule.TrackerPattern, nullableString(rule.Category), nullableString(rule.Tag),
 		nullableInt64(rule.UploadLimitKiB), nullableInt64(rule.DownloadLimitKiB), nullableFloat64(rule.RatioLimit),
-		nullableInt64(rule.SeedingTimeLimitMinutes), boolToInt(rule.IsDefault), boolToInt(rule.Enabled), sortOrder)
+		nullableInt64(rule.SeedingTimeLimitMinutes), boolToInt(rule.Enabled), sortOrder)
 	if err != nil {
 		return nil, err
 	}
@@ -262,32 +253,16 @@ func (s *TrackerRuleStore) Update(ctx context.Context, rule *TrackerRule) (*Trac
 		return nil, errors.New("rule is nil")
 	}
 
-	tx, err := s.db.BeginTx(ctx, nil)
-	if err != nil {
-		return nil, err
-	}
-	defer tx.Rollback()
-
 	rule.TrackerPattern = normalizeTrackerPattern(rule.TrackerPattern, rule.TrackerDomains)
 
-	if rule.IsDefault {
-		if err := s.clearDefaultTx(ctx, tx, rule.InstanceID); err != nil {
-			return nil, err
-		}
-	}
-
-	if _, err := tx.ExecContext(ctx, `
+	if _, err := s.db.ExecContext(ctx, `
 		UPDATE tracker_rules
 		SET name = ?, tracker_pattern = ?, category = ?, tag = ?, upload_limit_kib = ?, download_limit_kib = ?,
-		    ratio_limit = ?, seeding_time_limit_minutes = ?, is_default = ?, enabled = ?, sort_order = ?
+		    ratio_limit = ?, seeding_time_limit_minutes = ?, enabled = ?, sort_order = ?
 		WHERE id = ? AND instance_id = ?
 	`, rule.Name, rule.TrackerPattern, nullableString(rule.Category), nullableString(rule.Tag),
 		nullableInt64(rule.UploadLimitKiB), nullableInt64(rule.DownloadLimitKiB), nullableFloat64(rule.RatioLimit),
-		nullableInt64(rule.SeedingTimeLimitMinutes), boolToInt(rule.IsDefault), boolToInt(rule.Enabled), rule.SortOrder, rule.ID, rule.InstanceID); err != nil {
-		return nil, err
-	}
-
-	if err := tx.Commit(); err != nil {
+		nullableInt64(rule.SeedingTimeLimitMinutes), boolToInt(rule.Enabled), rule.SortOrder, rule.ID, rule.InstanceID); err != nil {
 		return nil, err
 	}
 
@@ -321,19 +296,6 @@ func (s *TrackerRuleStore) Reorder(ctx context.Context, instanceID int, orderedI
 	return tx.Commit()
 }
 
-func (s *TrackerRuleStore) clearDefault(ctx context.Context, instanceID int) error {
-	_, err := s.db.ExecContext(ctx, `UPDATE tracker_rules SET is_default = 0 WHERE instance_id = ?`, instanceID)
-	return err
-}
-
-func (s *TrackerRuleStore) clearDefaultTx(ctx context.Context, tx dbinterface.TxQuerier, instanceID int) error {
-	if tx == nil {
-		return errors.New("transaction is nil")
-	}
-	_, err := tx.ExecContext(ctx, `UPDATE tracker_rules SET is_default = 0 WHERE instance_id = ?`, instanceID)
-	return err
-}
-
 func nullableString(value *string) any {
 	if value == nil {
 		return nil

internal/services/trackerrules/TRACKER_RULES.md

@@ -0,0 +1,74 @@
+# Tracker Rules
+
+Tracker Rules automatically apply speed limits, ratio caps, and seeding time limits to torrents based on their tracker domain.
+
+## How Rules Work
+
+Rules are evaluated in **sort order** (first match wins). Each rule can match torrents by:
+
+1. **Tracker domain** (required) - The tracker's hostname
+2. **Category** (optional) - The torrent's category in qBittorrent
+3. **Tag** (optional) - A tag assigned to the torrent
+
+Torrents that don't match any rule are left untouched. Disabled rules are skipped entirely.
+
+## Settings Applied
+
+When a rule matches a torrent, it can apply any combination of:
+
+| Setting | Description |
+|---------|-------------|
+| Upload limit | Maximum upload speed (KiB/s) |
+| Download limit | Maximum download speed (KiB/s) |
+| Ratio limit | Stop seeding when this ratio is reached |
+| Seeding time limit | Stop seeding after this many minutes |
+
+## When Rules Run
+
+Rules are applied in two ways:
+
+- **Automatically** - A background service scans all torrents every 20 seconds
+- **Manually** - Click "Apply Now" in the UI to trigger immediately
+
+To avoid hammering qBittorrent, the same torrent won't be re-processed within 2 minutes (debouncing).
+
+## Matching Logic
+
+### Domain Patterns
+
+Tracker domains can be matched in three ways:
+
+| Pattern | Example | Matches |
+|---------|---------|---------|
+| Exact | `tracker.example.com` | Only `tracker.example.com` |
+| Glob | `*.example.com` | `sub.example.com`, `tracker.example.com` |
+| Suffix | `.example.com` | `example.com`, `sub.example.com` |
+
+### Multiple Patterns
+
+Separate multiple patterns with commas, semicolons, or pipes:
+
+```
+tracker1.com,tracker2.org|tracker3.net
+```
+
+All matching is **case-insensitive**.
+
+## Important Behavior
+
+### Rules Only Set Values
+
+Rules apply settings to torrents - they **do not revert** settings when the rule is disabled or deleted. If you disable a rule that set upload limit to 1000 KiB/s, affected torrents keep that limit until you manually change it or another rule applies a different value.
+
+### Efficient Updates
+
+The service only sends API calls to qBittorrent when the torrent's current setting differs from what the rule specifies. If a torrent already has the correct limits, it's skipped.
+
+### Existing vs New Torrents
+
+- **Existing torrents** - Processed on the next scan cycle (within 20 seconds)
+- **New torrents** - Picked up automatically within 20 seconds of appearing in qBittorrent
+
+### Batched API Calls
+
+To handle large torrent collections efficiently, torrents are grouped by setting value and sent to qBittorrent in batches of up to 150 hashes per API call.

internal/services/trackerrules/service.go

@@ -256,6 +256,9 @@ func selectRule(torrent qbt.Torrent, rules []*models.TrackerRule, sm *qbittorren
 	trackerDomains := collectTrackerDomains(torrent, sm)
 
 	for _, rule := range rules {
+		if !rule.Enabled {
+			continue
+		}
 		if !matchesTracker(rule.TrackerPattern, trackerDomains) {
 			continue
 		}
@@ -272,12 +275,6 @@ func selectRule(torrent qbt.Torrent, rules []*models.TrackerRule, sm *qbittorren
 		return rule
 	}
 
-	for _, rule := range rules {
-		if rule.IsDefault {
-			return rule
-		}
-	}
-
 	return nil
 }
 

web/src/components/instances/preferences/TrackerRulesPanel.tsx

@@ -44,7 +44,6 @@ const emptyFormState: FormState = {
   downloadLimitKiB: undefined,
   ratioLimit: undefined,
   seedingTimeLimitMinutes: undefined,
-  isDefault: false,
   enabled: true,
 }
 
@@ -148,7 +147,6 @@ export function TrackerRulesPanel({ instanceId }: TrackerRulesPanelProps) {
       downloadLimitKiB: rule.downloadLimitKiB,
       ratioLimit: rule.ratioLimit,
       seedingTimeLimitMinutes: rule.seedingTimeLimitMinutes,
-      isDefault: rule.isDefault,
       enabled: rule.enabled,
       sortOrder: rule.sortOrder,
     })
@@ -175,8 +173,8 @@ export function TrackerRulesPanel({ instanceId }: TrackerRulesPanelProps) {
       return
     }
     const selectedTrackers = formState.trackerDomains.filter(Boolean)
-    if (!formState.isDefault && selectedTrackers.length === 0) {
-      toast.error("Select at least one tracker or mark as default")
+    if (selectedTrackers.length === 0) {
+      toast.error("Select at least one tracker")
       return
     }
     const payload: FormState = {
@@ -278,11 +276,6 @@ export function TrackerRulesPanel({ instanceId }: TrackerRulesPanelProps) {
                             className="shrink-0"
                           />
                           <span className={cn("font-medium truncate", !rule.enabled && "text-muted-foreground")}>{rule.name}</span>
-                          {rule.isDefault && (
-                            <Badge variant="secondary" className="shrink-0">
-                              Default
-                            </Badge>
-                          )}
                           {!rule.enabled && (
                             <Badge variant="outline" className="shrink-0 text-muted-foreground">
                               Disabled
@@ -416,7 +409,7 @@ export function TrackerRulesPanel({ instanceId }: TrackerRulesPanelProps) {
               </div>
             </div>
 
-            <div className="grid gap-4 sm:grid-cols-2">
+            <div className="grid gap-4 sm:grid-cols-1">
               <div className="flex items-center justify-between rounded-lg border p-3">
                 <div>
                   <Label htmlFor="rule-enabled">Enabled</Label>
@@ -428,17 +421,6 @@ export function TrackerRulesPanel({ instanceId }: TrackerRulesPanelProps) {
                   onCheckedChange={(checked) => setFormState(prev => ({ ...prev, enabled: checked }))}
                 />
               </div>
-              <div className="flex items-center justify-between rounded-lg border p-3">
-                <div>
-                  <Label htmlFor="rule-default">Default rule</Label>
-                  <p className="text-sm text-muted-foreground">Applies when no other rule matches.</p>
-                </div>
-                <Switch
-                  id="rule-default"
-                  checked={formState.isDefault ?? false}
-                  onCheckedChange={(checked) => setFormState(prev => ({ ...prev, isDefault: checked }))}
-                />
-              </div>
             </div>
 
             <DialogFooter>

web/src/types/index.ts

@@ -97,7 +97,6 @@ export interface TrackerRule {
   downloadLimitKiB?: number
   ratioLimit?: number
   seedingTimeLimitMinutes?: number
-  isDefault: boolean
   enabled: boolean
   sortOrder: number
   createdAt?: string
@@ -114,7 +113,6 @@ export interface TrackerRuleInput {
   downloadLimitKiB?: number
   ratioLimit?: number
   seedingTimeLimitMinutes?: number
-  isDefault?: boolean
   enabled?: boolean
   sortOrder?: number
 }