Skip to content

chore(events): reference interfaces#36535

Merged
mergify[bot] merged 8 commits intomainfrom
huijbers/reference-interfaces-events
Jan 12, 2026
Merged

chore(events): reference interfaces#36535
mergify[bot] merged 8 commits intomainfrom
huijbers/reference-interfaces-events

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Dec 31, 2025

Reference interfaces for L2s, like #35271.

"chore" because I plan to make a lot of these PRs and they're not adding value to the changelog.

(Generated with AI)

BREAKING CHANGE: ApiDestination.fromApiDestinationAttributes() now returns an IApiDestination. It used to return an ApiDestination but this was a mistake, referencing methods always return a type by interface, not by class.EventDestination.bus used to be an IEventBus but is now an IEventBusRef; it needs to be type tested to assert it is actually an IEventBus if that is necessary.

Reference interfaces for L2s, like #35271.

"chore" because I plan to make a lot of these PRs and they're not adding value to the changelog.

(Generated with AI)
@rix0rrr rix0rrr requested a review from a team December 31, 2025 14:59
@aws-cdk-automation aws-cdk-automation requested a review from a team December 31, 2025 14:59
@github-actions github-actions Bot added the p2 label Dec 31, 2025
@mergify mergify Bot added the contribution/core This is a PR that came from AWS. label Dec 31, 2025
@rix0rrr rix0rrr marked this pull request as ready for review January 7, 2026 13:02
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Breaking changes in stable modules [events] is disallowed.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@rix0rrr rix0rrr dismissed aws-cdk-automation’s stale review January 9, 2026 09:58

For filtering purposes

Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@rix0rrr rix0rrr added the pr-linter/exempt-breaking-change The PR linter will not require stability in stable modules label Jan 9, 2026
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 9, 2026 10:01

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 12, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 12, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 12, 2026

Merge Queue Status

🚫 The pull request has left the queue (rule: default-squash) at c7de95d

This pull request spent 1 hour 41 minutes 27 seconds in the queue, with no time running CI.

Reason

The pull request can't be updated

merge conflict between base and head

Hint

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 12, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 12, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 12, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 12, 2026

Merge Queue Status

✅ The pull request has been merged at d6831cd

This pull request spent 3 hours 4 minutes 20 seconds in the queue, including 46 minutes 54 seconds running CI.
The checks were run in-place.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = validate-pr
    • check-neutral = validate-pr
    • check-skipped = validate-pr
  • any of [🛡 GitHub branch protection]:
    • check-success = build
    • check-neutral = build
    • check-skipped = build

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 12, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify Bot merged commit 0bea5c9 into main Jan 12, 2026
17 of 18 checks passed
@mergify mergify Bot deleted the huijbers/reference-interfaces-events branch January 12, 2026 16:48
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-breaking-change The PR linter will not require stability in stable modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants