upgrade error-prone static analyzer

Author: ben-manes

caffeine/src/test/java/com/github/benmanes/caffeine/cache/BoundedLocalCacheTest.java

@@ -945,7 +945,8 @@ static void checkStatus(Node<Int, Int> node, Status expected) {
 
   @Test(dataProvider = "caches")
   @CacheSpec(compute = Compute.SYNC, implementation = Implementation.Caffeine,
-      population = Population.EMPTY, maximumSize = Maximum.TEN, weigher = CacheWeigher.DISABLED)
+      population = Population.EMPTY, keys = ReferenceType.STRONG,
+      maximumSize = Maximum.TEN, weigher = CacheWeigher.DISABLED)
   public void evict_wtinylfu(Cache<Int, Int> cache, CacheContext context) {
     // Enforce full initialization of internal structures; clear sketch
     asBoundedLocalCache(cache).frequencySketch().ensureCapacity(context.maximumSize());

caffeine/src/test/java/com/github/benmanes/caffeine/cache/issues/HashClashTest.java

@@ -42,9 +42,9 @@
 @Test(dataProviderClass = CacheProvider.class)
 public final class HashClashTest {
   private static final int STEP = 5;
-  private static final Long LONG_1 = 1L;
+  private static final long LONG_1 = 1L;
   private static final long ITERS = 200_000;
-  private static final Long CLASH = (ITERS << 32) ^ ITERS ^ 1;
+  private static final long CLASH = (ITERS << 32) ^ ITERS ^ 1;
 
   private static final boolean debug = false;
 
@@ -60,7 +60,7 @@ public void testCache(Cache<Long, Long> cache, CacheContext context) {
     printKeys(cache);
 
     // add a hashcode clash for 1
-    assertThat(CLASH.hashCode()).isEqualTo(LONG_1.hashCode());
+    assertThat(Long.hashCode(CLASH)).isEqualTo(Long.hashCode(LONG_1));
     cache.get(CLASH, identity());
     printKeys(cache);
 

gradle/libs.versions.toml

@@ -19,7 +19,7 @@ dependency-check = "12.1.8"
 ecj = "3.43.0"
 eclipse-collections = "13.0.0"
 ehcache3 = "3.11.1"
-errorprone = "2.42.0"
+errorprone = "2.43.0"
 errorprone-plugin = "4.3.0"
 errorprone-support = "0.25.0"
 expiring-map = "0.5.11"
@@ -83,7 +83,7 @@ protobuf = "4.33.0"
 revapi = "1.8.0"
 slf4j = "2.0.17"
 slf4j-test = "3.0.3"
-sigstore = "2.0.0-rc1"
+sigstore = "2.0.0-rc2"
 sonarqube = "7.0.0.6105"
 spotbugs = "4.9.8"
 spotbugs-contrib = "7.6.15"

gradle/plugins/src/main/kotlin/lifecycle/java-library.caffeine.gradle.kts

@@ -43,7 +43,9 @@ tasks.withType<JavaCompile>().configureEach {
   }
 
   options.apply {
-    javaModuleVersion = provider { version as String }
+    javaModuleVersion = provider {
+      version.toString().takeIf { it.first().isDigit() } ?: "0.0.0-$version"
+    }
     compilerArgs.addAll(listOf("-Xlint:all", "-parameters",
       "-Xmaxerrs", "500", "-Xmaxwarns", "500"))
     val failOnWarnings = isCI()

gradle/plugins/src/main/kotlin/quality/errorprone.caffeine.gradle.kts

@@ -84,7 +84,6 @@ tasks.withType<JavaCompile>().configureEach {
 }
 
 fun disabledChecks() = listOf(
-  "AndroidJdkLibsChecker",
   "AssignmentExpression",
   "AvoidObjectArrays",
   "CannotMockMethod",
@@ -95,6 +94,7 @@ fun disabledChecks() = listOf(
   "MissingSummary",
   "MultipleTopLevelClasses",
   "PatternMatchingInstanceof",
+  "RedundantNullCheck",
   "Slf4jLoggerDeclaration",
   "StatementSwitchToExpressionSwitch",
   "StaticImport",