Skip to content

Commit f27b0bb

Browse files
dnfieldbetrevisan
authored andcommitted
Skip test that crashes platform (flutter#34675)
1 parent 4dc7a9b commit f27b0bb

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

testing/scenario_app/android/app/src/androidTest/java/dev/flutter/scenariosui/PlatformViewWithSurfaceViewUiTest.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import androidx.test.runner.AndroidJUnit4;
1313
import dev.flutter.scenarios.PlatformViewsActivity;
1414
import org.junit.Before;
15+
import org.junit.Ignore;
1516
import org.junit.Rule;
1617
import org.junit.Test;
1718
import org.junit.runner.RunWith;
@@ -124,9 +125,12 @@ public void testPlatformViewWithoutOverlayIntersection() throws Exception {
124125
goldName("testPlatformViewWithoutOverlayIntersection"));
125126
}
126127

128+
// TODO(dnfield): This is not safe until https://github.com/flutter/flutter/issues/31990
129+
// is resolved.
130+
@Ignore("not safe until https://github.com/flutter/flutter/issues/31990 is resolved")
127131
@Test
128132
public void testPlatformViewLargerThanDisplaySize() throws Exception {
129-
// Regression test for https://github.com/flutter/flutter/issues/2897.
133+
// Regression test for https://github.com/flutter/flutter/issues/28978.
130134
intent.putExtra("scenario_name", "platform_view_larger_than_display_size");
131135
ScreenshotUtil.capture(
132136
activityRule.launchActivity(intent), goldName("testPlatformViewLargerThanDisplaySize"));

testing/scenario_app/lib/src/platform_view.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ class PlatformViewNoOverlayIntersectionScenario extends Scenario
117117

118118
/// A platform view that is larger than the display size.
119119
/// This is only applicable on Android while using virtual displays.
120-
/// Related issue: https://github.com/flutter/flutter/issues/2897.
120+
/// Related issue: https://github.com/flutter/flutter/issues/28978.
121121
class PlatformViewLargerThanDisplaySize extends Scenario
122122
with _BasePlatformViewScenarioMixin {
123123
/// Creates the PlatformView scenario.

0 commit comments

Comments
 (0)