Skip to content

Commit da9b60f

Browse files
Fixing build issues
1 parent 15b5b86 commit da9b60f

3 files changed

Lines changed: 2 additions & 7 deletions

File tree

.github/workflows/build.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,6 @@ jobs:
278278
_TEST_APK_PATH: app/build/outputs/apk/androidTest/standard/release/com.x8bit.bitwarden-standard-release-androidTest.apk
279279
_TEST_APK_SIGNED_PATH: app/build/outputs/apk/androidTest/standard/release/com.x8bit.bitwarden-test.apk
280280
run: |
281-
./gradlew :app:assembleStandardReleaseAndroidTest
282281
bundle exec fastlane assembleTestApk \
283282
storeFile:app_play-keystore.jks \
284283
storePassword:${{ env.PLAY-KEYSTORE-PASSWORD }} \

.github/workflows/test-device.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@ jobs:
2727
test-device:
2828
name: Check main build against real devices
2929
runs-on: ubuntu-24.04
30-
# TODO: do we need this?
31-
# env:
32-
# _GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3330

3431
steps:
3532
- name: Log in to Azure

fastlane/Fastfile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,10 @@ platform :android do
6969
)
7070
end
7171

72-
# TODO: test if lane builds and signs correctly
73-
desc "Assemble test APK"
72+
desc "Assemble test APK"
7473
lane :assembleTestApk do |options|
7574
buildAndSignBitwarden(
76-
taskName: "app:assembleStandardReleaseAndroidTest",
75+
taskName: "assembleAndroidTest",
7776
buildType: "Release",
7877
storeFile: options[:storeFile],
7978
storePassword: options[:storePassword],

0 commit comments

Comments
 (0)