Skip to content

Hook thinking status #6815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DOsinga merged 6 commits into from
Jan 29, 2026
Merged

Hook thinking status #6815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
00e50fa
Add GOOSE_STATUS_HOOK for terminal status updates
trobrock Jan 27, 2026
c0e8aba
Merge branch 'main' into hook-thinking-status
trobrock Jan 28, 2026
37c08c2
Adapt
Jan 28, 2026
05c4cf2
Merge branch 'main' into hook-thinking-status
Jan 29, 2026
89a986d
Remove tests for GOOSE_STATUS_HOOK
Jan 29, 2026
6c4ef77
Remove doc comment from run_status_hook
Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/goose-cli/src/session/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,7 @@ impl CliSession {
})
.collect();

output::run_status_hook("waiting");
let input = input::get_input(&mut editor, Some(&conversation_strings))?;
if matches!(input, InputResult::Exit) {
break;
Expand Down Expand Up @@ -595,6 +596,7 @@ impl CliSession {

let _provider = self.agent.provider().await?;

output::run_status_hook("thinking");
output::show_thinking();
let start_time = Instant::now();
self.process_agent_response(true, CancellationToken::default())
Expand Down
27 changes: 27 additions & 0 deletions crates/goose-cli/src/session/output.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,33 @@ pub fn hide_thinking() {
}
}

pub fn run_status_hook(status: &str) {
if let Ok(hook) = Config::global().get_param::<String>("GOOSE_STATUS_HOOK") {
let status = status.to_string();
std::thread::spawn(move || {
#[cfg(target_os = "windows")]
let result = std::process::Command::new("cmd")
.arg("/C")
.arg(format!("{} {}", hook, status))
.stdin(std::process::Stdio::null())
.stdout(std::process::Stdio::null())
.stderr(std::process::Stdio::null())
.status();

#[cfg(not(target_os = "windows"))]
let result = std::process::Command::new("sh")
.arg("-c")
.arg(format!("{} {}", hook, status))
.stdin(std::process::Stdio::null())
.stdout(std::process::Stdio::null())
.stderr(std::process::Stdio::null())
.status();

Comment on lines +169 to +186
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Execute the hook directly without a shell to avoid potential injection. Use Command::new(&hook).arg(&status) instead of passing through sh -c. This is safer and simpler.

Suggested change
#[cfg(target_os = "windows")]
let result = std::process::Command::new("cmd")
.arg("/C")
.arg(format!("{} {}", hook, status))
.stdin(std::process::Stdio::null())
.stdout(std::process::Stdio::null())
.stderr(std::process::Stdio::null())
.status();
#[cfg(not(target_os = "windows"))]
let result = std::process::Command::new("sh")
.arg("-c")
.arg(format!("{} {}", hook, status))
.stdin(std::process::Stdio::null())
.stdout(std::process::Stdio::null())
.stderr(std::process::Stdio::null())
.status();
let result = std::process::Command::new(&hook)
.arg(&status)
.stdin(std::process::Stdio::null())
.stdout(std::process::Stdio::null())
.stderr(std::process::Stdio::null())
.status();

Copilot uses AI. Check for mistakes.
Comment on lines +169 to +186
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Execute the hook directly without a shell to avoid potential injection. Use Command::new(&hook).arg(&status) instead of passing through cmd /C. This is safer and simpler.

Suggested change
#[cfg(target_os = "windows")]
let result = std::process::Command::new("cmd")
.arg("/C")
.arg(format!("{} {}", hook, status))
.stdin(std::process::Stdio::null())
.stdout(std::process::Stdio::null())
.stderr(std::process::Stdio::null())
.status();
#[cfg(not(target_os = "windows"))]
let result = std::process::Command::new("sh")
.arg("-c")
.arg(format!("{} {}", hook, status))
.stdin(std::process::Stdio::null())
.stdout(std::process::Stdio::null())
.stderr(std::process::Stdio::null())
.status();
let result = std::process::Command::new(&hook)
.arg(&status)
.stdin(std::process::Stdio::null())
.stdout(std::process::Stdio::null())
.stderr(std::process::Stdio::null())
.status();

Copilot uses AI. Check for mistakes.
let _ = result;
});
}
}

pub fn is_showing_thinking() -> bool {
THINKING.with(|t| t.borrow().is_shown())
}
Expand Down
Loading