Skip to content

Commit d4cd7d5

Browse files
authored
Merge pull request #830 from boostercloud/fix/node16-bug
Fix node 16 bug at deployment
2 parents 9448787 + f16afbf commit d4cd7d5

18 files changed

Lines changed: 28801 additions & 5911 deletions

File tree

.github/workflows/integration-tests.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
- uses: actions/checkout@v2
1212
- uses: actions/setup-node@v1
1313
with:
14-
node-version: 12.x
14+
node-version: 14.x
1515
- run: npx lerna bootstrap
1616
- run: npx lerna run compile
1717
- run: npx lerna run integration/aws-deploy --stream
@@ -29,7 +29,7 @@ jobs:
2929
- uses: actions/checkout@v2
3030
- uses: actions/setup-node@v1
3131
with:
32-
node-version: 12.x
32+
node-version: 14.x
3333
- run: npx lerna bootstrap
3434
- run: npx lerna run compile
3535
- run: npx lerna run integration/aws-func --stream
@@ -47,7 +47,7 @@ jobs:
4747
- uses: actions/checkout@v2
4848
- uses: actions/setup-node@v1
4949
with:
50-
node-version: 12.x
50+
node-version: 14.x
5151
- run: npx lerna bootstrap
5252
- run: npx lerna run compile
5353
- run: npx lerna run integration/aws-end-to-end --stream
@@ -66,7 +66,7 @@ jobs:
6666
- uses: actions/checkout@v2
6767
- uses: actions/setup-node@v1
6868
with:
69-
node-version: 12.x
69+
node-version: 14.x
7070
- run: npx lerna bootstrap
7171
- run: npx lerna run compile
7272
- run: npx lerna run integration/aws-nuke --stream
@@ -82,7 +82,7 @@ jobs:
8282
- uses: actions/checkout@v2
8383
- uses: actions/setup-node@v1
8484
with:
85-
node-version: 12.x
85+
node-version: 14.x
8686
- run: npx lerna bootstrap
8787
- run: npx lerna run compile
8888
- run: npx lerna run integration/cli --stream
@@ -94,7 +94,7 @@ jobs:
9494
- uses: actions/checkout@v2
9595
- uses: actions/setup-node@v1
9696
with:
97-
node-version: 12.x
97+
node-version: 14.x
9898
- run: npx lerna bootstrap
9999
- run: npx lerna run compile
100100
- run: npx lerna run integration/local --stream
@@ -113,11 +113,11 @@ jobs:
113113
driver: 'docker'
114114
- uses: actions/setup-node@v1
115115
with:
116-
node-version: 12.x
116+
node-version: 14.x
117117
- run: sudo snap install helm --classic
118118
- run: kubectl create ns booster-my-store-kubernetes
119119
- run: kubectl config set-context --current --namespace=booster-my-store-kubernetes
120120
- run: minikube start --namespace=booster-my-store-kubernetes
121121
- run: npx lerna bootstrap
122122
- run: npx lerna run compile
123-
- run: npx lerna run integration/k8s-deploy --stream
123+
- run: npx lerna run integration/k8s-deploy --stream

.github/workflows/lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
ref: ${{ github.head_ref }}
1717
- uses: actions/setup-node@v1
1818
with:
19-
node-version: 12.x
19+
node-version: 14.x
2020
- name: Bootstrapping project
2121
run: npx lerna bootstrap
2222
- name: Fixing linting and formatting issues

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040

4141
- uses: actions/setup-node@main
4242
with:
43-
node-version: 12
43+
node-version: 14.x
4444
registry-url: https://registry.npmjs.org/
4545

4646
- run: npx lerna bootstrap

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- uses: actions/checkout@v2
1919
- uses: actions/setup-node@v1
2020
with:
21-
node-version: 12.x
21+
node-version: 14.x
2222
- run: npx lerna bootstrap
2323
- run: npx lerna run compile --stream
2424
- run: npx lerna run test --stream

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ To start contributing to the project you would need to set up the project in you
241241
- `.\scripts\check-all-the-things.ps1` on Windows
242242

243243
> [!Warning]
244-
> Node v12 is the minimum version required.
244+
> Node v14.14 is the minimum version required.
245245
246246
> [!Attention]
247247
> All tests must have passed before submitting a PR.

docs/chapters/02_getting-started.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ You can develop with Booster using any of the following operating systems:
1212

1313
#### Install Node.js
1414

15-
The minimal required Node.js version is `v14`. Download the installer
15+
The minimal required Node.js version is `v14.14`. Download the installer
1616
[from nodejs website](https://nodejs.org/en/), or install it using your system's package
1717
manager.
1818

@@ -45,13 +45,13 @@ Verify that it was installed properly by checking so from your terminal:
4545

4646
```shell
4747
$ node -v
48-
v14.2.0
48+
v14.14.0
4949

5050
$ npm -v
5151
7.0.0
5252
```
5353

54-
As soon as you have a Node.js version higher than `v14`, and an `npm` version higher than
54+
As soon as you have a Node.js version higher than `v14.14`, and an `npm` version higher than
5555
`7`, you are good to go. Just note that `npm` comes with node, you don't have to install
5656
it apart.
5757

@@ -259,7 +259,7 @@ something like
259259

260260
```shell
261261
$ boost version
262-
@boostercloud/cli/0.12.3 darwin-x64 node-v14.0.0
262+
@boostercloud/cli/0.16.1 darwin-x64 node-v14.14.0
263263
```
264264

265265
## Your first Booster app in 10 minutes

0 commit comments

Comments
 (0)