use zstd from python lib or backports.zstd (python<'3.14'), closes #9261

[defnvary]

Description

Replace C dependency for zstd with built in compression.zstd (for python 3.14 and above) falling back to backports.zstd for older python versions.

Issue

#9261

[ThomasWaldmann]

@defnvary Thanks for the PR, looks good!

Guess we also describe the requirements in our install docs, including some dist-specific instructions for linux, bsd, mac, windows about what to install and they need fixing also.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.47%. Comparing base (475b70b) to head (4344eb3).
⚠️ Report is 19 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #9397   +/-   ##
=======================================
  Coverage   76.47%   76.47%           
=======================================
  Files          85       85           
  Lines       14804    14804           
  Branches     2213     2213           
=======================================
  Hits        11322    11322           
  Misses       2803     2803           
  Partials      679      679           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ThomasWaldmann]

chardet/chardet#316

psf/requests#7219

[ThomasWaldmann]

Please update your local master branch and then rebase this branch onto that master and force push.

That should solve the CI test failures that are unrelated to your work.

[defnvary]

Oh Thank you. I thought I made some mistake in setting up the environment🙃.

[ThomasWaldmann]

Looks good overall, dependencies for py<3.14 unclear.

[defnvary]

Looks good overall, dependencies for py<3.14 unclear.

There is backports.zstd dependency that i added in pyproject.toml under dependencies. which i am not 100% sure is the correct place for this kind of dependency. Should i put it under requirements.d/development.txt?

[ThomasWaldmann]

pyproject.toml is the correct place for the backports.zstd dependency.

the files in requirements.d/* mostly define requirements for development, testing, docs building.

[ThomasWaldmann]

BTW, do you know git rebase -i master?

Be careful when first using it, but that is a very nice and powerful command to get a clean commit history.

[defnvary]

BTW, do you know git rebase -i master?

Be careful when first using it, but that is a very nice and powerful command to get a clean commit history.

I know (in theory) never used it. I need to rebase this whole pr into a single commit before merging right?

[ThomasWaldmann]

there are changes from other commits now in your PR.

[ThomasWaldmann]

that should not be in your PR.

[defnvary]

Done.

[ThomasWaldmann]

same here.

[defnvary]

done.

[ThomasWaldmann]

LGTM!

[ThomasWaldmann]

Thanks!