[Enhancement] Added setting to run vorta in background

- Added setting to run vorta in background
- Added option in the mics tab to enable/disable the background question popup.

Author: DaffyTheDuck

src/vorta/application.py

@@ -128,7 +128,7 @@ def open_main_window_action(self):
 
     def toggle_main_window_visibility(self):
         if self.main_window.isVisible():
-            self.main_window.close()
+            self.main_window.hide()
         else:
             self.open_main_window_action()
 

src/vorta/store/connection.py

@@ -1,8 +1,6 @@
 import os
 from datetime import datetime, timedelta
 from peewee import Tuple, fn
-from playhouse import signals
-from vorta.autostart import open_app_at_startup
 from .migrations import run_migrations
 from .models import (
     DB,
@@ -21,12 +19,6 @@
 SCHEMA_VERSION = 20
 
 
-@signals.post_save(sender=SettingsModel)
-def setup_autostart(model_class, instance, created):
-    if instance.key == 'autostart':
-        open_app_at_startup(instance.value)
-
-
 def cleanup_db():
     # Clean up database
     DB.execute_sql("VACUUM")

src/vorta/store/settings.py

@@ -17,6 +17,7 @@ def get_misc_settings() -> List[Dict[str, str]]:
     startup = trans_late('settings', 'Startup')
     information = trans_late('settings', 'Information')
     security = trans_late('settings', 'Security')
+    background = trans_late('settings', 'Background')
 
     # Default settings for all platforms.
     settings = [
@@ -122,9 +123,10 @@ def get_misc_settings() -> List[Dict[str, str]]:
                 'key': 'enable_background_question',
                 'value': True,
                 'type': 'checkbox',
+                'group': background,
                 'label': trans_late(
                     'settings',
-                    "If the system tray isn't available, " "ask whether to continue in the background " "on exit",
+                    "When closing the window, ask whether to continue in the background",
                 ),
             },
             {

src/vorta/views/main_window.py

@@ -6,7 +6,7 @@
 from PyQt5.QtWidgets import QApplication, QCheckBox, QFileDialog, QMenu, QMessageBox, QShortcut, QToolTip
 from vorta.profile_export import ImportFailedException, ProfileExport
 from vorta.store.models import BackupProfileModel, SettingsModel
-from vorta.utils import borg_compat, get_asset, get_network_status_monitor, is_system_tray_available
+from vorta.utils import borg_compat, get_asset, get_network_status_monitor
 from vorta.views.partials.loading_button import LoadingButton
 from vorta.views.utils import get_colored_icon
 from .archive_tab import ArchiveTab
@@ -277,27 +277,26 @@ def closeEvent(self, event):
             SettingsModel.key == 'previous_window_height'
         ).execute()
 
-        if not is_system_tray_available():
-            if SettingsModel.get(key="enable_background_question").value:
-                msg = QMessageBox()
-                msg.setStandardButtons(QMessageBox.Yes | QMessageBox.No)
-                msg.setParent(self, QtCore.Qt.Sheet)
-                msg.setText(self.tr("Should Vorta continue to run in the background?"))
-                msg.button(QMessageBox.Yes).clicked.connect(
-                    lambda: self.miscTab.save_setting("disable_background_state", True)
-                )
-                msg.button(QMessageBox.No).clicked.connect(
-                    lambda: (
-                        self.miscTab.save_setting("disable_background_state", False),
-                        self.app.quit(),
-                    )
+        if SettingsModel.get(key="enable_background_question").value:
+            msg = QMessageBox()
+            msg.setStandardButtons(QMessageBox.Yes | QMessageBox.No)
+            msg.setParent(self, QtCore.Qt.Sheet)
+            msg.setText(self.tr("Should Vorta continue to run in the background?"))
+            msg.button(QMessageBox.Yes).clicked.connect(
+                lambda: self.miscTab.save_setting("disable_background_state", True)
+            )
+            msg.button(QMessageBox.No).clicked.connect(
+                lambda: (
+                    self.miscTab.save_setting("disable_background_state", False),
+                    self.app.quit(),
                 )
-                msg.setWindowTitle(self.tr("Quit"))
-                dont_show_box = QCheckBox(self.tr("Don't show this again"))
-                dont_show_box.clicked.connect(lambda x: self.miscTab.save_setting("enable_background_question", not x))
-                dont_show_box.setTristate(False)
-                msg.setCheckBox(dont_show_box)
-                msg.exec()
-            elif not SettingsModel.get(key="disable_background_state").value:
-                self.app.quit()
+            )
+            msg.setWindowTitle(self.tr("Quit"))
+            dont_show_box = QCheckBox(self.tr("Don't show this again"))
+            dont_show_box.clicked.connect(lambda x: self.miscTab.save_setting("enable_background_question", not x))
+            dont_show_box.setTristate(False)
+            msg.setCheckBox(dont_show_box)
+            msg.exec()
+        elif not SettingsModel.get(key="disable_background_state").value:
+            self.app.quit()
         event.accept()

src/vorta/views/misc_tab.py

@@ -1,8 +1,11 @@
 import logging
+from typing import Dict
+from playhouse import signals
 from PyQt5 import uic
 from PyQt5.QtCore import Qt
 from PyQt5.QtWidgets import QApplication, QCheckBox, QFormLayout, QHBoxLayout, QLabel, QSizePolicy, QSpacerItem
 from vorta._version import __version__
+from vorta.autostart import open_app_at_startup
 from vorta.config import LOG_DIR
 from vorta.i18n import translate
 from vorta.store.models import BackupProfileMixin, SettingsModel
@@ -22,6 +25,8 @@ def __init__(self, parent=None):
         """Init."""
         super().__init__(parent)
         self.setupUi(parent)
+        self.settings_checkboxes: Dict[str, QCheckBox] = {}
+
         self.versionLabel.setText(__version__)
         self.logLink.setText(
             f'<a href="file://{LOG_DIR}"><span style="text-decoration:' 'underline; color:#0984e3;">Log</span></a>'
@@ -34,6 +39,7 @@ def __init__(self, parent=None):
         self.checkboxLayout.setFieldGrowthPolicy(QFormLayout.FieldGrowthPolicy.FieldsStayAtSizeHint)
         self.checkboxLayout.setFormAlignment(Qt.AlignmentFlag.AlignHCenter)
         self.tooltip_buttons = []
+        signals.post_save.connect(self.on_setting_update, sender=SettingsModel)
 
         self.populate()
 
@@ -86,8 +92,8 @@ def populate(self):
 
                 # create widget
                 cb = QCheckBox(translate('settings', setting.label))
+                cb.setChecked(setting.value)
                 cb.setToolTip(setting.tooltip)
-                cb.setCheckState(setting.value)
                 cb.setTristate(False)
                 cb.stateChanged.connect(lambda v, key=setting.key: self.save_setting(key, v))
 
@@ -101,6 +107,7 @@ def populate(self):
                 cbl.addItem(QSpacerItem(0, 0, hPolicy=QSizePolicy.Policy.Expanding))
 
                 # add widget
+                self.settings_checkboxes[setting.key] = cb
                 self.checkboxLayout.setLayout(i, QFormLayout.ItemRole.FieldRole, cbl)
                 self.tooltip_buttons.append(tb)
 
@@ -109,6 +116,41 @@ def populate(self):
 
         self.set_icons()
 
+    def on_setting_update(self, sender, instance: SettingsModel, created=False):
+        """
+        Handle a update of the settings db.
+        Non-PyQt slot for peewee's `playhouse.signals` api.
+        It calls `update_checkbox`.
+
+        Parameters
+        ----------
+        sender : Type[SettingsModel]
+            table sending model
+        instance : SettingsModel
+            The model instance (row) saved.
+        created : bool, optional
+            Whether it was newly created, by default False
+        """
+        if not created and instance.type == 'checkbox':
+            self.update_checkbox(instance.key, instance.value)
+        if instance.key == 'autostart':
+            open_app_at_startup(instance.value)
+
+    def update_checkbox(self, key, value):
+        """
+        Update the checkbox for a setting with a given key.
+
+        Parameters
+        ----------
+        key : str
+            The key of the setting to update.
+        value : bool
+            The value to set the checkbox to.
+        """
+        checkbox = self.settings_checkboxes.get(key)
+        if checkbox:
+            checkbox.setChecked(value)
+
     def set_icons(self):
         """Set or update the icons in this view."""
         for button in self.tooltip_buttons:

tests/conftest.py

@@ -4,6 +4,7 @@
 from unittest.mock import MagicMock
 import pytest
 from peewee import SqliteDatabase
+from playhouse import signals
 import vorta
 import vorta.application
 import vorta.borg.jobs_manager
@@ -91,6 +92,7 @@ def init_db(qapp, qtbot, tmpdir_factory):
     source_dir.save()
 
     qapp.main_window.deleteLater()
+    signals.post_save.disconnect(receiver=qapp.main_window.miscTab.on_setting_update, sender=SettingsModel)
     del qapp.main_window
     qapp.main_window = MainWindow(qapp)  # Re-open main window to apply mock data in UI