vorta --create should block and return borg exit status #1380

Activity

1. real-yfprojects

   added

   type:enhancementImprovement of an existing functionImprovement of an existing function

   help wantedThis issue is available, comment if you want to fix itThis issue is available, comment if you want to fix it

   on Aug 5, 2022
2. real-yfprojects commented on Aug 5, 2022

   

   real-yfprojects

   on Aug 5, 2022

   Collaborator

   More actions

   I aggree that blocking and returning a proper status code would be an enhancement.
3. diivi commented on Mar 15, 2023

   

   diivi

   on Mar 15, 2023

   Last edited by diivi

   Contributor

   More actions

   I would like to work on this, please assign it to me 😄. Also, can you help me understand how I can block vorta instead of exiting? This should be done while the vorta window is open, and then close it when the task completes by using some sort of signal right?
4. diivi commented on Mar 15, 2023

   

   diivi

   on Mar 15, 2023

   Contributor

   More actions

   I looked through the code, in application.py::create_backup_action(), self.jobs_manager.add_job(job) this lines seems to be adding the job for vorta to execute. As this is a BorgCreateJob, I will know that the event is completed from the create.py::finished_event() method right? Now should I add another parameter to this job during creation that will inform me whether it was created normally or via the command line from another instance? I can check for this parameter in the finished_event() method and maybe send a message to the other instance that will inform it about any errors in execution?
5. real-yfprojects

   assigned

   real-yfprojects

   and

   diivi

   and unassigned

   real-yfprojects

   on Mar 15, 2023
6. diivi commented on Mar 16, 2023

   

   diivi

   on Mar 16, 2023

   Last edited by diivi

   Contributor

   More actions

   Hey @real-yfprojects, I might need two instances of vorta to be open while the backup is running. How do I send a message from the main instance to the instance that was created by the command line? This is needed to inform the second instance that a backup was completed/ errored.
   I see that the qt_single_application.py::sendMessage() method only sends a message to the main instance.
   self.app.isRunning() returns False from the main instance even when another instance is open.
7. real-yfprojects commented on Mar 16, 2023

   

   real-yfprojects

   on Mar 16, 2023

   Collaborator

   More actions

   I will know that the event is completed from the create.py::finished_event() method right? Now should I add another parameter to this job during creation that will inform me whether it was created normally or via the command line from another instance?

   You can connect to BorgJob.result instead.

   self.app.isRunning() returns False from the main instance even when another instance is open.

   You shouldn't need isRunning.

   How do I send a message from the main instance to the instance that was created by the command line?

   You have to implement a new method e.g. reply that uses _inSocket to answer.