Code Quality Issues in application.py: Type hint error and string formatting issues #2430

Description

Summary

Found multiple code quality issues in src/vorta/application.py that need to be addressed.

Issues Found

1. Parameter Naming Error

Location: react_to_log() method (around line 370)
Issue: Parameter is named mgs but should be msg

def react_to_log(self, mgs, context):  # Should be 'msg' not 'mgs'

2. Incomplete String Handling in bootstrap_profile()

Location: bootstrap_profile() method (around line 420-427)
Issue: String formatting has improper concatenation with the message "Consider removing or repairing this file to 'get rid of this message.'" The string uses both single quotes inside single quotes and should be properly escaped or use different quoting.

3. Missing Repository Name in Error Message

Location: check_failed_response() method (around line 460)
Issue: Error message references "repo %s failed" but the format string doesn't always provide the repo URL context properly.

4. Dead Code After Return Statement

Location: bootstrap_profile() method
Issue: Code after the return statement in the exception handler may not execute as expected.

Steps to Reproduce

1. Review the src/vorta/application.py file
2. Check the methods mentioned above
3. Run linting tools (ruff, mypy) to identify the issues

Expected Result

All code should follow PEP 8 conventions and type hints should be correct.

Actual Result

Parameters have typos, string formatting is incorrect, and some dead code exists.

Suggested Fix

1. Rename mgs parameter to msg in react_to_log() method
2. Fix the string concatenation in bootstrap_profile() method
3. Review error message formatting in check_failed_response()
4. Remove or reorganize dead code after return statements

Reproduction

• I tried to reproduce the issue.
• I was able to reproduce the issue.

OS

Linux (Ubuntu 22.04)

Version of Vorta

v0.11.3

What did you install Vorta with?

Homebrew

Version of Borg

No response

Logs