style: Use simpler key thingy

Author: Jan Krems

lib/node-inspect.js

@@ -22,7 +22,7 @@
 'use strict'; /* eslint no-underscore-dangle: 0 */
 // Our equivalent of '_debugger' in node itthis
 const assert = require('assert');
-// const crypto = require('crypto');
+const crypto = require('crypto');
 const events = require('events');
 const http = require('http');
 const Repl = require('repl');
@@ -59,51 +59,6 @@ exports.port = process.debugPort;
 
 function ignoreError() {}
 
-// Generate a Sec-WebSocket-* value
-function createSecretKey() {
-    // How many spaces will we be inserting?
-    var numSpaces = 1 + Math.floor(Math.random() * 12);
-    assert.ok(1 <= numSpaces && numSpaces <= 12);
-
-    // What is the numerical value of our key?
-    var keyVal = (Math.floor(
-        Math.random() * (4294967295 / numSpaces)
-    ) * numSpaces);
-
-    // Our string starts with a string representation of our key
-    var s = keyVal.toString();
-
-    // Insert 'numChars' worth of noise in the character ranges
-    // [0x21, 0x2f] (14 characters) and [0x3a, 0x7e] (68 characters)
-    var numChars = 1 + Math.floor(Math.random() * 12);
-    assert.ok(1 <= numChars && numChars <= 12);
-    
-    for (var i = 0; i < numChars; i++) {
-        var pos = Math.floor(Math.random() * s.length + 1);
-
-        var c = Math.floor(Math.random() * (14 + 68));
-        c = (c <= 14) ?
-            String.fromCharCode(c + 0x21) :
-            String.fromCharCode((c - 14) + 0x3a);
-
-        s = s.substring(0, pos) + c + s.substring(pos, s.length);
-    }
-
-    // We shoudln't have any spaces in our value until we insert them
-    assert.equal(s.indexOf(' '), -1);
-
-    // Insert 'numSpaces' worth of spaces
-    for (var i = 0; i < numSpaces; i++) {
-        var pos = Math.floor(Math.random() * (s.length - 1)) + 1;
-        s = s.substring(0, pos) + ' ' + s.substring(pos, s.length);
-    }
-
-    assert.notEqual(s.charAt(0), ' ');
-    assert.notEqual(s.charAt(s.length), ' ');
-
-    return s;
-}
-
 function encodeFrameHybi17(payload) {
   const dataLength = payload.length;
 
@@ -295,7 +250,7 @@ class Client extends events.EventEmitter {
   }
 
   connect(port, host) {
-    const key1 = createSecretKey();
+    const key1 = crypto.randomBytes(16).toString('base64');
 
     const httpReq = this._http = http.request({
       host, port,