From ddd7f414795a6aabb1638e145383b6fc213ed592 Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Wed, 12 Oct 2022 05:43:48 +0300
Subject: [PATCH 01/27] initial

---
 src/config/config_service.py | 10 ++++++----
 src/model/script_config.py   |  5 +++++
 src/web/server.py            | 11 +++++++++--
 3 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/src/config/config_service.py b/src/config/config_service.py
index c1182374..76edec32 100644
--- a/src/config/config_service.py
+++ b/src/config/config_service.py
@@ -3,13 +3,14 @@
 import os
 import re
 from collections import namedtuple
-from typing import Union
+from typing import List, Union
 
 from auth.authorization import Authorizer
 from config.exceptions import InvalidConfigException
 from model import script_config
 from model.model_helper import InvalidFileException
-from model.script_config import get_sorted_config
+from model.script_config import get_sorted_config, GetShortConfigFailedError
+from src.model.script_config import ShortConfig
 from utils import os_utils, file_utils, process_utils, custom_json, custom_yaml
 from utils.file_utils import to_filename
 from utils.string_utils import is_blank, strip
@@ -176,7 +177,7 @@ def list_configs(self, user, mode=None):
 
         conf_service = self
 
-        def load_script(path, content):
+        def load_script(path, content) -> Union[ShortConfig, GetShortConfigFailedError]:
             try:
                 config_object = self.load_config_file(path, content)
                 short_config = script_config.read_short(path, config_object)
@@ -193,6 +194,7 @@ def load_script(path, content):
                 return short_config
             except:
                 LOGGER.exception('Could not load script: ' + path)
+                return GetShortConfigFailedError(path)
 
         return self._visit_script_configs(load_script)
 
@@ -209,7 +211,7 @@ def load_config_model(self, name, user, parameter_values=None, skip_invalid_para
 
         return self._load_script_config(path, config_object, user, parameter_values, skip_invalid_parameters)
 
-    def _visit_script_configs(self, visitor):
+    def _visit_script_configs(self, visitor) -> List[ Union[ShortConfig, GetShortConfigFailedError] ]:
         configs_dir = self._script_configs_folder
         files = os.listdir(configs_dir)
 
diff --git a/src/model/script_config.py b/src/model/script_config.py
index 3823c29d..dac281da 100644
--- a/src/model/script_config.py
+++ b/src/model/script_config.py
@@ -28,6 +28,11 @@ def __init__(self):
         self.admin_users = []
         self.group = None
 
+class GetShortConfigFailedError(object):
+    def __init__(self, path):
+      self.path = path
+      # self.group = 'Parsing failed'
+      self.cannotParse = True
 
 @observable_fields(
     'script_command',
diff --git a/src/web/server.py b/src/web/server.py
index b052fa3c..3d2d68d7 100755
--- a/src/web/server.py
+++ b/src/web/server.py
@@ -137,9 +137,16 @@ def get(self, user):
 
         configs = self.application.config_service.list_configs(user, mode)
 
-        scripts = [{'name': conf.name, 'group': conf.group} for conf in configs]
+        scripts = []
+        failed = []
 
-        self.write(json.dumps({'scripts': scripts}))
+        for conf in configs:
+            if hasattr(conf, 'cannotParse'):
+              failed.append({'path': conf.path })
+            else:
+              scripts.append({'name': conf.name, 'group': conf.group })
+
+        self.write(json.dumps({'scripts': scripts, 'failed': failed}))
 
 
 class AdminUpdateScriptEndpoint(BaseRequestHandler):

From aa827623a6979bddc24fad75de07bc1517b581bf Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Fri, 14 Oct 2022 04:56:58 +0300
Subject: [PATCH 02/27] frontend initial (tests not fixed)

---
 .../components/scripts/ScriptFailedGroup.vue  | 44 +++++++++++++++++++
 .../components/scripts/ScriptListGroup.css    | 20 +++++++++
 .../components/scripts/ScriptListGroup.vue    | 23 +---------
 .../components/scripts/ScriptsList.vue        | 12 ++++-
 web-src/src/main-app/store/scripts.js         |  9 +++-
 5 files changed, 83 insertions(+), 25 deletions(-)
 create mode 100644 web-src/src/main-app/components/scripts/ScriptFailedGroup.vue
 create mode 100644 web-src/src/main-app/components/scripts/ScriptListGroup.css

diff --git a/web-src/src/main-app/components/scripts/ScriptFailedGroup.vue b/web-src/src/main-app/components/scripts/ScriptFailedGroup.vue
new file mode 100644
index 00000000..171519fb
--- /dev/null
+++ b/web-src/src/main-app/components/scripts/ScriptFailedGroup.vue
@@ -0,0 +1,44 @@
+<template>
+  <div 
+    v-if="failedItems.scripts.length"
+    class="script-list-group script-list-failed-group" 
+    @click="$emit('group-clicked', failedItems.name)">
+    <div 
+      class="collection-item waves-effect script-group script-failed-group">
+      <span>{{failedItems.name}}</span>
+      <i class="material-icons">
+        {{ failedItems.isActive ? 'expand_less' : 'expand_more' }}
+      </i>
+    </div>
+    <template v-for="item in failedItems.scripts" v-if="failedItems.isActive">
+      <div class="collection-item script-list-item script-list-failed-item">
+          {{ item.path }}
+      </div>
+    </template>
+  </div>
+</template>
+
+<script>
+import ScriptListItem from './ScriptListItem';
+
+export default {
+  name: 'ScriptListGroup',
+  components: {ScriptListItem},
+  props: {
+    failedItems: {
+      type: Object
+    }
+  }
+}
+</script>
+
+<style scoped>
+    @import "./ScriptListGroup.css";
+    .script-failed-group {
+      color: var(--error-color);
+    }
+    div.script-list-failed-item {
+      padding-top:    4px;
+      padding-bottom: 4px;
+    }
+</style>
\ No newline at end of file
diff --git a/web-src/src/main-app/components/scripts/ScriptListGroup.css b/web-src/src/main-app/components/scripts/ScriptListGroup.css
new file mode 100644
index 00000000..f9395280
--- /dev/null
+++ b/web-src/src/main-app/components/scripts/ScriptListGroup.css
@@ -0,0 +1,20 @@
+.script-list-group .collection-item.script-group {
+  border: none;
+  display: flex;
+  flex-direction: row;
+  padding-right: 16px;
+  align-items: center;
+}
+
+.script-list-group .collection-item.script-group span {
+  flex: 1 1 auto;
+}
+
+.script-list-group .collection-item.script-group i {
+  flex: 0 0 auto;
+  line-height: 16px;
+}
+
+.script-list-group .collection-item.script-list-item {
+  padding-left: 36px;
+}
\ No newline at end of file
diff --git a/web-src/src/main-app/components/scripts/ScriptListGroup.vue b/web-src/src/main-app/components/scripts/ScriptListGroup.vue
index ab9e5283..8f9013c7 100644
--- a/web-src/src/main-app/components/scripts/ScriptListGroup.vue
+++ b/web-src/src/main-app/components/scripts/ScriptListGroup.vue
@@ -30,26 +30,5 @@ export default {
 </script>
 
 <style scoped>
-
-.script-list-group .collection-item.script-group {
-  border: none;
-  display: flex;
-  flex-direction: row;
-  padding-right: 16px;
-  align-items: center;
-}
-
-.script-list-group .collection-item.script-group span {
-  flex: 1 1 auto;
-}
-
-.script-list-group .collection-item.script-group i {
-  flex: 0 0 auto;
-  line-height: 16px;
-}
-
-.script-list-group >>> .collection-item.script-list-item {
-  padding-left: 36px;
-}
-
+  @import "./ScriptListGroup.css";
 </style>
\ No newline at end of file
diff --git a/web-src/src/main-app/components/scripts/ScriptsList.vue b/web-src/src/main-app/components/scripts/ScriptsList.vue
index f283a29f..6fd087a8 100644
--- a/web-src/src/main-app/components/scripts/ScriptsList.vue
+++ b/web-src/src/main-app/components/scripts/ScriptsList.vue
@@ -4,6 +4,7 @@
       <ScriptListGroup v-if="item.isGroup" :key="item.name" :group="item" @group-clicked="groupClicked($event)"/>
       <ScriptListItem v-else :key="item.name" :script="item"/>
     </template>
+    <ScriptFailedGroup :failedItems="failedItems" @group-clicked="groupClicked($event)"></ScriptFailedGroup>
   </div>
 </template>
 
@@ -11,11 +12,12 @@
 import {isBlankString, isEmptyString, isNull, removeElement} from '@/common/utils/common';
 import {mapState} from 'vuex';
 import ScriptListGroup from './ScriptListGroup';
+import ScriptFailedGroup from './ScriptFailedGroup';
 import ScriptListItem from './ScriptListItem';
 
 export default {
   name: 'ScriptsList',
-  components: {ScriptListGroup, ScriptListItem},
+  components: {ScriptListGroup, ScriptListItem, ScriptFailedGroup},
   props: {
     searchText: {
       type: String,
@@ -30,7 +32,7 @@ export default {
   },
 
   computed: {
-    ...mapState('scripts', ['scripts', 'selectedScript']),
+    ...mapState('scripts', ['scripts', 'selectedScript', 'failedScripts']),
 
     items() {
       let groups = this.scripts.filter(script => !isBlankString(script.group))
@@ -55,6 +57,12 @@ export default {
       result.sort((o1, o2) => o1.name.toLowerCase().localeCompare(o2.name.toLowerCase()));
 
       return result;
+    },
+
+    failedItems() {
+      const groupName = 'Failed to parse'
+      const result = {name: groupName, isGroup: true, scripts: [...this.failedScripts], isActive: this.activeGroup == groupName}
+      return result
     }
   },
   methods: {
diff --git a/web-src/src/main-app/store/scripts.js b/web-src/src/main-app/store/scripts.js
index d3a8ac2f..3c8061f7 100644
--- a/web-src/src/main-app/store/scripts.js
+++ b/web-src/src/main-app/store/scripts.js
@@ -9,6 +9,7 @@ export default {
 
     state: {
         scripts: [],
+        failedScripts: [],
         selectedScript: null,
         predefinedParameters: null
     },
@@ -21,12 +22,14 @@ export default {
 
             axiosInstance.get('scripts')
                 .then(({data}) => {
-                    const {scripts} = data;
+                    const scripts = data.scripts;
+                    const failedScripts = data.failed;
                     scripts.sort(function (script1, script2) {
                         return script1.name.toLowerCase().localeCompare(script2.name.toLowerCase());
                     });
 
                     commit('SET_SCRIPTS', scripts);
+                    commit('SET_FAILED_SCRIPTS', failedScripts);
                     dispatch('selectScriptByHash');
                 });
         },
@@ -73,6 +76,10 @@ export default {
             state.scripts = scripts
         },
 
+        SET_FAILED_SCRIPTS(state, failedScripts) {
+            state.failedScripts = failedScripts
+        },
+
         SELECT_SCRIPT(state, {selectedScript, predefinedParameters}) {
             state.selectedScript = selectedScript;
             state.predefinedParameters = predefinedParameters;

From fa4672ad898c71e5c8fd1429f9275b8c32feab4f Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Fri, 14 Oct 2022 05:05:21 +0300
Subject: [PATCH 03/27] a lil clarification in group name

---
 web-src/src/main-app/components/scripts/ScriptsList.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/web-src/src/main-app/components/scripts/ScriptsList.vue b/web-src/src/main-app/components/scripts/ScriptsList.vue
index 6fd087a8..5bf762de 100644
--- a/web-src/src/main-app/components/scripts/ScriptsList.vue
+++ b/web-src/src/main-app/components/scripts/ScriptsList.vue
@@ -60,7 +60,7 @@ export default {
     },
 
     failedItems() {
-      const groupName = 'Failed to parse'
+      const groupName = 'Failed to parse (these files have invalid JSON structure)'
       const result = {name: groupName, isGroup: true, scripts: [...this.failedScripts], isActive: this.activeGroup == groupName}
       return result
     }

From 0cf987329fcab7aaefe6e018d2bd7d0b90d28a3c Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Sun, 16 Oct 2022 01:42:24 +0300
Subject: [PATCH 04/27] added parsing_failed to ShortConfig type (.py files
 only)

---
 src/config/config_service.py | 12 +++++++-----
 src/model/script_config.py   |  7 +------
 src/web/server.py            | 11 ++---------
 3 files changed, 10 insertions(+), 20 deletions(-)

diff --git a/src/config/config_service.py b/src/config/config_service.py
index 76edec32..5f7ff8b5 100644
--- a/src/config/config_service.py
+++ b/src/config/config_service.py
@@ -9,8 +9,7 @@
 from config.exceptions import InvalidConfigException
 from model import script_config
 from model.model_helper import InvalidFileException
-from model.script_config import get_sorted_config, GetShortConfigFailedError
-from src.model.script_config import ShortConfig
+from model.script_config import get_sorted_config, ShortConfig
 from utils import os_utils, file_utils, process_utils, custom_json, custom_yaml
 from utils.file_utils import to_filename
 from utils.string_utils import is_blank, strip
@@ -177,7 +176,7 @@ def list_configs(self, user, mode=None):
 
         conf_service = self
 
-        def load_script(path, content) -> Union[ShortConfig, GetShortConfigFailedError]:
+        def load_script(path, content) -> ShortConfig:
             try:
                 config_object = self.load_config_file(path, content)
                 short_config = script_config.read_short(path, config_object)
@@ -194,7 +193,10 @@ def load_script(path, content) -> Union[ShortConfig, GetShortConfigFailedError]:
                 return short_config
             except:
                 LOGGER.exception('Could not load script: ' + path)
-                return GetShortConfigFailedError(path)
+                failed_short_config = ShortConfig()
+                failed_short_config.name = path
+                failed_short_config.parsing_failed = True
+                return failed_short_config
 
         return self._visit_script_configs(load_script)
 
@@ -211,7 +213,7 @@ def load_config_model(self, name, user, parameter_values=None, skip_invalid_para
 
         return self._load_script_config(path, config_object, user, parameter_values, skip_invalid_parameters)
 
-    def _visit_script_configs(self, visitor) -> List[ Union[ShortConfig, GetShortConfigFailedError] ]:
+    def _visit_script_configs(self, visitor) -> List[ ShortConfig ]:
         configs_dir = self._script_configs_folder
         files = os.listdir(configs_dir)
 
diff --git a/src/model/script_config.py b/src/model/script_config.py
index dac281da..f1ff0773 100644
--- a/src/model/script_config.py
+++ b/src/model/script_config.py
@@ -27,12 +27,7 @@ def __init__(self):
         self.allowed_users = []
         self.admin_users = []
         self.group = None
-
-class GetShortConfigFailedError(object):
-    def __init__(self, path):
-      self.path = path
-      # self.group = 'Parsing failed'
-      self.cannotParse = True
+        self.parsing_failed = False
 
 @observable_fields(
     'script_command',
diff --git a/src/web/server.py b/src/web/server.py
index 3d2d68d7..b052fa3c 100755
--- a/src/web/server.py
+++ b/src/web/server.py
@@ -137,16 +137,9 @@ def get(self, user):
 
         configs = self.application.config_service.list_configs(user, mode)
 
-        scripts = []
-        failed = []
+        scripts = [{'name': conf.name, 'group': conf.group} for conf in configs]
 
-        for conf in configs:
-            if hasattr(conf, 'cannotParse'):
-              failed.append({'path': conf.path })
-            else:
-              scripts.append({'name': conf.name, 'group': conf.group })
-
-        self.write(json.dumps({'scripts': scripts, 'failed': failed}))
+        self.write(json.dumps({'scripts': scripts}))
 
 
 class AdminUpdateScriptEndpoint(BaseRequestHandler):

From 1e406ea19dfd098ce7d7910e6bb4ad4be993df0b Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Sun, 16 Oct 2022 02:03:02 +0300
Subject: [PATCH 05/27] reverting vue changes

---
 .../components/scripts/ScriptFailedGroup.vue  | 44 -------------------
 .../components/scripts/ScriptListGroup.css    | 20 ---------
 .../components/scripts/ScriptListGroup.vue    | 20 ++++++++-
 .../components/scripts/ScriptsList.vue        | 12 +----
 web-src/src/main-app/store/scripts.js         |  8 +---
 5 files changed, 22 insertions(+), 82 deletions(-)
 delete mode 100644 web-src/src/main-app/components/scripts/ScriptFailedGroup.vue
 delete mode 100644 web-src/src/main-app/components/scripts/ScriptListGroup.css

diff --git a/web-src/src/main-app/components/scripts/ScriptFailedGroup.vue b/web-src/src/main-app/components/scripts/ScriptFailedGroup.vue
deleted file mode 100644
index 171519fb..00000000
--- a/web-src/src/main-app/components/scripts/ScriptFailedGroup.vue
+++ /dev/null
@@ -1,44 +0,0 @@
-<template>
-  <div 
-    v-if="failedItems.scripts.length"
-    class="script-list-group script-list-failed-group" 
-    @click="$emit('group-clicked', failedItems.name)">
-    <div 
-      class="collection-item waves-effect script-group script-failed-group">
-      <span>{{failedItems.name}}</span>
-      <i class="material-icons">
-        {{ failedItems.isActive ? 'expand_less' : 'expand_more' }}
-      </i>
-    </div>
-    <template v-for="item in failedItems.scripts" v-if="failedItems.isActive">
-      <div class="collection-item script-list-item script-list-failed-item">
-          {{ item.path }}
-      </div>
-    </template>
-  </div>
-</template>
-
-<script>
-import ScriptListItem from './ScriptListItem';
-
-export default {
-  name: 'ScriptListGroup',
-  components: {ScriptListItem},
-  props: {
-    failedItems: {
-      type: Object
-    }
-  }
-}
-</script>
-
-<style scoped>
-    @import "./ScriptListGroup.css";
-    .script-failed-group {
-      color: var(--error-color);
-    }
-    div.script-list-failed-item {
-      padding-top:    4px;
-      padding-bottom: 4px;
-    }
-</style>
\ No newline at end of file
diff --git a/web-src/src/main-app/components/scripts/ScriptListGroup.css b/web-src/src/main-app/components/scripts/ScriptListGroup.css
deleted file mode 100644
index f9395280..00000000
--- a/web-src/src/main-app/components/scripts/ScriptListGroup.css
+++ /dev/null
@@ -1,20 +0,0 @@
-.script-list-group .collection-item.script-group {
-  border: none;
-  display: flex;
-  flex-direction: row;
-  padding-right: 16px;
-  align-items: center;
-}
-
-.script-list-group .collection-item.script-group span {
-  flex: 1 1 auto;
-}
-
-.script-list-group .collection-item.script-group i {
-  flex: 0 0 auto;
-  line-height: 16px;
-}
-
-.script-list-group .collection-item.script-list-item {
-  padding-left: 36px;
-}
\ No newline at end of file
diff --git a/web-src/src/main-app/components/scripts/ScriptListGroup.vue b/web-src/src/main-app/components/scripts/ScriptListGroup.vue
index 8f9013c7..3d1711b9 100644
--- a/web-src/src/main-app/components/scripts/ScriptListGroup.vue
+++ b/web-src/src/main-app/components/scripts/ScriptListGroup.vue
@@ -30,5 +30,23 @@ export default {
 </script>
 
 <style scoped>
-  @import "./ScriptListGroup.css";
+
+  .script-list-group .collection-item.script-group {
+    border: none;
+    display: flex;
+    flex-direction: row;
+    padding-right: 16px;
+    align-items: center;
+  }
+  .script-list-group .collection-item.script-group span {
+    flex: 1 1 auto;
+  }
+  .script-list-group .collection-item.script-group i {
+    flex: 0 0 auto;
+    line-height: 16px;
+  }
+  .script-list-group >>> .collection-item.script-list-item {
+    padding-left: 36px;
+  }
+
 </style>
\ No newline at end of file
diff --git a/web-src/src/main-app/components/scripts/ScriptsList.vue b/web-src/src/main-app/components/scripts/ScriptsList.vue
index 5bf762de..6cbd8c68 100644
--- a/web-src/src/main-app/components/scripts/ScriptsList.vue
+++ b/web-src/src/main-app/components/scripts/ScriptsList.vue
@@ -4,7 +4,6 @@
       <ScriptListGroup v-if="item.isGroup" :key="item.name" :group="item" @group-clicked="groupClicked($event)"/>
       <ScriptListItem v-else :key="item.name" :script="item"/>
     </template>
-    <ScriptFailedGroup :failedItems="failedItems" @group-clicked="groupClicked($event)"></ScriptFailedGroup>
   </div>
 </template>
 
@@ -12,12 +11,11 @@
 import {isBlankString, isEmptyString, isNull, removeElement} from '@/common/utils/common';
 import {mapState} from 'vuex';
 import ScriptListGroup from './ScriptListGroup';
-import ScriptFailedGroup from './ScriptFailedGroup';
 import ScriptListItem from './ScriptListItem';
 
 export default {
   name: 'ScriptsList',
-  components: {ScriptListGroup, ScriptListItem, ScriptFailedGroup},
+  components: {ScriptListGroup, ScriptListItem},
   props: {
     searchText: {
       type: String,
@@ -32,7 +30,7 @@ export default {
   },
 
   computed: {
-    ...mapState('scripts', ['scripts', 'selectedScript', 'failedScripts']),
+    ...mapState('scripts', ['scripts', 'selectedScript']),
 
     items() {
       let groups = this.scripts.filter(script => !isBlankString(script.group))
@@ -58,12 +56,6 @@ export default {
 
       return result;
     },
-
-    failedItems() {
-      const groupName = 'Failed to parse (these files have invalid JSON structure)'
-      const result = {name: groupName, isGroup: true, scripts: [...this.failedScripts], isActive: this.activeGroup == groupName}
-      return result
-    }
   },
   methods: {
     groupClicked(groupName) {
diff --git a/web-src/src/main-app/store/scripts.js b/web-src/src/main-app/store/scripts.js
index 3c8061f7..4e92c997 100644
--- a/web-src/src/main-app/store/scripts.js
+++ b/web-src/src/main-app/store/scripts.js
@@ -22,14 +22,12 @@ export default {
 
             axiosInstance.get('scripts')
                 .then(({data}) => {
-                    const scripts = data.scripts;
-                    const failedScripts = data.failed;
+                    const {scripts} = data;
                     scripts.sort(function (script1, script2) {
                         return script1.name.toLowerCase().localeCompare(script2.name.toLowerCase());
                     });
 
                     commit('SET_SCRIPTS', scripts);
-                    commit('SET_FAILED_SCRIPTS', failedScripts);
                     dispatch('selectScriptByHash');
                 });
         },
@@ -76,10 +74,6 @@ export default {
             state.scripts = scripts
         },
 
-        SET_FAILED_SCRIPTS(state, failedScripts) {
-            state.failedScripts = failedScripts
-        },
-
         SELECT_SCRIPT(state, {selectedScript, predefinedParameters}) {
             state.selectedScript = selectedScript;
             state.predefinedParameters = predefinedParameters;

From 56d0b8e2a36358de519d191ce7f913d0b26c78a6 Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Sun, 16 Oct 2022 02:05:55 +0300
Subject: [PATCH 06/27] additional Vue reverts

---
 .../components/scripts/ScriptListGroup.vue    | 37 ++++++++++---------
 .../components/scripts/ScriptsList.vue        |  2 +-
 web-src/src/main-app/store/scripts.js         |  1 -
 3 files changed, 21 insertions(+), 19 deletions(-)

diff --git a/web-src/src/main-app/components/scripts/ScriptListGroup.vue b/web-src/src/main-app/components/scripts/ScriptListGroup.vue
index 3d1711b9..ab9e5283 100644
--- a/web-src/src/main-app/components/scripts/ScriptListGroup.vue
+++ b/web-src/src/main-app/components/scripts/ScriptListGroup.vue
@@ -31,22 +31,25 @@ export default {
 
 <style scoped>
 
-  .script-list-group .collection-item.script-group {
-    border: none;
-    display: flex;
-    flex-direction: row;
-    padding-right: 16px;
-    align-items: center;
-  }
-  .script-list-group .collection-item.script-group span {
-    flex: 1 1 auto;
-  }
-  .script-list-group .collection-item.script-group i {
-    flex: 0 0 auto;
-    line-height: 16px;
-  }
-  .script-list-group >>> .collection-item.script-list-item {
-    padding-left: 36px;
-  }
+.script-list-group .collection-item.script-group {
+  border: none;
+  display: flex;
+  flex-direction: row;
+  padding-right: 16px;
+  align-items: center;
+}
+
+.script-list-group .collection-item.script-group span {
+  flex: 1 1 auto;
+}
+
+.script-list-group .collection-item.script-group i {
+  flex: 0 0 auto;
+  line-height: 16px;
+}
+
+.script-list-group >>> .collection-item.script-list-item {
+  padding-left: 36px;
+}
 
 </style>
\ No newline at end of file
diff --git a/web-src/src/main-app/components/scripts/ScriptsList.vue b/web-src/src/main-app/components/scripts/ScriptsList.vue
index 6cbd8c68..f283a29f 100644
--- a/web-src/src/main-app/components/scripts/ScriptsList.vue
+++ b/web-src/src/main-app/components/scripts/ScriptsList.vue
@@ -55,7 +55,7 @@ export default {
       result.sort((o1, o2) => o1.name.toLowerCase().localeCompare(o2.name.toLowerCase()));
 
       return result;
-    },
+    }
   },
   methods: {
     groupClicked(groupName) {
diff --git a/web-src/src/main-app/store/scripts.js b/web-src/src/main-app/store/scripts.js
index 4e92c997..d3a8ac2f 100644
--- a/web-src/src/main-app/store/scripts.js
+++ b/web-src/src/main-app/store/scripts.js
@@ -9,7 +9,6 @@ export default {
 
     state: {
         scripts: [],
-        failedScripts: [],
         selectedScript: null,
         predefinedParameters: null
     },

From 62df42980a8a4f8ec58ac95432a472899a7e6821 Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Mon, 17 Oct 2022 03:49:02 +0300
Subject: [PATCH 07/27] server.py parsing_failed parameter transmission fixed

---
 src/web/server.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/web/server.py b/src/web/server.py
index b052fa3c..60684f9e 100755
--- a/src/web/server.py
+++ b/src/web/server.py
@@ -137,7 +137,7 @@ def get(self, user):
 
         configs = self.application.config_service.list_configs(user, mode)
 
-        scripts = [{'name': conf.name, 'group': conf.group} for conf in configs]
+        scripts = [{'name': conf.name, 'group': conf.group, 'parsing_failed': conf.parsing_failed } for conf in configs]
 
         self.write(json.dumps({'scripts': scripts}))
 

From a33f79ee7c373d1604f6b9aa6c33b95e38feb69e Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Mon, 17 Oct 2022 03:50:21 +0300
Subject: [PATCH 08/27] bad script red highlight added

---
 .../src/main-app/components/scripts/ScriptListItem.vue   | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/web-src/src/main-app/components/scripts/ScriptListItem.vue b/web-src/src/main-app/components/scripts/ScriptListItem.vue
index 3c653da1..088d1275 100644
--- a/web-src/src/main-app/components/scripts/ScriptListItem.vue
+++ b/web-src/src/main-app/components/scripts/ScriptListItem.vue
@@ -1,7 +1,7 @@
 <template>
   <router-link :to="'/' + descriptor.hash"
                class="collection-item waves-effect script-list-item"
-               v-bind:class="{ active: descriptor.active}">
+               v-bind:class="{ active: descriptor.active, 'parsing-failed': descriptor.parsingFailed}">
     {{ descriptor.name }}
 
     <div :class="descriptor.state" class="menu-item-state">
@@ -44,7 +44,8 @@ export default {
         name: this.script.name,
         state: this.getState(this.script.name),
         active: this.selectedScript === this.script.name,
-        hash: this.toHash(this.script.name)
+        hash: this.toHash(this.script.name),
+        parsingFailed: this.script.parsing_failed,
       }
     },
     ...mapState('scripts', ['selectedScript'])
@@ -74,6 +75,10 @@ export default {
   padding-right: 32px;
 }
 
+.scripts-list .collection-item.parsing-failed {
+  color: var(--error-color);
+}
+
 .scripts-list .collection-item .menu-item-state {
   width: 24px;
   height: 24px;

From b0e23c69c832f4d5130676d1ba394da372582ffb Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Mon, 17 Oct 2022 04:06:11 +0300
Subject: [PATCH 09/27] added cannot-parse icon

---
 .../components/scripts/ScriptListItem.vue     | 29 +++++++++++++++++--
 1 file changed, 26 insertions(+), 3 deletions(-)

diff --git a/web-src/src/main-app/components/scripts/ScriptListItem.vue b/web-src/src/main-app/components/scripts/ScriptListItem.vue
index 088d1275..498aaee0 100644
--- a/web-src/src/main-app/components/scripts/ScriptListItem.vue
+++ b/web-src/src/main-app/components/scripts/ScriptListItem.vue
@@ -6,6 +6,7 @@
 
     <div :class="descriptor.state" class="menu-item-state">
       <i class="material-icons check-icon">check</i>
+      <i class="material-icons failed-icon">close</i>
       <div class="preloader-wrapper active">
         <div class="spinner-layer">
           <div class="circle-clipper left">
@@ -54,6 +55,8 @@ export default {
     getState(scriptName) {
       let state = 'idle';
 
+      if(this.script.parsing_failed) return 'cannot-parse'
+
       forEachKeyValue(this.$store.state.executions.executors, function (id, executor) {
         if (executor.state.scriptName !== scriptName) {
           return;
@@ -77,6 +80,7 @@ export default {
 
 .scripts-list .collection-item.parsing-failed {
   color: var(--error-color);
+  
 }
 
 .scripts-list .collection-item .menu-item-state {
@@ -101,11 +105,15 @@ export default {
 }
 
 .scripts-list .collection-item .menu-item-state.executing,
-.scripts-list .collection-item .menu-item-state.finished {
+.scripts-list .collection-item .menu-item-state.finished,
+.scripts-list .collection-item .menu-item-state.cannot-parse {
   display: inline;
 }
 
-.scripts-list .collection-item .menu-item-state.executing > .check-icon {
+/* state: executing */
+
+.scripts-list .collection-item .menu-item-state.executing > .check-icon,
+.scripts-list .collection-item .menu-item-state.executing > .failed-icon {
   display: none;
 }
 
@@ -113,14 +121,29 @@ export default {
   display: block;
 }
 
+/* state: finished */
+
 .scripts-list .collection-item .menu-item-state.finished > .check-icon {
   display: block;
 }
 
-.scripts-list .collection-item .menu-item-state.finished > .preloader-wrapper {
+.scripts-list .collection-item .menu-item-state.finished > .preloader-wrapper,
+.scripts-list .collection-item .menu-item-state.finished > .failed-icon {
   display: none;
 }
 
+/* state: cannot-parse */
+
+.scripts-list .collection-item .menu-item-state.cannot-parse > .check-icon,
+.scripts-list .collection-item .menu-item-state.cannot-parse > .preloader-wrapper {
+  display: none;
+}
+
+
+.scripts-list .collection-item .menu-item-state.cannot-parse > .failed-icon {
+  display: block;
+}
+
 .scripts-list .collection-item .preloader-wrapper .spinner-layer {
   border-color: var(--primary-color);
 }

From fa578132dc722be107e9dbdac4152daddfdfcd04 Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Mon, 17 Oct 2022 04:07:39 +0300
Subject: [PATCH 10/27] changed "parsing-failed" icon

---
 web-src/src/main-app/components/scripts/ScriptListItem.vue | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/web-src/src/main-app/components/scripts/ScriptListItem.vue b/web-src/src/main-app/components/scripts/ScriptListItem.vue
index 498aaee0..159ce4f8 100644
--- a/web-src/src/main-app/components/scripts/ScriptListItem.vue
+++ b/web-src/src/main-app/components/scripts/ScriptListItem.vue
@@ -6,7 +6,7 @@
 
     <div :class="descriptor.state" class="menu-item-state">
       <i class="material-icons check-icon">check</i>
-      <i class="material-icons failed-icon">close</i>
+      <i class="material-icons failed-icon">cancel</i>
       <div class="preloader-wrapper active">
         <div class="spinner-layer">
           <div class="circle-clipper left">
@@ -80,7 +80,7 @@ export default {
 
 .scripts-list .collection-item.parsing-failed {
   color: var(--error-color);
-  
+
 }
 
 .scripts-list .collection-item .menu-item-state {

From 1d9c2b8b59afb5732ffbfed2ef71fed6b469419e Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Mon, 17 Oct 2022 04:09:48 +0300
Subject: [PATCH 11/27] yet again icon change

---
 web-src/src/main-app/components/scripts/ScriptListItem.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/web-src/src/main-app/components/scripts/ScriptListItem.vue b/web-src/src/main-app/components/scripts/ScriptListItem.vue
index 159ce4f8..074fe385 100644
--- a/web-src/src/main-app/components/scripts/ScriptListItem.vue
+++ b/web-src/src/main-app/components/scripts/ScriptListItem.vue
@@ -6,7 +6,7 @@
 
     <div :class="descriptor.state" class="menu-item-state">
       <i class="material-icons check-icon">check</i>
-      <i class="material-icons failed-icon">cancel</i>
+      <i class="material-icons failed-icon">do_not_disturb_alt</i>
       <div class="preloader-wrapper active">
         <div class="spinner-layer">
           <div class="circle-clipper left">

From 7338f3e3f9478adf6b41cfe9d84960578cab0d86 Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Mon, 17 Oct 2022 06:49:43 +0300
Subject: [PATCH 12/27] (backend) added BadConfigFileException and (mostly) its
 catchers

---
 src/config/config_service.py    | 40 ++++++++++++++++++++++++++-------
 src/web/script_config_socket.py |  5 ++++-
 src/web/server.py               | 11 ++++++++-
 3 files changed, 46 insertions(+), 10 deletions(-)

diff --git a/src/config/config_service.py b/src/config/config_service.py
index 5f7ff8b5..b93a99f2 100644
--- a/src/config/config_service.py
+++ b/src/config/config_service.py
@@ -2,8 +2,7 @@
 import logging
 import os
 import re
-from collections import namedtuple
-from typing import List, Union
+from typing import List, NamedTuple, Union
 
 from auth.authorization import Authorizer
 from config.exceptions import InvalidConfigException
@@ -23,7 +22,10 @@
 
 LOGGER = logging.getLogger('config_service')
 
-ConfigSearchResult = namedtuple('ConfigSearchResult', ['short_config', 'path', 'config_object'])
+class ConfigSearchResult(NamedTuple):
+    short_config: ShortConfig
+    path: str
+    config_object: any
 
 
 def _script_name_to_file_name(script_name):
@@ -59,6 +61,9 @@ def load_config(self, name, user):
         if search_result is None:
             return None
 
+        if(search_result.short_config.parsing_failed == True):
+            raise BadConfigFileException()
+
         (short_config, path, config_object) = search_result
 
         if config_object.get('name') is None:
@@ -191,12 +196,13 @@ def load_script(path, content) -> ShortConfig:
                     return None
 
                 return short_config
-            except:
-                LOGGER.exception('Could not load script: ' + path)
+            except json.decoder.JSONDecodeError:
                 failed_short_config = ShortConfig()
                 failed_short_config.name = path
                 failed_short_config.parsing_failed = True
                 return failed_short_config
+            except Exception:
+                LOGGER.exception('Could not load script: ' + path)
 
         return self._visit_script_configs(load_script)
 
@@ -206,6 +212,9 @@ def load_config_model(self, name, user, parameter_values=None, skip_invalid_para
         if search_result is None:
             return None
 
+        if(search_result.short_config.parsing_failed == True):
+          raise BadConfigFileException()
+
         (short_config, path, config_object) = search_result
 
         if not self._can_access_script(user, short_config):
@@ -240,15 +249,23 @@ def _visit_script_configs(self, visitor) -> List[ ShortConfig ]:
 
         return result
 
-    def _find_config(self, name) -> Union[ConfigSearchResult, None]:
-        def find_and_load(path, content):
+    def _find_config(self, name) -> Union[ ConfigSearchResult , None]:
+        def find_and_load(path: str, content):
             try:
                 config_object = self.load_config_file(path, content)
                 short_config = script_config.read_short(path, config_object)
 
                 if short_config is None:
                     return None
-            except:
+            except json.decoder.JSONDecodeError:
+                if name == path:
+                  failed_short_config = ShortConfig()
+                  failed_short_config.name = path
+                  failed_short_config.parsing_failed = True
+                  raise StopIteration(ConfigSearchResult(failed_short_config, path, None))
+                else:
+                  return None
+            except Exception:
                 LOGGER.exception('Could not load script config: ' + path)
                 return None
 
@@ -368,3 +385,10 @@ def __init__(self, message):
 class InvalidAccessException(Exception):
     def __init__(self, message=None):
         super().__init__(message)
+
+
+class BadConfigFileException(Exception):
+    HTTP_CODE = 422
+    VERBOSE_ERROR = 'Cannot parse script config file'
+    def __init__(self, message=None):
+        super().__init__(message)
diff --git a/src/web/script_config_socket.py b/src/web/script_config_socket.py
index d02ab0f6..b3849ba0 100644
--- a/src/web/script_config_socket.py
+++ b/src/web/script_config_socket.py
@@ -13,7 +13,7 @@
 from tornado import gen
 
 from auth.user import User
-from config.config_service import ConfigNotAllowedException
+from config.config_service import ConfigNotAllowedException, BadConfigFileException
 from model import external_model
 from model.external_model import parameter_to_external
 from model.model_helper import read_bool
@@ -184,6 +184,9 @@ def load_model():
         except ConfigNotAllowedException:
             self.close(code=403, reason='Access to the script is denied')
             return None
+        except BadConfigFileException:
+            self.close(code=422, reason=BadConfigFileException.VERBOSE_ERROR)
+            return None
         except Exception:
             message = 'Failed to load script config ' + config_name
             LOGGER.exception(message)
diff --git a/src/web/server.py b/src/web/server.py
index 60684f9e..f2970952 100755
--- a/src/web/server.py
+++ b/src/web/server.py
@@ -20,7 +20,7 @@
 from auth.identification import AuthBasedIdentification, IpBasedIdentification
 from auth.tornado_auth import TornadoAuth
 from communications.alerts_service import AlertsService
-from config.config_service import ConfigService, ConfigNotAllowedException, InvalidAccessException
+from config.config_service import ConfigService, ConfigNotAllowedException, InvalidAccessException, BadConfigFileException
 from config.exceptions import InvalidConfigException
 from execution.execution_service import ExecutionService
 from execution.logging import ExecutionLoggingService
@@ -191,6 +191,10 @@ def get(self, user, script_name):
             LOGGER.warning('Admin access to the script "' + script_name + '" is denied for ' + user.get_audit_name())
             respond_error(self, 403, 'Access to the script is denied')
             return
+        except BadConfigFileException:
+            LOGGER.warning(BadConfigFileException.VERBOSE_ERROR + ' : ' + script_name)
+            respond_error(self, 422, BadConfigFileException.VERBOSE_ERROR)
+            return
 
         if config is None:
             raise tornado.web.HTTPError(404, str('Failed to find config for name: ' + script_name))
@@ -401,6 +405,11 @@ def post(self, user):
             respond_error(self, 403, 'Access to the script is denied')
             return
 
+        except BadConfigFileException:
+            LOGGER.warning(BadConfigFileException.VERBOSE_ERROR + ' : ' + script_name)
+            respond_error(self, 422, BadConfigFileException.VERBOSE_ERROR)
+            return None
+
         except Exception as e:
             LOGGER.exception("Error while calling the script")
 

From 6d6e8f8804796e5c00fe6c78363060ac0e33fd49 Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Mon, 17 Oct 2022 07:13:39 +0300
Subject: [PATCH 13/27] (frontend) added processing of code 422 in main block

---
 .../src/main-app/components/scripts/MainAppContent.vue   | 8 +++++++-
 web-src/src/main-app/store/scriptConfig.js               | 9 ++++++++-
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/web-src/src/main-app/components/scripts/MainAppContent.vue b/web-src/src/main-app/components/scripts/MainAppContent.vue
index 38d5f8e4..09b25235 100644
--- a/web-src/src/main-app/components/scripts/MainAppContent.vue
+++ b/web-src/src/main-app/components/scripts/MainAppContent.vue
@@ -9,6 +9,9 @@
       <p v-else-if="scriptLoadError && notFound">
         Failed to load script info: script '{{ selectedScript }}' not found
       </p>
+      <p v-else-if="scriptLoadError && cannotParse">
+        Cannot parse script config file
+      </p>
       <p v-else-if="scriptLoadError">
         Failed to load script info. Try to reload the page. Error message:
         <br>
@@ -21,7 +24,7 @@
 <script>
 import {isEmptyString} from '@/common/utils/common';
 import {mapActions, mapState} from 'vuex';
-import {NOT_FOUND_ERROR_PREFIX} from '../../store/scriptConfig';
+import {NOT_FOUND_ERROR_PREFIX, CANNOT_PARSE_ERROR_PREFIX} from '../../store/scriptConfig';
 import ScriptView from './script-view';
 
 export default {
@@ -35,6 +38,9 @@ export default {
     notFound() {
       return !isEmptyString(this.scriptLoadError) && this.scriptLoadError.startsWith(NOT_FOUND_ERROR_PREFIX);
     },
+    cannotParse() {
+      return !isEmptyString(this.scriptLoadError) && this.scriptLoadError.startsWith(CANNOT_PARSE_ERROR_PREFIX); 
+    },
     ...mapState('auth', ['authenticated']),
     ...mapState('scriptConfig', {scriptLoadError: 'loadError', loading: 'loading'}),
     ...mapState('scripts', ['selectedScript'])
diff --git a/web-src/src/main-app/store/scriptConfig.js b/web-src/src/main-app/store/scriptConfig.js
index 61a76229..fd85fc4f 100644
--- a/web-src/src/main-app/store/scriptConfig.js
+++ b/web-src/src/main-app/store/scriptConfig.js
@@ -51,6 +51,7 @@ function sendReloadModelRequest(parameterValues, clientModelId, websocket, newSt
 }
 
 export const NOT_FOUND_ERROR_PREFIX = `Failed to find the script`;
+export const CANNOT_PARSE_ERROR_PREFIX = `Cannot parse script config file`;
 
 export default () => ({
     state: {
@@ -333,8 +334,14 @@ function reconnect(state, internalState, commit, dispatch, selectedScript) {
             logError(error);
 
             if (error instanceof SocketClosedError) {
+              
+                if (error.code === 422) {
+                  commit('SET_ERROR', `${CANNOT_PARSE_ERROR_PREFIX} "${selectedScript}"`);
+                  return;
+                }
+                
                 console.log('Socket closed. code=' + error.code + ', reason=' + error.reason);
-
+              
                 if (isNull(state.scriptConfig)) {
                     commit('SET_ERROR', 'Failed to connect to the server');
                     return;

From 47a80ce2debed6eef4789c2f1f3c33bf7723052e Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Mon, 17 Oct 2022 07:53:38 +0300
Subject: [PATCH 14/27] (frontend) added parsingFailed flag in ScriptsList.vue

---
 .../admin/components/scripts-config/ScriptsList.vue  | 12 +++++++++++-
 web-src/src/admin/store/scripts-module.js            |  6 +++---
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/web-src/src/admin/components/scripts-config/ScriptsList.vue b/web-src/src/admin/components/scripts-config/ScriptsList.vue
index 4e2418fc..046727a5 100644
--- a/web-src/src/admin/components/scripts-config/ScriptsList.vue
+++ b/web-src/src/admin/components/scripts-config/ScriptsList.vue
@@ -8,6 +8,7 @@
       </router-link>
       <div class="collection">
         <router-link v-for="script in scripts" :key="script.name" :to="script.path" append
+                     v-bind:class="{'parsing-failed': script.parsingFailed}"
                      class="collection-item">
           {{ script.name }}
         </router-link>
@@ -37,7 +38,7 @@ export default {
   computed: {
     ...mapState('scripts', {
       scripts: state => {
-        return state.scripts ? state.scripts.map(s => ({name: s, path: encodeURIComponent(s)})) : []
+        return state.scripts ? state.scripts.map(s => ({name: s.name, path: encodeURIComponent(s.name), parsingFailed: s.parsingFailed})) : []
       },
       loading: 'loading'
     })
@@ -62,4 +63,13 @@ export default {
 .add-script-btn {
   margin-bottom: 1em;
 }
+
+.scripts-list .collection-item.parsing-failed {
+  color: var(--error-color);
+  /* I didn't find any good ways to disable a <router-link> */
+  pointer-events: none;
+}
+.scripts-list .collection-item.parsing-failed::before {
+  content: "Could not read config file: ";
+}
 </style>
\ No newline at end of file
diff --git a/web-src/src/admin/store/scripts-module.js b/web-src/src/admin/store/scripts-module.js
index 7b9fc46d..f8884dac 100644
--- a/web-src/src/admin/store/scripts-module.js
+++ b/web-src/src/admin/store/scripts-module.js
@@ -12,9 +12,9 @@ export default {
 
             axiosInstance.get('scripts', {params: {mode: 'edit'}}).then(({data}) => {
                 const {scripts} = data;
-                let scriptNames = scripts.map(s => s.name);
-                scriptNames.sort(function (name1, name2) {
-                    return name1.toLowerCase().localeCompare(name2.toLowerCase());
+                let scriptNames = scripts.map(s => ({ name: s.name, parsingFailed: s.parsing_failed }));
+                scriptNames.sort(function (e1, e2) {
+                    return e1.name.toLowerCase().localeCompare(e2.name.toLowerCase());
                 });
 
                 commit('SET_SCRIPTS', scriptNames);

From a3837045f91a8af38ada6a47a5b2e2155678a8f2 Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Mon, 17 Oct 2022 08:08:36 +0300
Subject: [PATCH 15/27] (frontend) altered v-for in ScriptsList.vue for (maybe)
 cleaner disabled link implementation

---
 .../components/scripts-config/ScriptsList.vue | 23 ++++++++++++++-----
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/web-src/src/admin/components/scripts-config/ScriptsList.vue b/web-src/src/admin/components/scripts-config/ScriptsList.vue
index 046727a5..9bf4d177 100644
--- a/web-src/src/admin/components/scripts-config/ScriptsList.vue
+++ b/web-src/src/admin/components/scripts-config/ScriptsList.vue
@@ -7,11 +7,22 @@
         Add
       </router-link>
       <div class="collection">
-        <router-link v-for="script in scripts" :key="script.name" :to="script.path" append
-                     v-bind:class="{'parsing-failed': script.parsingFailed}"
-                     class="collection-item">
-          {{ script.name }}
-        </router-link>
+
+        <template v-for="script in scripts" >
+          <router-link :to="script.path" append
+                       :key="script.name" 
+                       v-if="!script.parsingFailed"
+                       class="collection-item">
+            {{ script.name }}
+          </router-link>
+          
+          <div v-else class="collection-item parsing-failed">
+            <code>
+              {{ script.name }}
+            </code>
+          </div>
+        </template>
+
       </div>
     </div>
   </div>
@@ -67,7 +78,7 @@ export default {
 .scripts-list .collection-item.parsing-failed {
   color: var(--error-color);
   /* I didn't find any good ways to disable a <router-link> */
-  pointer-events: none;
+  /* pointer-events: none; */
 }
 .scripts-list .collection-item.parsing-failed::before {
   content: "Could not read config file: ";

From 973af0a9ddcdbf39d6c27f5e6d59064ed43f82e1 Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Sun, 23 Oct 2022 00:49:15 +0300
Subject: [PATCH 16/27] added "file with possibly restricted access" check

---
 src/config/config_service.py | 10 +++-------
 src/model/script_config.py   |  9 +++++++++
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/src/config/config_service.py b/src/config/config_service.py
index b93a99f2..0b30f884 100644
--- a/src/config/config_service.py
+++ b/src/config/config_service.py
@@ -8,7 +8,7 @@
 from config.exceptions import InvalidConfigException
 from model import script_config
 from model.model_helper import InvalidFileException
-from model.script_config import get_sorted_config, ShortConfig
+from model.script_config import get_sorted_config, ShortConfig, create_failed_ShortConfig
 from utils import os_utils, file_utils, process_utils, custom_json, custom_yaml
 from utils.file_utils import to_filename
 from utils.string_utils import is_blank, strip
@@ -197,9 +197,7 @@ def load_script(path, content) -> ShortConfig:
 
                 return short_config
             except json.decoder.JSONDecodeError:
-                failed_short_config = ShortConfig()
-                failed_short_config.name = path
-                failed_short_config.parsing_failed = True
+                failed_short_config = create_failed_ShortConfig(path)
                 return failed_short_config
             except Exception:
                 LOGGER.exception('Could not load script: ' + path)
@@ -259,9 +257,7 @@ def find_and_load(path: str, content):
                     return None
             except json.decoder.JSONDecodeError:
                 if name == path:
-                  failed_short_config = ShortConfig()
-                  failed_short_config.name = path
-                  failed_short_config.parsing_failed = True
+                  failed_short_config = create_failed_ShortConfig(path)
                   raise StopIteration(ConfigSearchResult(failed_short_config, path, None))
                 else:
                   return None
diff --git a/src/model/script_config.py b/src/model/script_config.py
index f1ff0773..34091dfe 100644
--- a/src/model/script_config.py
+++ b/src/model/script_config.py
@@ -29,6 +29,15 @@ def __init__(self):
         self.group = None
         self.parsing_failed = False
 
+def create_failed_ShortConfig(path):
+    failed_short_config = ShortConfig()
+    failed_short_config.name = path
+    with open(path) as f:
+      if '"allowed_users"' in f.read():
+          failed_short_config.name = 'file with possibly restricted access'
+    failed_short_config.parsing_failed = True
+    return failed_short_config
+
 @observable_fields(
     'script_command',
     'description',

From 56be44d6b3b963cfb51e627cb038ad2eefc17c11 Mon Sep 17 00:00:00 2001
From: RollingHog <mpaushev2@mail.ru>
Date: Tue, 25 Oct 2022 00:44:11 +0300
Subject: [PATCH 17/27] naming convention create_failed_short_config

---
 src/config/config_service.py | 6 +++---
 src/model/script_config.py   | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/config/config_service.py b/src/config/config_service.py
index 0b30f884..216880f0 100644
--- a/src/config/config_service.py
+++ b/src/config/config_service.py
@@ -8,7 +8,7 @@
 from config.exceptions import InvalidConfigException
 from model import script_config
 from model.model_helper import InvalidFileException
-from model.script_config import get_sorted_config, ShortConfig, create_failed_ShortConfig
+from model.script_config import get_sorted_config, ShortConfig, create_failed_short_config
 from utils import os_utils, file_utils, process_utils, custom_json, custom_yaml
 from utils.file_utils import to_filename
 from utils.string_utils import is_blank, strip
@@ -197,7 +197,7 @@ def load_script(path, content) -> ShortConfig:
 
                 return short_config
             except json.decoder.JSONDecodeError:
-                failed_short_config = create_failed_ShortConfig(path)
+                failed_short_config = create_failed_short_config(path)
                 return failed_short_config
             except Exception:
                 LOGGER.exception('Could not load script: ' + path)
@@ -257,7 +257,7 @@ def find_and_load(path: str, content):
                     return None
             except json.decoder.JSONDecodeError:
                 if name == path:
-                  failed_short_config = create_failed_ShortConfig(path)
+                  failed_short_config = create_failed_short_config(path)
                   raise StopIteration(ConfigSearchResult(failed_short_config, path, None))
                 else:
                   return None
diff --git a/src/model/script_config.py b/src/model/script_config.py
index 34091dfe..21e34200 100644
--- a/src/model/script_config.py
+++ b/src/model/script_config.py
@@ -29,7 +29,7 @@ def __init__(self):
         self.group = None
         self.parsing_failed = False
 
-def create_failed_ShortConfig(path):
+def create_failed_short_config(path):
     failed_short_config = ShortConfig()
     failed_short_config.name = path
     with open(path) as f:

From 3d533b0c15bd3ff74404c230feeac78010d007e7 Mon Sep 17 00:00:00 2001
From: RollingHog <mpaushev2@mail.ru>
Date: Tue, 25 Oct 2022 01:07:03 +0300
Subject: [PATCH 18/27] added usage of BadConfigFileException.HTTP_CODE

---
 src/web/script_config_socket.py | 2 +-
 src/web/server.py               | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/web/script_config_socket.py b/src/web/script_config_socket.py
index b3849ba0..eaef18f1 100644
--- a/src/web/script_config_socket.py
+++ b/src/web/script_config_socket.py
@@ -185,7 +185,7 @@ def load_model():
             self.close(code=403, reason='Access to the script is denied')
             return None
         except BadConfigFileException:
-            self.close(code=422, reason=BadConfigFileException.VERBOSE_ERROR)
+            self.close(code=BadConfigFileException.HTTP_CODE, reason=BadConfigFileException.VERBOSE_ERROR)
             return None
         except Exception:
             message = 'Failed to load script config ' + config_name
diff --git a/src/web/server.py b/src/web/server.py
index f2970952..dbb0d191 100755
--- a/src/web/server.py
+++ b/src/web/server.py
@@ -193,7 +193,7 @@ def get(self, user, script_name):
             return
         except BadConfigFileException:
             LOGGER.warning(BadConfigFileException.VERBOSE_ERROR + ' : ' + script_name)
-            respond_error(self, 422, BadConfigFileException.VERBOSE_ERROR)
+            respond_error(self, BadConfigFileException.HTTP_CODE, BadConfigFileException.VERBOSE_ERROR)
             return
 
         if config is None:

From eba68ce69b966c1aee9280da2c268ad288240162 Mon Sep 17 00:00:00 2001
From: RollingHog <mpaushev2@mail.ru>
Date: Tue, 25 Oct 2022 01:16:30 +0300
Subject: [PATCH 19/27] Update config_service.py

---
 src/config/config_service.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/config/config_service.py b/src/config/config_service.py
index 216880f0..d3ab618a 100644
--- a/src/config/config_service.py
+++ b/src/config/config_service.py
@@ -197,6 +197,7 @@ def load_script(path, content) -> ShortConfig:
 
                 return short_config
             except json.decoder.JSONDecodeError:
+                LOGGER.exception(BadConfigFileException.VERBOSE_ERROR + ' : ' + path)
                 failed_short_config = create_failed_short_config(path)
                 return failed_short_config
             except Exception:

From 1747d30d7a7352cfb6864c5084c3f819c7bed04b Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Wed, 2 Nov 2022 04:44:57 +0300
Subject: [PATCH 20/27] removed some ScriptListItem.vue comments

---
 .../src/main-app/components/scripts/ScriptListItem.vue   | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/web-src/src/main-app/components/scripts/ScriptListItem.vue b/web-src/src/main-app/components/scripts/ScriptListItem.vue
index 074fe385..c1d1ba2f 100644
--- a/web-src/src/main-app/components/scripts/ScriptListItem.vue
+++ b/web-src/src/main-app/components/scripts/ScriptListItem.vue
@@ -110,8 +110,6 @@ export default {
   display: inline;
 }
 
-/* state: executing */
-
 .scripts-list .collection-item .menu-item-state.executing > .check-icon,
 .scripts-list .collection-item .menu-item-state.executing > .failed-icon {
   display: none;
@@ -121,8 +119,6 @@ export default {
   display: block;
 }
 
-/* state: finished */
-
 .scripts-list .collection-item .menu-item-state.finished > .check-icon {
   display: block;
 }
@@ -132,10 +128,7 @@ export default {
   display: none;
 }
 
-/* state: cannot-parse */
-
-.scripts-list .collection-item .menu-item-state.cannot-parse > .check-icon,
-.scripts-list .collection-item .menu-item-state.cannot-parse > .preloader-wrapper {
+.scripts-list .collection-item .menu-item-state.cannot-parse > .check-icon {
   display: none;
 }
 

From c0c92a40c7a1e61730f6280cc4873df789df099f Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Wed, 2 Nov 2022 04:48:50 +0300
Subject: [PATCH 21/27] Update
 web-src/src/admin/components/scripts-config/ScriptsList.vue

Co-authored-by: Iaroslav Shepilov <buggygm@gmail.com>
---
 .../src/admin/components/scripts-config/ScriptsList.vue    | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/web-src/src/admin/components/scripts-config/ScriptsList.vue b/web-src/src/admin/components/scripts-config/ScriptsList.vue
index 9bf4d177..4c82e18b 100644
--- a/web-src/src/admin/components/scripts-config/ScriptsList.vue
+++ b/web-src/src/admin/components/scripts-config/ScriptsList.vue
@@ -49,7 +49,12 @@ export default {
   computed: {
     ...mapState('scripts', {
       scripts: state => {
-        return state.scripts ? state.scripts.map(s => ({name: s.name, path: encodeURIComponent(s.name), parsingFailed: s.parsingFailed})) : []
+        return state.scripts ? state.scripts.map(s => ({
+              name: s.name, 
+              path: encodeURIComponent(s.name), 
+              parsingFailed: s.parsingFailed
+              })) 
+              : []
       },
       loading: 'loading'
     })

From bd7b49d4c5d8c9007e73bcec16bc32bd52a73ac4 Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Wed, 2 Nov 2022 04:52:25 +0300
Subject: [PATCH 22/27] Update
 web-src/src/main-app/components/scripts/ScriptListItem.vue

Co-authored-by: Iaroslav Shepilov <buggygm@gmail.com>
---
 web-src/src/main-app/components/scripts/ScriptListItem.vue | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/web-src/src/main-app/components/scripts/ScriptListItem.vue b/web-src/src/main-app/components/scripts/ScriptListItem.vue
index c1d1ba2f..60ae3352 100644
--- a/web-src/src/main-app/components/scripts/ScriptListItem.vue
+++ b/web-src/src/main-app/components/scripts/ScriptListItem.vue
@@ -55,7 +55,9 @@ export default {
     getState(scriptName) {
       let state = 'idle';
 
-      if(this.script.parsing_failed) return 'cannot-parse'
+      if(this.script.parsing_failed) {
+        return 'cannot-parse'
+      }
 
       forEachKeyValue(this.$store.state.executions.executors, function (id, executor) {
         if (executor.state.scriptName !== scriptName) {

From 3521277c9b0a1905eb4e9df91005d7b7c3871d6f Mon Sep 17 00:00:00 2001
From: RollingHog <46373241+RollingHog@users.noreply.github.com>
Date: Wed, 2 Nov 2022 05:12:24 +0300
Subject: [PATCH 23/27] added path hash to failed_short_config to avoid name
 duplication

---
 src/model/script_config.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/model/script_config.py b/src/model/script_config.py
index 21e34200..6d384678 100644
--- a/src/model/script_config.py
+++ b/src/model/script_config.py
@@ -34,7 +34,7 @@ def create_failed_short_config(path):
     failed_short_config.name = path
     with open(path) as f:
       if '"allowed_users"' in f.read():
-          failed_short_config.name = 'file with possibly restricted access'
+          failed_short_config.name = 'file with possibly restricted access (path hash ' + hex(hash(path)) + ')'
     failed_short_config.parsing_failed = True
     return failed_short_config
 

From ee2a1fe861d279aa7cbadbea12ff4bdd0ec2ad4d Mon Sep 17 00:00:00 2001
From: yshepilov <buggygm@gmail.com>
Date: Sat, 5 Nov 2022 17:34:41 +0100
Subject: [PATCH 24/27] #586 made some code review fixes for failed parsing
 feature

---
 src/config/config_service.py                  | 45 +++++++++----------
 src/model/script_config.py                    | 23 +++++++---
 src/web/script_config_socket.py               |  6 +--
 src/web/server.py                             | 15 +++----
 .../components/scripts-config/ScriptsList.vue | 35 +++++++--------
 web-src/src/admin/store/scripts-module.js     |  6 +--
 .../components/scripts/MainAppContent.vue     |  4 +-
 .../components/scripts/ScriptListItem.vue     | 27 ++++-------
 web-src/src/main-app/store/scriptConfig.js    |  8 ++--
 9 files changed, 82 insertions(+), 87 deletions(-)

diff --git a/src/config/config_service.py b/src/config/config_service.py
index d3ab618a..fba4305d 100644
--- a/src/config/config_service.py
+++ b/src/config/config_service.py
@@ -2,7 +2,7 @@
 import logging
 import os
 import re
-from typing import List, NamedTuple, Union
+from typing import NamedTuple, Optional
 
 from auth.authorization import Authorizer
 from config.exceptions import InvalidConfigException
@@ -61,9 +61,6 @@ def load_config(self, name, user):
         if search_result is None:
             return None
 
-        if(search_result.short_config.parsing_failed == True):
-            raise BadConfigFileException()
-
         (short_config, path, config_object) = search_result
 
         if config_object.get('name') is None:
@@ -165,13 +162,13 @@ def _save_config(self, config, path):
         sorted_config = get_sorted_config(config)
         config_json = json.dumps(sorted_config, indent=2)
         file_utils.write_file(path, config_json)
-        
+
     def load_config_file(self, path, content):
         if path.endswith('.yaml'):
             config_object = custom_yaml.loads(content)
-        else:            
+        else:
             config_object = custom_json.loads(content)
-            
+
         return config_object
 
     def list_configs(self, user, mode=None):
@@ -181,7 +178,7 @@ def list_configs(self, user, mode=None):
 
         conf_service = self
 
-        def load_script(path, content) -> ShortConfig:
+        def load_script(path, content) -> Optional[ShortConfig]:
             try:
                 config_object = self.load_config_file(path, content)
                 short_config = script_config.read_short(path, config_object)
@@ -197,9 +194,8 @@ def load_script(path, content) -> ShortConfig:
 
                 return short_config
             except json.decoder.JSONDecodeError:
-                LOGGER.exception(BadConfigFileException.VERBOSE_ERROR + ' : ' + path)
-                failed_short_config = create_failed_short_config(path)
-                return failed_short_config
+                LOGGER.exception(CorruptConfigFileException.VERBOSE_ERROR + ': ' + path)
+                return create_failed_short_config(path)
             except Exception:
                 LOGGER.exception('Could not load script: ' + path)
 
@@ -211,9 +207,6 @@ def load_config_model(self, name, user, parameter_values=None, skip_invalid_para
         if search_result is None:
             return None
 
-        if(search_result.short_config.parsing_failed == True):
-          raise BadConfigFileException()
-
         (short_config, path, config_object) = search_result
 
         if not self._can_access_script(user, short_config):
@@ -221,7 +214,7 @@ def load_config_model(self, name, user, parameter_values=None, skip_invalid_para
 
         return self._load_script_config(path, config_object, user, parameter_values, skip_invalid_parameters)
 
-    def _visit_script_configs(self, visitor) -> List[ ShortConfig ]:
+    def _visit_script_configs(self, visitor):
         configs_dir = self._script_configs_folder
         files = os.listdir(configs_dir)
 
@@ -248,7 +241,7 @@ def _visit_script_configs(self, visitor) -> List[ ShortConfig ]:
 
         return result
 
-    def _find_config(self, name) -> Union[ ConfigSearchResult , None]:
+    def _find_config(self, name) -> Optional[ConfigSearchResult]:
         def find_and_load(path: str, content):
             try:
                 config_object = self.load_config_file(path, content)
@@ -257,11 +250,9 @@ def find_and_load(path: str, content):
                 if short_config is None:
                     return None
             except json.decoder.JSONDecodeError:
-                if name == path:
-                  failed_short_config = create_failed_short_config(path)
-                  raise StopIteration(ConfigSearchResult(failed_short_config, path, None))
-                else:
-                  return None
+                short_config = create_failed_short_config(path)
+                config_object = None
+
             except Exception:
                 LOGGER.exception('Could not load script config: ' + path)
                 return None
@@ -275,7 +266,12 @@ def find_and_load(path: str, content):
         if not configs:
             return None
 
-        return configs[0]
+        found_config = configs[0]
+
+        if found_config.short_config.parsing_failed:
+            raise CorruptConfigFileException()
+
+        return found_config
 
     @staticmethod
     def _load_script_config(path, content_or_json_dict, user, parameter_values, skip_invalid_parameters):
@@ -384,8 +380,9 @@ def __init__(self, message=None):
         super().__init__(message)
 
 
-class BadConfigFileException(Exception):
+class CorruptConfigFileException(Exception):
     HTTP_CODE = 422
     VERBOSE_ERROR = 'Cannot parse script config file'
-    def __init__(self, message=None):
+
+    def __init__(self, message=VERBOSE_ERROR):
         super().__init__(message)
diff --git a/src/model/script_config.py b/src/model/script_config.py
index 6d384678..381a84f9 100644
--- a/src/model/script_config.py
+++ b/src/model/script_config.py
@@ -29,15 +29,21 @@ def __init__(self):
         self.group = None
         self.parsing_failed = False
 
+
 def create_failed_short_config(path):
     failed_short_config = ShortConfig()
-    failed_short_config.name = path
-    with open(path) as f:
-      if '"allowed_users"' in f.read():
-          failed_short_config.name = 'file with possibly restricted access (path hash ' + hex(hash(path)) + ')'
+    name = _build_name_from_path(path)
+    failed_short_config.name = name
     failed_short_config.parsing_failed = True
+
+    file_content = file_utils.read_file(path)
+    if '"allowed_users"' in file_content:
+        restricted_name = name[:2] + '...' + name[-2:]
+        failed_short_config.name = restricted_name + ' (restricted)'
+
     return failed_short_config
 
+
 @observable_fields(
     'script_command',
     'description',
@@ -270,9 +276,14 @@ def _path_to_json(self, path):
 def _read_name(file_path, json_object):
     name = json_object.get('name')
     if not name:
-        filename = os.path.basename(file_path)
-        name = os.path.splitext(filename)[0]
+        name = _build_name_from_path(file_path)
+
+    return name.strip()
+
 
+def _build_name_from_path(file_path):
+    filename = os.path.basename(file_path)
+    name = os.path.splitext(filename)[0]
     return name.strip()
 
 
diff --git a/src/web/script_config_socket.py b/src/web/script_config_socket.py
index eaef18f1..40009566 100644
--- a/src/web/script_config_socket.py
+++ b/src/web/script_config_socket.py
@@ -13,7 +13,7 @@
 from tornado import gen
 
 from auth.user import User
-from config.config_service import ConfigNotAllowedException, BadConfigFileException
+from config.config_service import ConfigNotAllowedException, CorruptConfigFileException
 from model import external_model
 from model.external_model import parameter_to_external
 from model.model_helper import read_bool
@@ -184,8 +184,8 @@ def load_model():
         except ConfigNotAllowedException:
             self.close(code=403, reason='Access to the script is denied')
             return None
-        except BadConfigFileException:
-            self.close(code=BadConfigFileException.HTTP_CODE, reason=BadConfigFileException.VERBOSE_ERROR)
+        except CorruptConfigFileException as e:
+            self.close(code=CorruptConfigFileException.HTTP_CODE, reason=str(e))
             return None
         except Exception:
             message = 'Failed to load script config ' + config_name
diff --git a/src/web/server.py b/src/web/server.py
index dbb0d191..f550529d 100755
--- a/src/web/server.py
+++ b/src/web/server.py
@@ -20,7 +20,8 @@
 from auth.identification import AuthBasedIdentification, IpBasedIdentification
 from auth.tornado_auth import TornadoAuth
 from communications.alerts_service import AlertsService
-from config.config_service import ConfigService, ConfigNotAllowedException, InvalidAccessException, BadConfigFileException
+from config.config_service import ConfigService, ConfigNotAllowedException, InvalidAccessException, \
+    CorruptConfigFileException
 from config.exceptions import InvalidConfigException
 from execution.execution_service import ExecutionService
 from execution.logging import ExecutionLoggingService
@@ -137,7 +138,7 @@ def get(self, user):
 
         configs = self.application.config_service.list_configs(user, mode)
 
-        scripts = [{'name': conf.name, 'group': conf.group, 'parsing_failed': conf.parsing_failed } for conf in configs]
+        scripts = [{'name': conf.name, 'group': conf.group, 'parsing_failed': conf.parsing_failed} for conf in configs]
 
         self.write(json.dumps({'scripts': scripts}))
 
@@ -191,9 +192,8 @@ def get(self, user, script_name):
             LOGGER.warning('Admin access to the script "' + script_name + '" is denied for ' + user.get_audit_name())
             respond_error(self, 403, 'Access to the script is denied')
             return
-        except BadConfigFileException:
-            LOGGER.warning(BadConfigFileException.VERBOSE_ERROR + ' : ' + script_name)
-            respond_error(self, BadConfigFileException.HTTP_CODE, BadConfigFileException.VERBOSE_ERROR)
+        except CorruptConfigFileException as e:
+            respond_error(self, CorruptConfigFileException.HTTP_CODE, str(e))
             return
 
         if config is None:
@@ -405,9 +405,8 @@ def post(self, user):
             respond_error(self, 403, 'Access to the script is denied')
             return
 
-        except BadConfigFileException:
-            LOGGER.warning(BadConfigFileException.VERBOSE_ERROR + ' : ' + script_name)
-            respond_error(self, 422, BadConfigFileException.VERBOSE_ERROR)
+        except CorruptConfigFileException as e:
+            respond_error(self, CorruptConfigFileException.HTTP_CODE, str(e))
             return None
 
         except Exception as e:
diff --git a/web-src/src/admin/components/scripts-config/ScriptsList.vue b/web-src/src/admin/components/scripts-config/ScriptsList.vue
index 4c82e18b..4a05440b 100644
--- a/web-src/src/admin/components/scripts-config/ScriptsList.vue
+++ b/web-src/src/admin/components/scripts-config/ScriptsList.vue
@@ -8,19 +8,14 @@
       </router-link>
       <div class="collection">
 
-        <template v-for="script in scripts" >
-          <router-link :to="script.path" append
-                       :key="script.name" 
-                       v-if="!script.parsingFailed"
+        <template v-for="script in scripts">
+          <router-link :key="script.name"
+                       :class="{'parsing-failed': script.parsingFailed}"
+                       :to="script.path"
+                       append
                        class="collection-item">
             {{ script.name }}
           </router-link>
-          
-          <div v-else class="collection-item parsing-failed">
-            <code>
-              {{ script.name }}
-            </code>
-          </div>
         </template>
 
       </div>
@@ -49,12 +44,13 @@ export default {
   computed: {
     ...mapState('scripts', {
       scripts: state => {
-        return state.scripts ? state.scripts.map(s => ({
-              name: s.name, 
-              path: encodeURIComponent(s.name), 
+        return state.scripts
+            ? state.scripts.map(s => ({
+              name: s.name,
+              path: encodeURIComponent(s.name),
               parsingFailed: s.parsingFailed
-              })) 
-              : []
+            }))
+            : []
       },
       loading: 'loading'
     })
@@ -82,10 +78,11 @@ export default {
 
 .scripts-list .collection-item.parsing-failed {
   color: var(--error-color);
-  /* I didn't find any good ways to disable a <router-link> */
-  /* pointer-events: none; */
+  pointer-events: none;
 }
-.scripts-list .collection-item.parsing-failed::before {
-  content: "Could not read config file: ";
+
+.scripts-list .collection-item.parsing-failed::after {
+  content: '(failed to parse config file)';
 }
+
 </style>
\ No newline at end of file
diff --git a/web-src/src/admin/store/scripts-module.js b/web-src/src/admin/store/scripts-module.js
index f8884dac..07e913f8 100644
--- a/web-src/src/admin/store/scripts-module.js
+++ b/web-src/src/admin/store/scripts-module.js
@@ -12,12 +12,12 @@ export default {
 
             axiosInstance.get('scripts', {params: {mode: 'edit'}}).then(({data}) => {
                 const {scripts} = data;
-                let scriptNames = scripts.map(s => ({ name: s.name, parsingFailed: s.parsing_failed }));
-                scriptNames.sort(function (e1, e2) {
+                let scriptConfigs = scripts.map(s => ({name: s.name, parsingFailed: s.parsing_failed}));
+                scriptConfigs.sort(function (e1, e2) {
                     return e1.name.toLowerCase().localeCompare(e2.name.toLowerCase());
                 });
 
-                commit('SET_SCRIPTS', scriptNames);
+                commit('SET_SCRIPTS', scriptConfigs);
                 commit('SET_LOADING', false);
             })
         }
diff --git a/web-src/src/main-app/components/scripts/MainAppContent.vue b/web-src/src/main-app/components/scripts/MainAppContent.vue
index 09b25235..8d2ea649 100644
--- a/web-src/src/main-app/components/scripts/MainAppContent.vue
+++ b/web-src/src/main-app/components/scripts/MainAppContent.vue
@@ -10,7 +10,7 @@
         Failed to load script info: script '{{ selectedScript }}' not found
       </p>
       <p v-else-if="scriptLoadError && cannotParse">
-        Cannot parse script config file
+        Cannot parse script config file, please contact the administrator
       </p>
       <p v-else-if="scriptLoadError">
         Failed to load script info. Try to reload the page. Error message:
@@ -24,7 +24,7 @@
 <script>
 import {isEmptyString} from '@/common/utils/common';
 import {mapActions, mapState} from 'vuex';
-import {NOT_FOUND_ERROR_PREFIX, CANNOT_PARSE_ERROR_PREFIX} from '../../store/scriptConfig';
+import {CANNOT_PARSE_ERROR_PREFIX, NOT_FOUND_ERROR_PREFIX} from '../../store/scriptConfig';
 import ScriptView from './script-view';
 
 export default {
diff --git a/web-src/src/main-app/components/scripts/ScriptListItem.vue b/web-src/src/main-app/components/scripts/ScriptListItem.vue
index 60ae3352..3d3b9f39 100644
--- a/web-src/src/main-app/components/scripts/ScriptListItem.vue
+++ b/web-src/src/main-app/components/scripts/ScriptListItem.vue
@@ -1,12 +1,13 @@
 <template>
   <router-link :to="'/' + descriptor.hash"
                class="collection-item waves-effect script-list-item"
-               v-bind:class="{ active: descriptor.active, 'parsing-failed': descriptor.parsingFailed}">
+               :class="{ active: descriptor.active, 'parsing-failed': descriptor.parsingFailed}"
+               :title="descriptor.parsingFailed ? 'Failed to parse config file' : ''">
     {{ descriptor.name }}
 
     <div :class="descriptor.state" class="menu-item-state">
       <i class="material-icons check-icon">check</i>
-      <i class="material-icons failed-icon">do_not_disturb_alt</i>
+      <i class="material-icons failed-icon">warning</i>
       <div class="preloader-wrapper active">
         <div class="spinner-layer">
           <div class="circle-clipper left">
@@ -46,7 +47,7 @@ export default {
         state: this.getState(this.script.name),
         active: this.selectedScript === this.script.name,
         hash: this.toHash(this.script.name),
-        parsingFailed: this.script.parsing_failed,
+        parsingFailed: this.script.parsing_failed
       }
     },
     ...mapState('scripts', ['selectedScript'])
@@ -55,7 +56,7 @@ export default {
     getState(scriptName) {
       let state = 'idle';
 
-      if(this.script.parsing_failed) {
+      if (this.script.parsing_failed) {
         return 'cannot-parse'
       }
 
@@ -81,8 +82,7 @@ export default {
 }
 
 .scripts-list .collection-item.parsing-failed {
-  color: var(--error-color);
-
+  color: var(--font-color-disabled);
 }
 
 .scripts-list .collection-item .menu-item-state {
@@ -112,8 +112,9 @@ export default {
   display: inline;
 }
 
-.scripts-list .collection-item .menu-item-state.executing > .check-icon,
-.scripts-list .collection-item .menu-item-state.executing > .failed-icon {
+.scripts-list .collection-item .menu-item-state > .check-icon,
+.scripts-list .collection-item .menu-item-state > .preloader-wrapper,
+.scripts-list .collection-item .menu-item-state > .failed-icon {
   display: none;
 }
 
@@ -125,16 +126,6 @@ export default {
   display: block;
 }
 
-.scripts-list .collection-item .menu-item-state.finished > .preloader-wrapper,
-.scripts-list .collection-item .menu-item-state.finished > .failed-icon {
-  display: none;
-}
-
-.scripts-list .collection-item .menu-item-state.cannot-parse > .check-icon {
-  display: none;
-}
-
-
 .scripts-list .collection-item .menu-item-state.cannot-parse > .failed-icon {
   display: block;
 }
diff --git a/web-src/src/main-app/store/scriptConfig.js b/web-src/src/main-app/store/scriptConfig.js
index fd85fc4f..169e732e 100644
--- a/web-src/src/main-app/store/scriptConfig.js
+++ b/web-src/src/main-app/store/scriptConfig.js
@@ -1,5 +1,5 @@
 import {ReactiveWebSocket} from '@/common/connections/rxWebsocket';
-import clone from 'lodash/clone';
+import {axiosInstance} from '@/common/utils/axios_utils';
 import {
     forEachKeyValue,
     HttpForbiddenError,
@@ -15,7 +15,7 @@ import {
     toDict,
     toQueryArgs
 } from '@/common/utils/common';
-import {axiosInstance} from '@/common/utils/axios_utils';
+import clone from 'lodash/clone';
 import Vue from 'vue';
 import {preprocessParameter} from '../utils/model_helper';
 
@@ -334,9 +334,9 @@ function reconnect(state, internalState, commit, dispatch, selectedScript) {
             logError(error);
 
             if (error instanceof SocketClosedError) {
-              
+
                 if (error.code === 422) {
-                  commit('SET_ERROR', `${CANNOT_PARSE_ERROR_PREFIX} "${selectedScript}"`);
+                    commit('SET_ERROR', `${error.reason} "${selectedScript}"`);
                   return;
                 }
                 

From a3749b3289eadab217c9bb3f80686f253b61ba21 Mon Sep 17 00:00:00 2001
From: yshepilov <buggygm@gmail.com>
Date: Sun, 6 Nov 2022 10:46:33 +0100
Subject: [PATCH 25/27] #586 disabled corrupted config name obfuscation for
 admins

---
 src/config/config_service.py                   | 18 +++++++++++-------
 src/model/script_config.py                     | 11 ++++++-----
 .../components/scripts/ScriptListItem.vue      |  2 +-
 3 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/src/config/config_service.py b/src/config/config_service.py
index fba4305d..788cfcc3 100644
--- a/src/config/config_service.py
+++ b/src/config/config_service.py
@@ -56,7 +56,7 @@ def __init__(self, authorizer, conf_folder) -> None:
     def load_config(self, name, user):
         self._check_admin_access(user)
 
-        search_result = self._find_config(name)
+        search_result = self._find_config(name, user)
 
         if search_result is None:
             return None
@@ -77,7 +77,7 @@ def create_config(self, user, config, uploaded_script):
 
         name = config['name']
 
-        search_result = self._find_config(name)
+        search_result = self._find_config(name, user)
         if search_result is not None:
             raise InvalidConfigException('Another config with the same name already exists')
 
@@ -108,7 +108,7 @@ def update_config(self, user, config, filename, uploaded_script):
 
         name = config['name']
 
-        search_result = self._find_config(name)
+        search_result = self._find_config(name, user)
         if (search_result is not None) and (os.path.basename(search_result.path) != filename):
             raise InvalidConfigException('Another script found with the same name: ' + name)
 
@@ -178,6 +178,8 @@ def list_configs(self, user, mode=None):
 
         conf_service = self
 
+        has_admin_rights = self._authorizer.is_admin(user.user_id)
+
         def load_script(path, content) -> Optional[ShortConfig]:
             try:
                 config_object = self.load_config_file(path, content)
@@ -195,14 +197,14 @@ def load_script(path, content) -> Optional[ShortConfig]:
                 return short_config
             except json.decoder.JSONDecodeError:
                 LOGGER.exception(CorruptConfigFileException.VERBOSE_ERROR + ': ' + path)
-                return create_failed_short_config(path)
+                return create_failed_short_config(path, has_admin_rights)
             except Exception:
                 LOGGER.exception('Could not load script: ' + path)
 
         return self._visit_script_configs(load_script)
 
     def load_config_model(self, name, user, parameter_values=None, skip_invalid_parameters=False):
-        search_result = self._find_config(name)
+        search_result = self._find_config(name, user)
 
         if search_result is None:
             return None
@@ -241,7 +243,9 @@ def _visit_script_configs(self, visitor):
 
         return result
 
-    def _find_config(self, name) -> Optional[ConfigSearchResult]:
+    def _find_config(self, name, user) -> Optional[ConfigSearchResult]:
+        has_admin_rights = self._authorizer.is_admin(user.user_id)
+
         def find_and_load(path: str, content):
             try:
                 config_object = self.load_config_file(path, content)
@@ -250,7 +254,7 @@ def find_and_load(path: str, content):
                 if short_config is None:
                     return None
             except json.decoder.JSONDecodeError:
-                short_config = create_failed_short_config(path)
+                short_config = create_failed_short_config(path, has_admin_rights)
                 config_object = None
 
             except Exception:
diff --git a/src/model/script_config.py b/src/model/script_config.py
index 381a84f9..fda203f9 100644
--- a/src/model/script_config.py
+++ b/src/model/script_config.py
@@ -30,16 +30,17 @@ def __init__(self):
         self.parsing_failed = False
 
 
-def create_failed_short_config(path):
+def create_failed_short_config(path, has_admin_rights):
     failed_short_config = ShortConfig()
     name = _build_name_from_path(path)
     failed_short_config.name = name
     failed_short_config.parsing_failed = True
 
-    file_content = file_utils.read_file(path)
-    if '"allowed_users"' in file_content:
-        restricted_name = name[:2] + '...' + name[-2:]
-        failed_short_config.name = restricted_name + ' (restricted)'
+    if not has_admin_rights:
+        file_content = file_utils.read_file(path)
+        if '"allowed_users"' in file_content:
+            restricted_name = name[:2] + '...' + name[-2:]
+            failed_short_config.name = restricted_name + ' (restricted)'
 
     return failed_short_config
 
diff --git a/web-src/src/main-app/components/scripts/ScriptListItem.vue b/web-src/src/main-app/components/scripts/ScriptListItem.vue
index 3d3b9f39..2ad06539 100644
--- a/web-src/src/main-app/components/scripts/ScriptListItem.vue
+++ b/web-src/src/main-app/components/scripts/ScriptListItem.vue
@@ -7,7 +7,7 @@
 
     <div :class="descriptor.state" class="menu-item-state">
       <i class="material-icons check-icon">check</i>
-      <i class="material-icons failed-icon">warning</i>
+      <i class="material-icons failed-icon">priority_high</i>
       <div class="preloader-wrapper active">
         <div class="spinner-layer">
           <div class="circle-clipper left">

From 40bd7c7f1e5e20dc0fa8a761ad24a5c9ef7ad7a5 Mon Sep 17 00:00:00 2001
From: yshepilov <buggygm@gmail.com>
Date: Sun, 6 Nov 2022 11:51:36 +0100
Subject: [PATCH 26/27] #586 fixed tests

---
 src/model/script_config.py                    | 51 +++++++++----------
 src/tests/config_service_test.py              | 25 ++++++---
 src/tests/web/server_test.py                  |  6 +--
 .../tests/unit/admin/script-module_test.js    | 14 +++--
 4 files changed, 55 insertions(+), 41 deletions(-)

diff --git a/src/model/script_config.py b/src/model/script_config.py
index fda203f9..d99e5073 100644
--- a/src/model/script_config.py
+++ b/src/model/script_config.py
@@ -3,6 +3,7 @@
 import os
 import re
 from collections import OrderedDict
+from dataclasses import dataclass, field
 
 from auth.authorization import ANY_USER
 from config.exceptions import InvalidConfigException
@@ -21,28 +22,24 @@
 LOGGER = logging.getLogger('script_server.script_config')
 
 
-class ShortConfig(object):
-    def __init__(self):
-        self.name = None
-        self.allowed_users = []
-        self.admin_users = []
-        self.group = None
-        self.parsing_failed = False
+@dataclass
+class ShortConfig:
+    name: str
+    group: str = None
+    allowed_users: list[str] = field(default_factory=list)
+    admin_users: list[str] = field(default_factory=list)
+    parsing_failed: bool = False
 
 
 def create_failed_short_config(path, has_admin_rights):
-    failed_short_config = ShortConfig()
     name = _build_name_from_path(path)
-    failed_short_config.name = name
-    failed_short_config.parsing_failed = True
-
     if not has_admin_rights:
         file_content = file_utils.read_file(path)
         if '"allowed_users"' in file_content:
             restricted_name = name[:2] + '...' + name[-2:]
-            failed_short_config.name = restricted_name + ' (restricted)'
+            name = restricted_name + ' (restricted)'
 
-    return failed_short_config
+    return ShortConfig(name=name, parsing_failed=True)
 
 
 @observable_fields(
@@ -289,28 +286,26 @@ def _build_name_from_path(file_path):
 
 
 def read_short(file_path, json_object):
-    config = ShortConfig()
-
-    config.name = _read_name(file_path, json_object)
-    config.allowed_users = json_object.get('allowed_users')
-    config.admin_users = json_object.get('admin_users')
-    config.group = read_str_from_config(json_object, 'group', blank_to_none=True)
+    name = _read_name(file_path, json_object)
+    allowed_users = json_object.get('allowed_users')
+    admin_users = json_object.get('admin_users')
+    group = read_str_from_config(json_object, 'group', blank_to_none=True)
 
     hidden = read_bool_from_config('hidden', json_object, default=False)
     if hidden:
         return None
 
-    if config.allowed_users is None:
-        config.allowed_users = ANY_USER
-    elif (config.allowed_users == '*') or ('*' in config.allowed_users):
-        config.allowed_users = ANY_USER
+    if allowed_users is None:
+        allowed_users = ANY_USER
+    elif (allowed_users == '*') or ('*' in allowed_users):
+        allowed_users = ANY_USER
 
-    if config.admin_users is None:
-        config.admin_users = ANY_USER
-    elif (config.admin_users == '*') or ('*' in config.admin_users):
-        config.admin_users = ANY_USER
+    if admin_users is None:
+        admin_users = ANY_USER
+    elif (admin_users == '*') or ('*' in admin_users):
+        admin_users = ANY_USER
 
-    return config
+    return ShortConfig(name=name, group=group, allowed_users=allowed_users, admin_users=admin_users)
 
 
 class ParameterNotFoundException(Exception):
diff --git a/src/tests/config_service_test.py b/src/tests/config_service_test.py
index 645c0dfc..41daf58e 100644
--- a/src/tests/config_service_test.py
+++ b/src/tests/config_service_test.py
@@ -8,14 +8,14 @@
 from parameterized import parameterized
 from tornado.httputil import HTTPFile
 
-from auth.authorization import Authorizer, EmptyGroupProvider
+from auth.authorization import Authorizer, EmptyGroupProvider, ANY_USER
 from auth.user import User
 from config.config_service import ConfigService, ConfigNotAllowedException, AdminAccessRequiredException, \
     InvalidAccessException
 from config.exceptions import InvalidConfigException
 from model.model_helper import InvalidFileException
+from model.script_config import ShortConfig
 from tests import test_utils
-from tests.test_utils import AnyUserAuthorizer
 from utils import file_utils, custom_json
 from utils.audit_utils import AUTH_USERNAME
 from utils.file_utils import is_executable
@@ -56,15 +56,24 @@ def test_list_configs_when_no(self):
         configs = self.config_service.list_configs(self.user)
         self.assertEqual([], configs)
 
-    def test_list_configs_when_one_broken(self):
+    @parameterized.expand([
+        (False, 'hello', 'broken'),
+        (True, 'hello', 'broken'),
+        (False, '"allowed_users"', 'br...en (restricted)'),
+        (True, '"allowed_users"', 'broken'),
+    ])
+    def test_list_configs_when_one_broken(self, is_admin, content, expected_name):
         broken_conf_path = _create_script_config_file('broken')
-        file_utils.write_file(broken_conf_path, '{ hello ?')
+        file_utils.write_file(broken_conf_path, '{ ' + content + ' ?')
         _create_script_config_file('correct')
 
-        configs = self.config_service.list_configs(self.user)
-        self.assertEqual(1, len(configs))
+        configs = self.config_service.list_configs(self.admin_user if is_admin else self.user)
+        self.assertEqual(2, len(configs))
         self.assertEqual('correct', configs[0].name)
 
+        expected_broken_config = ShortConfig(name=expected_name, parsing_failed=True)
+        self.assertEqual(expected_broken_config, configs[1])
+
     def test_list_hidden_config(self):
         _create_script_config_file('conf_x', hidden=True)
 
@@ -105,7 +114,9 @@ def setUp(self):
         test_utils.setup()
 
         self.user = User('ConfigServiceTest', {AUTH_USERNAME: 'ConfigServiceTest'})
-        self.config_service = ConfigService(AnyUserAuthorizer(), test_utils.temp_folder)
+        self.admin_user = User('admin_user', {AUTH_USERNAME: 'The Admin'})
+        authorizer = Authorizer(ANY_USER, ['admin_user'], [], [], EmptyGroupProvider())
+        self.config_service = ConfigService(authorizer, test_utils.temp_folder)
 
 
 class ConfigServiceAuthTest(unittest.TestCase):
diff --git a/src/tests/web/server_test.py b/src/tests/web/server_test.py
index 99e551fb..053e08b1 100644
--- a/src/tests/web/server_test.py
+++ b/src/tests/web/server_test.py
@@ -88,9 +88,9 @@ def test_get_scripts(self):
 
         response = self.request('GET', 'http://127.0.0.1:12345/scripts')
         self.assertCountEqual([
-            {'name': 's1', 'group': None},
-            {'name': 's2', 'group': 'Xyz'},
-            {'name': 's3', 'group': None}],
+            {'name': 's1', 'group': None, 'parsing_failed': False},
+            {'name': 's2', 'group': 'Xyz', 'parsing_failed': False},
+            {'name': 's3', 'group': None, 'parsing_failed': False}],
             response['scripts'])
 
     @parameterized.expand([
diff --git a/web-src/tests/unit/admin/script-module_test.js b/web-src/tests/unit/admin/script-module_test.js
index e83c9a98..a3208736 100644
--- a/web-src/tests/unit/admin/script-module_test.js
+++ b/web-src/tests/unit/admin/script-module_test.js
@@ -42,17 +42,25 @@ describe('Test admin script module', function () {
             await store.dispatch('scripts/init');
             await flushPromises();
 
-            expect(store.state.scripts.scripts).toEqual(['script1'])
+            expect(store.state.scripts.scripts).toEqual(
+                [{'name': 'script1', 'parsingFailed': undefined}])
             expect(store.state.scripts.loading).toBeFalse()
         });
 
         it('test load multiple unsorted scripts', async function () {
-            mockGetScripts([{'name': 'def', 'group': 'some_group'}, {'name': 'xyz'}, {'name': 'abc'}]);
+            mockGetScripts([
+                {'name': 'def', 'group': 'some_group'},
+                {'name': 'xyz', 'parsing_failed': false},
+                {'name': 'abc', 'parsing_failed': true}]);
 
             await store.dispatch('scripts/init');
             await flushPromises();
 
-            expect(store.state.scripts.scripts).toEqual(['abc', 'def', 'xyz'])
+            expect(store.state.scripts.scripts).toEqual([
+                {'name': 'abc', 'parsingFailed': true},
+                {'name': 'def', 'parsingFailed': undefined},
+                {'name': 'xyz', 'parsingFailed': false}
+            ])
             expect(store.state.scripts.loading).toBeFalse()
         });
         }

From 6ddf55fd09618d6d495ee14e7ff47e9a38fe2dc3 Mon Sep 17 00:00:00 2001
From: yshepilov <buggygm@gmail.com>
Date: Sun, 6 Nov 2022 12:21:54 +0100
Subject: [PATCH 27/27] #586 fixed tests

---
 src/model/script_config.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/model/script_config.py b/src/model/script_config.py
index d99e5073..2c1916a8 100644
--- a/src/model/script_config.py
+++ b/src/model/script_config.py
@@ -4,6 +4,7 @@
 import re
 from collections import OrderedDict
 from dataclasses import dataclass, field
+from typing import List
 
 from auth.authorization import ANY_USER
 from config.exceptions import InvalidConfigException
@@ -26,8 +27,8 @@
 class ShortConfig:
     name: str
     group: str = None
-    allowed_users: list[str] = field(default_factory=list)
-    admin_users: list[str] = field(default_factory=list)
+    allowed_users: List[str] = field(default_factory=list)
+    admin_users: List[str] = field(default_factory=list)
     parsing_failed: bool = False