[FC] Stop cloning SnapshotKeySet (#11925)

maggie-lou · web-flow · commit 26acd7f24c31 · 2026-04-20T12:21:03.000-05:00
We frequently read the snapshot keys, and cloning every time is
expensive. Currently, every time we use this function is read-only and
the clone is unnecessary. Only firecracker code and tests are
referencing this
diff --git a/enterprise/server/remote_execution/containers/firecracker/firecracker.go b/enterprise/server/remote_execution/containers/firecracker/firecracker.go
@@ -1026,7 +1026,7 @@ func alignToMultiple(n int64, multiple int64) int64 {
 }
 
 func (c *FirecrackerContainer) SnapshotKeySet() *fcpb.SnapshotKeySet {
-	return c.snapshotKeySet.CloneVT()
+	return c.snapshotKeySet
 }
 
 func (c *FirecrackerContainer) SnapshotID() string {

Original file line number	Diff line number	Diff line change
`@@ -1026,7 +1026,7 @@ func alignToMultiple(n int64, multiple int64) int64 {`
`1026`	`1026`	`}`
`1027`	`1027`
`1028`	`1028`	`func (c FirecrackerContainer) SnapshotKeySet() fcpb.SnapshotKeySet {`
`1029`		`- return c.snapshotKeySet.CloneVT()`
	`1029`	`+ return c.snapshotKeySet`
`1030`	`1030`	`}`
`1031`	`1031`
`1032`	`1032`	`func (c *FirecrackerContainer) SnapshotID() string {`