Fix errors becoming traps in wasi-http#8272
Merged
Merged
Conversation
This commit fixes an issue with errors in the `wasmtime-wasi-http` crate by using the `trappable_error_type` bindgen configuration option in the same manner as other WASI interfaces in the `wasmtime-wasi` crate. Unfortunately due to coherence the `TrappableError<T>` type itself could not be used but it was small enough it wasn't much effort to duplicate. Closes bytecodealliance#8269
Member
|
Redirecting to @elliottt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue with errors in the
wasmtime-wasi-httpcrate by using thetrappable_error_typebindgen configuration option in the same manner as other WASI interfaces in thewasmtime-wasicrate. Unfortunately due to coherence theTrappableError<T>type itself could not be used but it was small enough it wasn't much effort to duplicate.Closes #8269