Skip to content

GH4603: Fix .NET framework version detection #4605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devlead merged 1 commit into from
Oct 6, 2025
Merged

GH4603: Fix .NET framework version detection #4605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions src/Cake.Core/Polyfill/EnvironmentHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Licensed to the .NET Foundation under one or more agreements.
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

Expand All @@ -7,6 +7,7 @@
using System.Reflection;
using System.Runtime.InteropServices;
using System.Runtime.Versioning;
using Cake.Core.IO;

namespace Cake.Core.Polyfill
{
Expand Down Expand Up @@ -126,30 +127,37 @@ public static FrameworkName GetBuiltFramework()
return netCoreAppFramwork;
}

var assemblyPath = typeof(System.Runtime.GCSettings)?.GetTypeInfo()
?.Assembly
#if NETCOREAPP3_1
?.CodeBase;
#else
#pragma warning disable 0618
var assembly = typeof(System.Runtime.GCSettings)?.GetTypeInfo()
?.Assembly;

var assemblyPath = assembly
#pragma warning disable IL3000 // Avoid accessing Assembly file path when publishing as a single file
?.Location;
#pragma warning restore 0618
#endif
#pragma warning restore IL3000 // Avoid accessing Assembly file path when publishing as a single file

if (string.IsNullOrEmpty(assemblyPath))
{
return NetStandardFramework;
if (assembly.GetName().Version is Version assemblyVersion)
{
return netCoreAppFramwork = new FrameworkName(".NETCoreApp", new Version(assemblyVersion.Major, assemblyVersion.Minor));
}

return netCoreAppFramwork = NetStandardFramework;
}

const string microsoftNetCoreApp = "Microsoft.NETCore.App";
var runtimeBasePathLength = assemblyPath.IndexOf(microsoftNetCoreApp) + microsoftNetCoreApp.Length + 1;
var netCoreAppVersion = string.Concat(assemblyPath.Skip(runtimeBasePathLength).Take(3));
const int microsoftNetCoreAppLengthPlusOne = 22;
var versionStart = Math.Max(0, assemblyPath.IndexOf(microsoftNetCoreApp) + microsoftNetCoreAppLengthPlusOne);
var versionEnd = versionStart + Math.Max(3, assemblyPath.IndexOfAny(['-', '/', '\\'], versionStart) - versionStart);
var netCoreAppVersion = assemblyPath[versionStart..versionEnd];

if (string.IsNullOrEmpty(netCoreAppVersion))
{
return NetStandardFramework;
return netCoreAppFramwork = NetStandardFramework;
}

return netCoreAppFramwork = Version.TryParse(netCoreAppVersion, out var version)
? new FrameworkName(".NETCoreApp", version)
? new FrameworkName(".NETCoreApp", new Version(version.Major, version.Minor))
: NetStandardFramework;
}
}
Expand Down
Loading