Skip to content

Fix multiple issues with ~FC023#341

Merged
EasyAsABC123 merged 1 commit into
masterfrom
fix-pool_custom_resource
Apr 27, 2017
Merged

Fix multiple issues with ~FC023#341
EasyAsABC123 merged 1 commit into
masterfrom
fix-pool_custom_resource

Conversation

@EasyAsABC123
Copy link
Copy Markdown
Contributor

@EasyAsABC123 EasyAsABC123 commented Apr 25, 2017 •
edited
Loading

Signed-off-by: Justin Schuhmann jmschu02@gmail.com

Description

Resolves multiple issues caused by recommendations from FC023 rule, only_if and not_if are ignored for converge_if_changed and converge_by

Issues Resolved

#340

Check List

@EasyAsABC123 EasyAsABC123 requested a review from iennae April 25, 2017 15:11
@EasyAsABC123 EasyAsABC123 mentioned this pull request Apr 25, 2017
Closed
@EasyAsABC123 EasyAsABC123 force-pushed the fix-pool_custom_resource branch from 28363cc to 3b6956c Compare April 25, 2017 15:42
@tas50
Copy link
Copy Markdown
Contributor

tas50 commented Apr 25, 2017

We actually retired FC023 because it caused problems like these.

@EasyAsABC123
Copy link
Copy Markdown
Contributor Author

EasyAsABC123 commented Apr 25, 2017

@tas50 yeah i read the documentation but feel for it all the same...saw deprecated but still thought that the converge_* functions would work with not_if and only_if..testing locally to make the test pass (inspec can't access node so need to verify the computer name)

@EasyAsABC123
Fix multiple issues with ~FC023
0a6443a 
Signed-off-by: Justin Schuhmann <jmschu02@gmail.com>
@EasyAsABC123 EasyAsABC123 force-pushed the fix-pool_custom_resource branch from 3b6956c to 0a6443a Compare April 25, 2017 16:19
iennae
iennae approved these changes Apr 26, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. is site_identifier used at all now?

@EasyAsABC123
Copy link
Copy Markdown
Contributor Author

EasyAsABC123 commented Apr 27, 2017

@iennae not in the iis_app

@EasyAsABC123 EasyAsABC123 merged commit 4e46a38 into master Apr 27, 2017
@EasyAsABC123 EasyAsABC123 deleted the fix-pool_custom_resource branch April 27, 2017 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@iennae iennae iennae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EasyAsABC123 @tas50 @iennae