Fix error when pressing backspace in empty multiple-select component#1495
Merged
RobbieTheWagner merged 1 commit intoSep 6, 2022
Merged
Conversation
Contributor
|
@gvdp could you please rebase this PR? |
gvdp
force-pushed
the
backspace-undefined-error
branch
from
09ff38f to
20e5103
Compare
Contributor
Author
|
@rwwagner90 Done. Thanks for having a look at it! |
Contributor
|
@gvdp looks like there are some linting issues. Mind running |
gvdp
force-pushed
the
backspace-undefined-error
branch
from
20e5103 to
60e0f42
Compare
Contributor
Author
|
@rwwagner90 My bad, didn't run the linting before committing. You can easily add a pre commit hook to prevent this from happening, I'll happily make a PR for that as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pressing backspace in a multiple select component there was a console error logged because the selection is undefined:
Fixed it by just adding a simple nullcheck in the trigger component.