Update to ember 4.8 & packages. Require node >= 16, Ember >= 3.28#1570
Merged
Conversation
Collaborator
Author
|
@cibernox updated more/less everything, now the app works on ember 4. |
Collaborator
Author
|
the tests for embroider are failing because ember data was buggy from 4.8.x to 4.11.0. starting with 4.11.1 the test should not anymore fail. i will fix it |
Collaborator
|
Fix it as part of this PR on another one? |
Collaborator
Author
|
i do it in this PR, just wait a secound :D |
Collaborator
Author
|
@cibernox can you approval the workflow, than we see if we are ready |
Collaborator
|
🤞 |
Collaborator
Author
|
interesting that this tests was never failed before... we need to fix it like in this PR: #1532 |
Collaborator
|
FWIW, I think I'm going to merge this as is and we can fix the embroider optimized scenario later. |
Collaborator
Author
|
wait i have it already, i'm just testing locally |
mkszepp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1569 & #1563