Remove incorrect Element from args in PowerSelectMultipleTrigger#1862
Merged
Conversation
mkszepp
changed the title
Element from args in PowerSelectMultipleTriggerElement from args in PowerSelectMultipleTrigger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered in one of my glint projects that we have in multiple trigger the parameter
Element.This brings some issues.
HTMLElementwhich is unusedtemplate-lint-disable no-capital-arguments, because parameters in uppercase are not allowedThis bug was maybe introduced when there was added glint inside power select
We can safely remove this parameter