Initial Support For GameLift#162
Closed
dpalvolgyi-pw wants to merge 5 commits intoclawscli:developfrom
Closed
Conversation
chore(nix): set GOROOT to prevent system Go mismatch
docs: add Japanese, Chinese, Korean translations
yimsk
reviewed
Feb 10, 2026
Contributor
yimsk
left a comment
There was a problem hiding this comment.
Thanks for the contribution! The overall structure follows our patterns well — proper use of DAO/Renderer/Actions, navigation between resources, and the Supports() override for game-sessions.
A few things before we can merge:
1. Base branch → develop
Our workflow is feature → develop → main. Could you retarget this PR to develop?
2. Bug: apperrors.Wrapf with nil error (3 places)
When the API succeeds but returns empty results, err is nil at that point. Since Wrapf returns nil for nil errors, these lines return nil, nil — which will cause a nil pointer panic downstream:
fleets/dao.go:67game-session-queues/dao.go:68matchmaking-configs/dao.go:46
Fix:
// before (err is nil here, so Wrapf returns nil)
return nil, apperrors.Wrapf(err, "gamelift fleet %s not found", id)
// after
return nil, fmt.Errorf("gamelift fleet %s not found", id)
Contributor
Author
|
closing in favor of #163 |
dpalvolgyi-pw
added a commit
to dpalvolgyi-pw/claws
that referenced
this pull request
Feb 11, 2026
This commit adresses concerns form the comments on PR clawscli#162
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not much of a gopher myself, just wanted to not rely on the webui for gamelift.
Any feedback is appreciated