Skip to content

Commit 3fa9439

Browse files
pull[bot]pull[bot]
committed
[Fiber] Log Effect and Render Times in Offscreen Commit Phase (facebook#31788)
In facebook#30967 and facebook#30983 I added logging of the just rendered components and the effects. However this didn't consider the special Offscreen passes. So this adds the same thing to those passes. Log component effect timings for disconnected/reconnected offscreen subtrees. This includes initial mount of a Suspense boundary. Log component render timings for reconnected and already offscreen offscreen subtrees. DiffTrain build for [6a4b46c](facebook@6a4b46c)
1 parent 545bf7e commit 3fa9439

24 files changed

+564
-575
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.1.0-native-fb-facec3ee-20241217
1+
19.1.0-native-fb-6a4b46cd-20241217

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<5f71600380649b875c0a51a31e58dff5>>
10+
* @generated SignedSource<<46dacfae87e8ca444b422d58261e7b3e>>
1111
*/
1212

1313
"use strict";
@@ -420,5 +420,5 @@ __DEV__ &&
420420
exports.useFormStatus = function () {
421421
return resolveDispatcher().useHostTransitionStatus();
422422
};
423-
exports.version = "19.1.0-native-fb-facec3ee-20241217";
423+
exports.version = "19.1.0-native-fb-6a4b46cd-20241217";
424424
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<a8bc17ffe2d6bec1f415b3bf5659951d>>
10+
* @generated SignedSource<<ac23bad20f89258da38fa4a147ede53b>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.1.0-native-fb-facec3ee-20241217";
206+
exports.version = "19.1.0-native-fb-6a4b46cd-20241217";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<a8bc17ffe2d6bec1f415b3bf5659951d>>
10+
* @generated SignedSource<<ac23bad20f89258da38fa4a147ede53b>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.1.0-native-fb-facec3ee-20241217";
206+
exports.version = "19.1.0-native-fb-6a4b46cd-20241217";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 168 additions & 168 deletions
Large diffs are not rendered by default.

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<3983426ab11c7aaa107d81ebca2c5b9f>>
10+
* @generated SignedSource<<c34f2186f82f671d1328c7425fe688ea>>
1111
*/
1212

1313
/*
@@ -12361,20 +12361,20 @@ function extractEvents$1(
1236112361
}
1236212362
}
1236312363
for (
12364-
var i$jscomp$inline_1479 = 0;
12365-
i$jscomp$inline_1479 < simpleEventPluginEvents.length;
12366-
i$jscomp$inline_1479++
12364+
var i$jscomp$inline_1481 = 0;
12365+
i$jscomp$inline_1481 < simpleEventPluginEvents.length;
12366+
i$jscomp$inline_1481++
1236712367
) {
12368-
var eventName$jscomp$inline_1480 =
12369-
simpleEventPluginEvents[i$jscomp$inline_1479],
12370-
domEventName$jscomp$inline_1481 =
12371-
eventName$jscomp$inline_1480.toLowerCase(),
12372-
capitalizedEvent$jscomp$inline_1482 =
12373-
eventName$jscomp$inline_1480[0].toUpperCase() +
12374-
eventName$jscomp$inline_1480.slice(1);
12368+
var eventName$jscomp$inline_1482 =
12369+
simpleEventPluginEvents[i$jscomp$inline_1481],
12370+
domEventName$jscomp$inline_1483 =
12371+
eventName$jscomp$inline_1482.toLowerCase(),
12372+
capitalizedEvent$jscomp$inline_1484 =
12373+
eventName$jscomp$inline_1482[0].toUpperCase() +
12374+
eventName$jscomp$inline_1482.slice(1);
1237512375
registerSimpleEvent(
12376-
domEventName$jscomp$inline_1481,
12377-
"on" + capitalizedEvent$jscomp$inline_1482
12376+
domEventName$jscomp$inline_1483,
12377+
"on" + capitalizedEvent$jscomp$inline_1484
1237812378
);
1237912379
}
1238012380
registerSimpleEvent(ANIMATION_END, "onAnimationEnd");
@@ -15867,16 +15867,16 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1586715867
0 === i && attemptExplicitHydrationTarget(target);
1586815868
}
1586915869
};
15870-
var isomorphicReactPackageVersion$jscomp$inline_1722 = React.version;
15870+
var isomorphicReactPackageVersion$jscomp$inline_1724 = React.version;
1587115871
if (
15872-
"19.1.0-native-fb-facec3ee-20241217" !==
15873-
isomorphicReactPackageVersion$jscomp$inline_1722
15872+
"19.1.0-native-fb-6a4b46cd-20241217" !==
15873+
isomorphicReactPackageVersion$jscomp$inline_1724
1587415874
)
1587515875
throw Error(
1587615876
formatProdErrorMessage(
1587715877
527,
15878-
isomorphicReactPackageVersion$jscomp$inline_1722,
15879-
"19.1.0-native-fb-facec3ee-20241217"
15878+
isomorphicReactPackageVersion$jscomp$inline_1724,
15879+
"19.1.0-native-fb-6a4b46cd-20241217"
1588015880
)
1588115881
);
1588215882
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -15896,24 +15896,24 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1589615896
null === componentOrElement ? null : componentOrElement.stateNode;
1589715897
return componentOrElement;
1589815898
};
15899-
var internals$jscomp$inline_2177 = {
15899+
var internals$jscomp$inline_2179 = {
1590015900
bundleType: 0,
15901-
version: "19.1.0-native-fb-facec3ee-20241217",
15901+
version: "19.1.0-native-fb-6a4b46cd-20241217",
1590215902
rendererPackageName: "react-dom",
1590315903
currentDispatcherRef: ReactSharedInternals,
15904-
reconcilerVersion: "19.1.0-native-fb-facec3ee-20241217"
15904+
reconcilerVersion: "19.1.0-native-fb-6a4b46cd-20241217"
1590515905
};
1590615906
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
15907-
var hook$jscomp$inline_2178 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
15907+
var hook$jscomp$inline_2180 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
1590815908
if (
15909-
!hook$jscomp$inline_2178.isDisabled &&
15910-
hook$jscomp$inline_2178.supportsFiber
15909+
!hook$jscomp$inline_2180.isDisabled &&
15910+
hook$jscomp$inline_2180.supportsFiber
1591115911
)
1591215912
try {
15913-
(rendererID = hook$jscomp$inline_2178.inject(
15914-
internals$jscomp$inline_2177
15913+
(rendererID = hook$jscomp$inline_2180.inject(
15914+
internals$jscomp$inline_2179
1591515915
)),
15916-
(injectedHook = hook$jscomp$inline_2178);
15916+
(injectedHook = hook$jscomp$inline_2180);
1591715917
} catch (err) {}
1591815918
}
1591915919
exports.createRoot = function (container, options) {
@@ -16007,4 +16007,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1600716007
listenToAllSupportedEvents(container);
1600816008
return new ReactDOMHydrationRoot(initialChildren);
1600916009
};
16010-
exports.version = "19.1.0-native-fb-facec3ee-20241217";
16010+
exports.version = "19.1.0-native-fb-6a4b46cd-20241217";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<350b3d8aa3f45f071bdab61d95033fa5>>
10+
* @generated SignedSource<<3bb31c69bf2cc763098612269dfeb872>>
1111
*/
1212

1313
/*
@@ -13006,20 +13006,20 @@ function extractEvents$1(
1300613006
}
1300713007
}
1300813008
for (
13009-
var i$jscomp$inline_1567 = 0;
13010-
i$jscomp$inline_1567 < simpleEventPluginEvents.length;
13011-
i$jscomp$inline_1567++
13009+
var i$jscomp$inline_1569 = 0;
13010+
i$jscomp$inline_1569 < simpleEventPluginEvents.length;
13011+
i$jscomp$inline_1569++
1301213012
) {
13013-
var eventName$jscomp$inline_1568 =
13014-
simpleEventPluginEvents[i$jscomp$inline_1567],
13015-
domEventName$jscomp$inline_1569 =
13016-
eventName$jscomp$inline_1568.toLowerCase(),
13017-
capitalizedEvent$jscomp$inline_1570 =
13018-
eventName$jscomp$inline_1568[0].toUpperCase() +
13019-
eventName$jscomp$inline_1568.slice(1);
13013+
var eventName$jscomp$inline_1570 =
13014+
simpleEventPluginEvents[i$jscomp$inline_1569],
13015+
domEventName$jscomp$inline_1571 =
13016+
eventName$jscomp$inline_1570.toLowerCase(),
13017+
capitalizedEvent$jscomp$inline_1572 =
13018+
eventName$jscomp$inline_1570[0].toUpperCase() +
13019+
eventName$jscomp$inline_1570.slice(1);
1302013020
registerSimpleEvent(
13021-
domEventName$jscomp$inline_1569,
13022-
"on" + capitalizedEvent$jscomp$inline_1570
13021+
domEventName$jscomp$inline_1571,
13022+
"on" + capitalizedEvent$jscomp$inline_1572
1302313023
);
1302413024
}
1302513025
registerSimpleEvent(ANIMATION_END, "onAnimationEnd");
@@ -16520,16 +16520,16 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1652016520
0 === i && attemptExplicitHydrationTarget(target);
1652116521
}
1652216522
};
16523-
var isomorphicReactPackageVersion$jscomp$inline_1812 = React.version;
16523+
var isomorphicReactPackageVersion$jscomp$inline_1814 = React.version;
1652416524
if (
16525-
"19.1.0-native-fb-facec3ee-20241217" !==
16526-
isomorphicReactPackageVersion$jscomp$inline_1812
16525+
"19.1.0-native-fb-6a4b46cd-20241217" !==
16526+
isomorphicReactPackageVersion$jscomp$inline_1814
1652716527
)
1652816528
throw Error(
1652916529
formatProdErrorMessage(
1653016530
527,
16531-
isomorphicReactPackageVersion$jscomp$inline_1812,
16532-
"19.1.0-native-fb-facec3ee-20241217"
16531+
isomorphicReactPackageVersion$jscomp$inline_1814,
16532+
"19.1.0-native-fb-6a4b46cd-20241217"
1653316533
)
1653416534
);
1653516535
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16549,12 +16549,12 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1654916549
null === componentOrElement ? null : componentOrElement.stateNode;
1655016550
return componentOrElement;
1655116551
};
16552-
var internals$jscomp$inline_1819 = {
16552+
var internals$jscomp$inline_1821 = {
1655316553
bundleType: 0,
16554-
version: "19.1.0-native-fb-facec3ee-20241217",
16554+
version: "19.1.0-native-fb-6a4b46cd-20241217",
1655516555
rendererPackageName: "react-dom",
1655616556
currentDispatcherRef: ReactSharedInternals,
16557-
reconcilerVersion: "19.1.0-native-fb-facec3ee-20241217",
16557+
reconcilerVersion: "19.1.0-native-fb-6a4b46cd-20241217",
1655816558
getLaneLabelMap: function () {
1655916559
for (
1656016560
var map = new Map(), lane = 1, index$292 = 0;
@@ -16572,16 +16572,16 @@ var internals$jscomp$inline_1819 = {
1657216572
}
1657316573
};
1657416574
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
16575-
var hook$jscomp$inline_2229 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
16575+
var hook$jscomp$inline_2231 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
1657616576
if (
16577-
!hook$jscomp$inline_2229.isDisabled &&
16578-
hook$jscomp$inline_2229.supportsFiber
16577+
!hook$jscomp$inline_2231.isDisabled &&
16578+
hook$jscomp$inline_2231.supportsFiber
1657916579
)
1658016580
try {
16581-
(rendererID = hook$jscomp$inline_2229.inject(
16582-
internals$jscomp$inline_1819
16581+
(rendererID = hook$jscomp$inline_2231.inject(
16582+
internals$jscomp$inline_1821
1658316583
)),
16584-
(injectedHook = hook$jscomp$inline_2229);
16584+
(injectedHook = hook$jscomp$inline_2231);
1658516585
} catch (err) {}
1658616586
}
1658716587
exports.createRoot = function (container, options) {
@@ -16675,4 +16675,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1667516675
listenToAllSupportedEvents(container);
1667616676
return new ReactDOMHydrationRoot(initialChildren);
1667716677
};
16678-
exports.version = "19.1.0-native-fb-facec3ee-20241217";
16678+
exports.version = "19.1.0-native-fb-6a4b46cd-20241217";

0 commit comments

Comments
 (0)