fix: Properly split domains on comma, viper doesn't do it for env vars (#22)

* fix: Properly split domains on comma, viper doesn't do it for env vars

* Trim spaces from domains in allow list

Author: bmonkman

.goreleaser.yml

@@ -7,7 +7,7 @@ builds:
   env:
   - CGO_ENABLED=0
   ldflags:
-    - -X github.com/commitdev/zero-notification-service/cmd.appVersion={{.Version}} -X github.com/commitdev/zero-notification-service/cmd.appBuild={{.ShortCommit}}
+    - -X main.appVersion={{.Version}} -X  main.appBuild={{.ShortCommit}}
   ignore:
     - goos: darwin
       goarch: arm64

cmd/server/main.go

@@ -38,6 +38,10 @@ func main() {
 
 	zap.S().Infow("zero-notification-service", "version", appVersion, "build", appBuild)
 
+	if len(config.AllowEmailToDomains) > 0 {
+		zap.S().Infow("Allowing email only to specified domains", "domains", config.AllowEmailToDomains)
+	}
+
 	// Heartbeat for liveness check
 	go heartbeat()
 

internal/config/config.go

@@ -1,6 +1,7 @@
 package config
 
 import (
+	"strings"
 	"time"
 
 	"github.com/spf13/viper"
@@ -60,14 +61,23 @@ func loadConfig() *Config {
 	viper.SetDefault(AllowEmailToDomains, []string{})
 	viper.BindEnv(AllowEmailToDomains, "ALLOW_EMAIL_TO_DOMAINS")
 
+	// Split the string on commas, viper doesn't support doing this to env vars
+	domains := []string{}
+	if strings.Trim(viper.GetString(AllowEmailToDomains), " ") != "" {
+		domains = strings.Split(viper.GetString(AllowEmailToDomains), ",")
+		for i, domain := range domains {
+			domains[i] = strings.Trim(domain, " ")
+		}
+	}
+
 	config := Config{
 		Port:                    viper.GetInt(Port),
 		SendgridAPIKey:          viper.GetString(SendgridAPIKey),
 		SlackAPIKey:             viper.GetString(SlackAPIKey),
 		GracefulShutdownTimeout: viper.GetDuration(GracefulShutdownTimeout),
 		StructuredLogging:       viper.GetBool(StructuredLogging),
 		DebugDumpRequests:       viper.GetBool(DebugDumpRequests),
-		AllowEmailToDomains:     viper.GetStringSlice(AllowEmailToDomains),
+		AllowEmailToDomains:     domains,
 	}
 
 	return &config